You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Edward Lesmes
c48fb8427c
Revert "git-cl: Refactor CMDUploadChange"
...
This reverts commit 9f29465e52
.
Reason for revert:
line 2302, in CMDUploadChange
change_id = change_ids[0]
IndexError: list index out of range
Original change's description:
> git-cl: Refactor CMDUploadChange
>
> Changes:
> - Add _GetDescriptionForUpload and _GetTitleForUpload.
> - Add ensure_change_id to ChangeDescription, that ensures the
> description has a particular Change-Id.
> - If more than a Change-Id was entered on new issue upload, remove
> all, and add a new one.
>
> Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com
Change-Id: Ibb76539066c103ec951fa8d02684bc10f84549bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2103531
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
..
gstools
…
OWNERS
[ninjalog_uploader] add tests
7 years ago
auth_test.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago
bot_update_coverage_test.py
Allow the bot_update api to not fetch tags from the git server.
6 years ago
cipd_bootstrap_test.py
depot_tools: Run auth, cipd_bootstrap, git_number tests on python3.
6 years ago
detect_host_arch_test.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago
download_from_google_storage_unittest.py
gsutil: Decode output from subprocess.
6 years ago
fetch_test.py
Add unit tests for fetch.py
5 years ago
fix_encoding_test.py
Use assertEqual() rather than assertEquals() in Python tests.
6 years ago
gclient_eval_unittest.py
gclient_eval: Raise an error on implicitly concatenated strings.
5 years ago
gclient_paths_test.py
depot_tools: Add tests for gclient_paths
5 years ago
gclient_scm_test.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago
gclient_smoketest.py
gclient: Make smoketests run on Windows.
6 years ago
gclient_test.py
gclient: Remove syntax validation flags.
5 years ago
gclient_utils_test.py
gclient_utils: Add temporary_file method.
5 years ago
gerrit_util_test.py
Reland "my_activity.py: Run using vpython3 by default."
5 years ago
git_cache_test.py
Allow the bot_update api to not fetch tags from the git server.
6 years ago
git_cl_creds_check_report.txt
git cl creds-check: improve report and give better recommendation.
8 years ago
git_cl_test.py
Revert "git-cl: Refactor CMDUploadChange"
5 years ago
git_common_test.py
Default to origin's default branch instead of always origin/master.
6 years ago
git_dates_test.py
Use assertEqual() rather than assertEquals() in Python tests.
6 years ago
git_drover_test.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago
git_footers_test.py
gclient_utils: Add temporary_file method.
5 years ago
git_hyper_blame_test.py
gclient_utils: Add temporary_file method.
5 years ago
git_map_test.py
git-map: Refactor and add simple tests
5 years ago
git_number_test.py
depot_tools: Run auth, cipd_bootstrap, git_number tests on python3.
6 years ago
git_rebase_update_test.py
git-rebase-update: Make tests run on Python 3.
6 years ago
gsutil_test.py
depot_tools: Make gsutil compatible with python3.
6 years ago
metrics_test.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago
my_activity_test.py
my_activity: Add some tests and fix some bugs
5 years ago
ninjalog_uploader_test.py
[ninjalog] fully anonymize build stats before sending
6 years ago
owners_finder_test.py
Randomize results of git cl owners
6 years ago
owners_unittest.py
depot_tools: Make owners tests run on Python 3
6 years ago
presubmit_unittest.py
git-cl: Run PostUpload hooks via CLI.
5 years ago
recipes_test.py
[recipes] Remove deprecated (ignored) --use-bootstrap flag
6 years ago
roll_dep_test.py
depot_tools: Run roll_dep tests on Python 3.
6 years ago
scm_unittest.py
scm: Fix bug when checking for valid revision and add tests.
5 years ago
subcommand_test.py
subcommand: Add tests.
5 years ago
subprocess2_test.py
subprocess2: Fix CalledProcessError str() method on Python 3.
5 years ago
upload_to_google_storage_unittest.py
gsutil: Decode output from subprocess.
6 years ago
watchlists_unittest.py
depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock
5 years ago