aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'b1a9672432'
${ noResults }
depot_tools/tests
History
Jamie Madill 3671a6a217 Revert "git-cl: Add diff lines of context setting." 
This reverts commit 812ac228e3.

Reason for revert: The fix was not sufficient to solve the git cl
format difference between 'git cl format' and 'git cl format --full'.
Looks like we'll need a different solution.

Original change's description:
> git-cl: Add diff lines of context setting.
> 
> Clients using some Clang-Format options can run into bugs when using
> 0 lines of context. AlignConsecutiveAssignments in particular is picky
> and behaves differently with 0 lines of context.
> 
> This behaviour lead to 'git cl format' behaving differently from
> 'git cl format --full'. That could also break presubmit format checks.
> Using >0 lines of context for 'git diff' fixes the inconsistency.
> 
> Add a setting 'DIFF_LINES_OF_CONTEXT' that can be controlled via
> codereview.settings. Defaults to zero to preserve the old behaviour.
> The setting allows the client to control the number of lines of context
> to use when running 'git cl format'.
> 
> Bug: angleproject:4003
> Change-Id: Ied2ebf23df4c41ba19bfbd5b8ddf526b56a20b31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1864309
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:4003
Change-Id: Ib6b70969509a1e5446922d488f11d13a0c59c536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877003
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 		6 years ago
..
gstools Scripts to download files from google storage based on sha1 sums 12 years ago
OWNERS [ninjalog_uploader] add tests 6 years ago
auth_test.py depot_tools: Clean up auth.py 6 years ago
bot_update_coverage_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
cipd_bootstrap_test.py [cipd] Add presubmit support for checking *.digests file. 7 years ago
download_from_google_storage_unittest.py Make download_from_google_storage_unittest.py work with Python 3. 6 years ago
fix_encoding_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
gclient_eval_unittest.py Add support for multi argument ands and ors, and the same precedence with 6 years ago
gclient_scm_test.py Add logging to bot_update.py and gclient_scm.py 6 years ago
gclient_smoketest.py Make gclient.py warn on Python 3 6 years ago
gclient_test.py Reland "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
gclient_utils_test.py Reland "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
gerrit_util_test.py gerrit_util: Add tests for CookiesAuthenticator 6 years ago
git_cache_test.py depot_tools: Run git_cache_test and git_footers_test on windows. 6 years ago
git_cl_creds_check_report.txt git cl creds-check: improve report and give better recommendation. 8 years ago
git_cl_test.py Revert "git-cl: Add diff lines of context setting." 6 years ago
git_common_test.py git-common: Explicitly specify utf-8 when encoding. 6 years ago
git_dates_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
git_drover_test.py git-drover: Fix tests to run on Python 3. 6 years ago
git_footers_test.py depot_tools: Run git_cache_test and git_footers_test on windows. 6 years ago
git_hyper_blame_test.py git-hyper-blame: Make tests run on Python 3. 6 years ago
git_number_test.py git-number: Make tests run on Python 3. 6 years ago
git_rebase_update_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
gsutil_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
metrics_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
ninjalog_uploader_test.py [ninjalog] fully anonymize build stats before sending 6 years ago
owners_finder_test.py Skip files owned by reviewers when quering for missing owners. 7 years ago
owners_unittest.py Presubmit: Fix relative owners check 6 years ago
presubmit_unittest.py Revert "presubmit_support: Fix tests on Python 3." 6 years ago
recipes_test.py [recipes] Remove deprecated (ignored) --use-bootstrap flag 6 years ago
roll_dep_test.py roll-dep: Use gclient setdep/getdep. 7 years ago
scm_unittest.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
subprocess2_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
upload_to_google_storage_unittest.py Make upload_to_google_storage.py and tests work with Python 3. 6 years ago
watchlists_unittest.py depot_tools: Make watchlist tests use mock and remove pymox. 6 years ago