aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
depot_tools/recipes/recipe_modules/gitiles
History
Aravind Vasudevan 23ddab2235 Reland "Break make_encoded_file into two functions" 
This is a reland of commit 5e49eda5c4

Original change's description:
> Break make_encoded_file into two functions
>
> The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8.
>
> Recipe-Manual-Change: chromiumos
> Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Reviewed-by: Greg Edelston <gredelston@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Recipe-Manual-Change: chromiumos
Change-Id: I321f797ae4a00deed7920ee6f80d666954b07c7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3625907
Reviewed-by: Greg Edelston <gredelston@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
..
examples Reland "Break make_encoded_file into two functions"
resources Reland "Use py3 in gitiles recipe module"
tests Add PYTHON_VERSION_COMPATIBILITY to gitiles and bot_update
OWNERS Remove tandrii@ from OWNERS under depot_tools
__init__.py Add PYTHON_VERSION_COMPATIBILITY to gitiles and bot_update
api.py Reland "Break make_encoded_file into two functions"
test_api.py Reland "Break make_encoded_file into two functions"