You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Aravind Vasudevan ada0ebd47d Revert "Break make_encoded_file into two functions" ... This reverts commit 5e49eda5c4. Reason for revert: chromiumos rollout fails Original change's description: > Break make_encoded_file into two functions > > The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8. > > Recipe-Manual-Change: chromiumos > Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Greg Edelston <gredelston@google.com> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Change-Id: Ibfb51614f9e19b575b99704aa4ca33c5525ab294 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3602168 Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>		3 years ago
..
basic.json	Revert "Break make_encoded_file into two functions"	3 years ago