You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
db8622bc6b
It is easy to get type confusion and end up passing a list as the message parameter to _PresubmitResult. This error will not be detected until the end of the run - perhaps hours later - when all evidence of where the list came from is lost. This change ensures that the message parameter is a string. If it is not then the exception that is thrown should allow quick identification of the problematic code. This also fixes a presubmit unit test that passed None as the message. We could support that but I don't think that we should. Bug: 1309977 Change-Id: Ifb1d5100d47922b0ebd8bb834caa6fbba690b43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566436 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> |
3 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| OWNERS | 6 years ago | |
| PRESUBMIT.py | 4 years ago | |
| auth_test.py | 5 years ago | |
| bot_update_coverage_test.py | 3 years ago | |
| cipd_bootstrap_test.py | 5 years ago | |
| detect_host_arch_test.py | 4 years ago | |
| download_from_google_storage_unittest.py | 3 years ago | |
| fetch_test.py | 3 years ago | |
| fix_encoding_test.py | 3 years ago | |
| gclient_cipd_smoketest.py | 5 years ago | |
| gclient_eval_unittest.py | 4 years ago | |
| gclient_git_mutates_smoketest.py | 4 years ago | |
| gclient_git_smoketest.py | 4 years ago | |
| gclient_paths_test.py | 5 years ago | |
| gclient_scm_test.py | 3 years ago | |
| gclient_smoketest.py | 5 years ago | |
| gclient_smoketest_base.py | 3 years ago | |
| gclient_test.py | 3 years ago | |
| gclient_transitions_smoketest.py | 5 years ago | |
| gclient_utils_test.py | 4 years ago | |
| gerrit_client_test.py | 4 years ago | |
| gerrit_util_test.py | 4 years ago | |
| git_cache_test.py | 5 years ago | |
| git_cl_creds_check_report.txt | 5 years ago | |
| git_cl_test.py | 3 years ago | |
| git_common_test.py | 3 years ago | |
| git_dates_test.py | 6 years ago | |
| git_find_releases_test.py | 3 years ago | |
| git_footers_test.py | 4 years ago | |
| git_hyper_blame_test.py | 5 years ago | |
| git_map_test.py | 4 years ago | |
| git_migrate_default_branch_test.py | 3 years ago | |
| git_number_test.py | 6 years ago | |
| git_rebase_update_test.py | 3 years ago | |
| gsutil_test.py | 4 years ago | |
| lockfile_test.py | 5 years ago | |
| metrics_test.py | 4 years ago | |
| my_activity_test.py | 4 years ago | |
| ninjalog_uploader_test.py | 3 years ago | |
| owners_client_test.py | 4 years ago | |
| owners_finder_test.py | 4 years ago | |
| owners_unittest.py | 5 years ago | |
| presubmit_unittest.py | 3 years ago | |
| rdb_wrapper_test.py | 5 years ago | |
| recipes_test.py | 3 years ago | |
| roll_dep_test.py | 5 years ago | |
| scm_unittest.py | 4 years ago | |
| split_cl_test.py | 4 years ago | |
| subcommand_test.py | 5 years ago | |
| subprocess2_test.py | 3 years ago | |
| upload_to_google_storage_unittest.py | 4 years ago | |
| utils_test.py | 3 years ago | |
| watchlists_unittest.py | 5 years ago | |