You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
If every file in a change has OWNERS, then the code would find them fine. Similarly, if no files has OWNERS, then this code would return an empty set just fine. But if some files had OWNERS while others didn't, it would crash when it tried to find an OWNER for file 'foo' while all the possible OWNERS only provided coverage for file 'bar'. This code purges the list of possible OWNERS as they become useless for providing additional coverage, and returns whatever set we have accumulated so far when the set of possible OWNERS becomes empty. R=iannucci@chromium.org Bug: 715062 Change-Id: I408601bd89379381db1cc7df56beed97ab3c27e6 Reviewed-on: https://chromium-review.googlesource.com/506239 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> |
9 years ago | |
|---|---|---|
| bootstrap | 9 years ago | |
| fetch_configs | 9 years ago | |
| git-templates | ||
| infra | 9 years ago | |
| man | 9 years ago | |
| recipes | 9 years ago | |
| support | ||
| testing_support | 9 years ago | |
| tests | 9 years ago | |
| third_party | 9 years ago | |
| win_toolchain | 9 years ago | |
| zsh-goodies | ||
| .gitignore | 9 years ago | |
| .style.yapf | ||
| LICENSE | ||
| OWNERS | 9 years ago | |
| PRESUBMIT.py | 9 years ago | |
| README.gclient.md | 9 years ago | |
| README.git-cl.md | 9 years ago | |
| README.md | 9 years ago | |
| README.testing | ||
| WATCHLISTS | 9 years ago | |
| annotated_gclient.py | ||
| appengine_mapper.py | 9 years ago | |
| apply_issue | ||
| apply_issue.bat | ||
| apply_issue.py | 9 years ago | |
| auth.py | ||
| breakpad.py | 10 years ago | |
| buildbucket.py | 10 years ago | |
| cbuildbot | ||
| checkout.py | 9 years ago | |
| chrome_set_ver | ||
| cipd | 9 years ago | |
| cipd.bat | 9 years ago | |
| cipd.ps1 | 9 years ago | |
| cipd_bin_setup.bat | 9 years ago | |
| cipd_bin_setup.sh | 9 years ago | |
| cipd_client_version | 9 years ago | |
| cipd_manifest.txt | 9 years ago | |
| cit | 11 years ago | |
| cit.bat | 11 years ago | |
| cit.py | 9 years ago | |
| clang-format | ||
| clang-format.bat | ||
| clang_format.py | 9 years ago | |
| clang_format_merge_driver | 9 years ago | |
| clang_format_merge_driver.bat | 9 years ago | |
| clang_format_merge_driver.py | 9 years ago | |
| codereview.settings | 9 years ago | |
| commit_queue | 10 years ago | |
| commit_queue.bat | 10 years ago | |
| commit_queue.py | 9 years ago | |
| cpplint.bat | ||
| cpplint.py | 9 years ago | |
| cpplint_chromium.py | ||
| create-ntfs-junction.c | ||
| create-ntfs-junction.exe | ||
| cros | ||
| cros_sdk | ||
| dart_format.py | ||
| depot-tools-auth | ||
| depot-tools-auth.bat | ||
| depot-tools-auth.py | 10 years ago | |
| download_from_google_storage | ||
| download_from_google_storage.bat | ||
| download_from_google_storage.py | 10 years ago | |
| fetch | ||
| fetch.bat | ||
| fetch.py | 9 years ago | |
| fix_encoding.py | 9 years ago | |
| gclient | 10 years ago | |
| gclient-new-workdir.py | 10 years ago | |
| gclient.bat | 10 years ago | |
| gclient.py | 9 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 9 years ago | |
| gclient_scm.py | 9 years ago | |
| gclient_utils.py | 9 years ago | |
| gerrit_client.py | 9 years ago | |
| gerrit_util.py | 9 years ago | |
| git-cache | 10 years ago | |
| git-cherry-pick-upload | 10 years ago | |
| git-cl | 10 years ago | |
| git-crrev-parse | 9 years ago | |
| git-crsync | ||
| git-drover | 10 years ago | |
| git-find-releases | 10 years ago | |
| git-footers | 10 years ago | |
| git-freeze | 10 years ago | |
| git-gs | 9 years ago | |
| git-hyper-blame | 10 years ago | |
| git-map | 10 years ago | |
| git-map-branches | 10 years ago | |
| git-mark-merge-base | 10 years ago | |
| git-nav-downstream | 10 years ago | |
| git-nav-upstream | ||
| git-new-branch | 10 years ago | |
| git-number | 10 years ago | |
| git-rebase-update | 10 years ago | |
| git-rename-branch | 10 years ago | |
| git-reparent-branch | 10 years ago | |
| git-retry | 10 years ago | |
| git-runhooks | ||
| git-squash-branch | 10 years ago | |
| git-thaw | 10 years ago | |
| git-upstream-diff | 10 years ago | |
| git_cache.py | 9 years ago | |
| git_cherry_pick_upload.py | 9 years ago | |
| git_cl.py | 9 years ago | |
| git_cl_completion.sh | 9 years ago | |
| git_common.py | 9 years ago | |
| git_dates.py | 10 years ago | |
| git_drover.py | 9 years ago | |
| git_find_releases.py | 10 years ago | |
| git_footers.py | 9 years ago | |
| git_freezer.py | ||
| git_hyper_blame.py | 9 years ago | |
| git_map.py | 9 years ago | |
| git_map_branches.py | 9 years ago | |
| git_mark_merge_base.py | ||
| git_nav_downstream.py | ||
| git_new_branch.py | 10 years ago | |
| git_number.py | ||
| git_rebase_update.py | 9 years ago | |
| git_rename_branch.py | ||
| git_reparent_branch.py | 10 years ago | |
| git_retry.py | 9 years ago | |
| git_squash_branch.py | 9 years ago | |
| git_upstream_diff.py | 10 years ago | |
| gn | ||
| gn.bat | ||
| gn.py | ||
| gsutil.py | 10 years ago | |
| my_activity.py | 9 years ago | |
| my_reviews.py | 9 years ago | |
| ninja | 9 years ago | |
| ninja-linux32 | 9 years ago | |
| ninja-linux64 | 9 years ago | |
| ninja-mac | 9 years ago | |
| ninja.exe | 9 years ago | |
| owners.py | 9 years ago | |
| owners_finder.py | 9 years ago | |
| patch.py | ||
| presubmit_canned_checks.py | 9 years ago | |
| presubmit_support.py | 9 years ago | |
| profile.xml | ||
| pylint | ||
| pylint.py | 10 years ago | |
| pylintrc | 9 years ago | |
| python_runner.sh | 10 years ago | |
| repo | 9 years ago | |
| rietveld.py | 9 years ago | |
| roll-dep | ||
| roll-dep-svn | 9 years ago | |
| roll-dep-svn.bat | 9 years ago | |
| roll-dep.bat | ||
| roll_dep.py | 9 years ago | |
| roll_dep_svn.py | 9 years ago | |
| scm.py | 9 years ago | |
| setup_color.py | 9 years ago | |
| subcommand.py | 9 years ago | |
| subprocess2.py | 9 years ago | |
| update_depot_tools | 10 years ago | |
| update_depot_tools.bat | 10 years ago | |
| upload_to_google_storage.py | 9 years ago | |
| vpython | 9 years ago | |
| vpython.bat | 9 years ago | |
| watchlists.py | ||
| weekly | ||
| wtf | ||
README.md
depot_tools
Tools for working with Chromium development. It requires python 2.7.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.