You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
e856b6bba8
When set_output_commit is True and the repo associated with the got_revision property does not use commit positions, buiders whose gclient config uses RevisionFallbackChain for that repo will raise an exception when attempting set the output commit because a string is expected for the revision value, not a RevisionFallbackChain object. This changes the set_output_commit code to resolve the revision so that the output commit can be set in those cases. Bug: 1159749, 1141886 Change-Id: Iddf1d49871028d9500eefb0eed07e36ce7e6b0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612223 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> |
5 years ago | |
|---|---|---|
| .. | ||
| add_blamelists.json | 5 years ago | |
| add_blamelists_bot_update_failure.json | 5 years ago | |
| basic.json | 5 years ago | |
| basic_with_branch_heads.json | 5 years ago | |
| bot_update_failure.json | 5 years ago | |
| clobber.json | 6 years ago | |
| deprecated_got_revision_mapping.json | 5 years ago | |
| gerrit_no_rebase_patch_ref.json | 6 years ago | |
| gerrit_no_reset.json | 6 years ago | |
| input_commit_with_id_without_repo.json | 5 years ago | |
| multiple_patch_refs.json | 6 years ago | |
| no_apply_patch_on_gclient.json | 5 years ago | |
| no_cp_checkout_HEAD.json | 5 years ago | |
| no_cp_checkout_a_branch_head.json | 5 years ago | |
| no_cp_checkout_a_specific_commit.json | 5 years ago | |
| no_cp_checkout_master.json | 5 years ago | |
| origin_master.json | 5 years ago | |
| refs.json | 6 years ago | |
| reset_root_solution_revision.json | 5 years ago | |
| resolve_chromium_fixed_version.json | 5 years ago | |
| revision_fallback_chain_set_output_commit.json | 5 years ago | |
| tryjob_fail.json | 5 years ago | |
| tryjob_fail_patch.json | 5 years ago | |
| tryjob_fail_patch_download.json | 5 years ago | |
| tryjob_gerrit_angle.json | 5 years ago | |
| tryjob_gerrit_branch_heads.json | 5 years ago | |
| tryjob_gerrit_feature_branch.json | 5 years ago | |
| tryjob_gerrit_v8_feature_branch.json | 5 years ago | |
| tryjob_gerrit_webrtc.json | 5 years ago | |
| tryjob_v8.json | 5 years ago | |
| tryjob_v8_head_by_default.json | 5 years ago | |
| unrecognized_commit_repo.json | 7 years ago | |
| with_tags.json | 6 years ago | |