aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '81ec8e2aa5'
${ noResults }
depot_tools/recipes/recipe_modules
History
Garrett Beaty d81e5f52fc Fix exception when not setting output commit with no ref. 
crrev.com/c/6049353 updated bot_update.ensure_checkout to comput the
output commit even when not setting the output commit so that callers
could do custom logic for setting output commits while still having
access to the one computed by bot_update. Unfortunately, this changed
behavior for some builds that have set_output_commit set false. When
computing the output commit, if none of the conditions that set the ref
on the output commit were true then an AssertionError would be raised
indicating that the caller should call
buildbucket.set_output_gitiles_commit. With crrev.com/c/6049353, the
assertion can be raised even if set_output_commit is false.

This changes it so that the constraint on the ref field is only enforced
when set_output_commit is true.

Bug: 366409421
Change-Id: Ifb3a39784d75a3c47a7d4a6e2ac9957c29a09938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6064719
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 		6 months ago
..
bot_update Fix exception when not setting output commit with no ref. 6 months ago
depot_tools Add roll_downstream_gcs_deps.py to depot_tools recipe module. 9 months ago
gclient Add infradata/cloud-run config 7 months ago
gerrit recipe: introduce add_message api 7 months ago
git [git] Remove tags / branches filter from ls-remote 7 months ago
git_cl Reland "Drop py2 support in recipe modules" 2 years ago
gitiles [gerrit_client] Uprev vpython python to 3.11 10 months ago
gsutil Replace Path.join() with / and Path.joinpath() 1 year ago
osx_sdk [recipes/*_sdk] Replace '[*]' paths in comments 1 year ago
presubmit Surface git errors in the build summary for presubmit builds 7 months ago
tryserver Replace Path.join() with / and Path.joinpath() 1 year ago
windows_sdk [recipes/*_sdk] Replace '[*]' paths in comments 1 year ago
OWNERS Fix recipe autoroller account. 5 years ago