aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '7a0b07a8a5'
${ noResults }
depot_tools/tests
History
Bruce Dawson 7a0b07a8a5 Fix slash direction sensitivity in git cl owners 
Slashes and backslashes are interchangeable on Windows in many contexts.
But not all. In particular, if you add a path to a dictionary and then
try looking it up with an equivalent path that has different slashes
then - not surprisingly - the lookup will fail. Therefore it is
important to always use slashes when populating _paths_to_owners. This
is now done, and documented.

Additionally, while fnmatch.fnmatch handles comparing slash separated
paths to backslash separated paths, fnmatch.translate does not. This is
arguably a bug in fnmatch.translate, or at least something that should
be documented. This bug is worked around by having _fnmatch sanitize
file names to always use slashes, and asserting that the patterns do
not contain backslashes.

With these changes this command:
  git cl owners --ignore-current --show-all chrome/browser/BUILD.gn
now correctly gives the same results as this command on Windows:
  git cl owners --ignore-current --show-all chrome\browser\BUILD.gn

The modified test fails without the other changes, passes with them.

Bug: 1009104
Change-Id: I416c7131281f00e352c1d2b85c30fcc463417fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915410
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 		6 years ago
..
gstools
…
OWNERS [ninjalog_uploader] add tests 8 years ago
auth_test.py Run spellchecker on depot_tools 6 years ago
bot_update_coverage_test.py Allow the bot_update api to not fetch tags from the git server. 7 years ago
cipd_bootstrap_test.py [cipd] Take cipd.ps1 out of %PATH%. 6 years ago
detect_host_arch_test.py depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 7 years ago
download_from_google_storage_unittest.py gsutil: Decode output from subprocess. 7 years ago
fetch_test.py Add unit tests for fetch.py 6 years ago
fix_encoding_test.py Use assertEqual() rather than assertEquals() in Python tests. 7 years ago
gclient_cipd_smoketest.py depot_tools: Split gclient_smoketests. 6 years ago
gclient_eval_unittest.py Run spellchecker on depot_tools 6 years ago
gclient_git_smoketest.py Run spellchecker on depot_tools 6 years ago
gclient_paths_test.py depot_tools: Add tests for gclient_paths 7 years ago
gclient_scm_test.py gclient: Set with_branch_heads if asked to sync to refs/branch-heads/* 6 years ago
gclient_smoketest.py depot_tools: Split gclient_smoketests. 6 years ago
gclient_smoketest_base.py Run spellchecker on depot_tools 6 years ago
gclient_test.py Run spellchecker on depot_tools 6 years ago
gclient_transitions_smoketest.py depot_tools: Split gclient_smoketests. 6 years ago
gclient_utils_test.py gclient_utils: Add temporary_file method. 6 years ago
gerrit_client_test.py Add gerrit_client unit tests 6 years ago
gerrit_util_test.py ReadHttpResponse: Handle 429s with retries and adjust retry count 6 years ago
git_cache_test.py git-cache: Also bootstrap in the case that there are 0 pack files 6 years ago
git_cl_creds_check_report.txt Add support for git_cl_tests on Windows platform 6 years ago
git_cl_test.py git cl patch: support short CL URLs. 6 years ago
git_common_test.py Default to origin's default branch instead of always origin/master. 7 years ago
git_dates_test.py Use assertEqual() rather than assertEquals() in Python tests. 7 years ago
git_drover_test.py Decode the returned encoded bytes of subprocess.check_all/check_output. 6 years ago
git_find_releases_test.py Add unit tests for git_find_releases 6 years ago
git_footers_test.py gclient_utils: Add temporary_file method. 6 years ago
git_hyper_blame_test.py Add support for git_hyper_blame for Windows 6 years ago
git_map_test.py git-map: Refactor and add simple tests 7 years ago
git_number_test.py depot_tools: Run auth, cipd_bootstrap, git_number tests on python3. 7 years ago
git_rebase_update_test.py git-rebase-update: Make tests run on Python 3. 7 years ago
gsutil_test.py depot_tools: Make gsutil compatible with python3. 7 years ago
metrics_test.py Reland "metrics: Use vpython3 instead of sys.executable" 6 years ago
my_activity_test.py Run spellchecker on depot_tools 6 years ago
ninjalog_uploader_test.py [ninjalog] fully anonymize build stats before sending 8 years ago
owners_finder_test.py Fix slash direction sensitivity in git cl owners 6 years ago
owners_unittest.py Run spellchecker on depot_tools 6 years ago
presubmit_unittest.py Run spellchecker on depot_tools 6 years ago
recipes_test.py [recipes] Remove deprecated (ignored) --use-bootstrap flag 8 years ago
roll_dep_test.py Fix Python3 integer division issue in roll-dep. 6 years ago
scm_unittest.py Reland "git-cl: Remove unused and duplicate functions." 6 years ago
subcommand_test.py Move subcommand_test to py3 6 years ago
subprocess2_test.py Add win support for subprocess2 unit tests 6 years ago
upload_to_google_storage_unittest.py gsutil: Decode output from subprocess. 7 years ago
watchlists_unittest.py depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 7 years ago