You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
This makes no-rebase-patch-ref correctly populate `file_list` and work with `git diff --cached` (i.e. they will show only the files affected by the patchset). Previously gclient would `reset --soft` to master. Because we didn't rebase on top of master with `no-rebase-patch-ref`, it has roughly nothing to do with the patchref we just checked out. R=gbeaty@chromium.org, ltina@google.com, tandrii@chromium.org Context: Tricium recipes sometimes need to use no-rebase-patch-ref in order to get accurate linenumbers in the diff (i.e. so that the tricium comments will actually line up correctly with the patchset the user uploaded); Tricium recipes also need to accurately get the diff file list in this mode. Change-Id: I5f3c95cd4958cf407a83b96c238b8c55c452ac81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895041 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> |
6 years ago | |
---|---|---|
.. | ||
gstools | ||
OWNERS | 7 years ago | |
auth_test.py | 6 years ago | |
bot_update_coverage_test.py | 6 years ago | |
cipd_bootstrap_test.py | ||
download_from_google_storage_unittest.py | 6 years ago | |
fix_encoding_test.py | 6 years ago | |
gclient_eval_unittest.py | 6 years ago | |
gclient_scm_test.py | 6 years ago | |
gclient_smoketest.py | 6 years ago | |
gclient_test.py | 6 years ago | |
gclient_utils_test.py | 6 years ago | |
gerrit_util_test.py | 6 years ago | |
git_cache_test.py | 6 years ago | |
git_cl_creds_check_report.txt | ||
git_cl_test.py | 6 years ago | |
git_common_test.py | 6 years ago | |
git_dates_test.py | 6 years ago | |
git_drover_test.py | 6 years ago | |
git_footers_test.py | 6 years ago | |
git_hyper_blame_test.py | 6 years ago | |
git_number_test.py | 6 years ago | |
git_rebase_update_test.py | 6 years ago | |
gsutil_test.py | 6 years ago | |
metrics_test.py | 6 years ago | |
ninjalog_uploader_test.py | 7 years ago | |
owners_finder_test.py | 6 years ago | |
owners_unittest.py | 6 years ago | |
presubmit_unittest.py | 6 years ago | |
recipes_test.py | 7 years ago | |
roll_dep_test.py | ||
scm_unittest.py | 6 years ago | |
subprocess2_test.py | 6 years ago | |
upload_to_google_storage_unittest.py | 6 years ago | |
watchlists_unittest.py | 6 years ago |