depot_tools

You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

Stephanie Kim 3481645827 Check if json exists in ensure_checkout's finally block The step_result json can currently be empty if the orchestrator build is canceled while running bot_update. Trying to do step_result.json.output in the finally block raises an "Uncaught exception AttributeError". Ex: https://ci.chromium.org/ui/p/chromium/builders/try/win10_chromium_x64_rel_ng/1121568/overview This change checks for the json attr before trying to read json.output. Bug: 1305332 Change-Id: I1dc277642ece1b96144be6381a7c4b8426cb2bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3518372 Reviewed-by: Garrett Beaty <gbeaty@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com>	4 years ago
..
full.expected	Replace python3 with vpython in bot_update/api.py	4 years ago
full.py	Check if json exists in ensure_checkout's finally block	4 years ago

Stephanie Kim 3481645827 Check if json exists in ensure_checkout's finally block

The step_result json can currently be empty if the orchestrator build
is canceled while running bot_update. Trying to do
step_result.json.output in the finally block raises an "Uncaught
exception AttributeError".
Ex: https://ci.chromium.org/ui/p/chromium/builders/try/win10_chromium_x64_rel_ng/1121568/overview

This change checks for the json attr before trying to read json.output.

Bug: 1305332
Change-Id: I1dc277642ece1b96144be6381a7c4b8426cb2bc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3518372
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>

full.expected

Replace python3 with vpython in bot_update/api.py

full.py

Check if json exists in ensure_checkout's finally block