You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Raul Tambre 70eba7d2d1 setup_color: Don't fill created string buffer with nulls
This causes an error since Python 3.5 due to a regression (https://bugs.python.org/issue32745):
Traceback (most recent call last):
  File "C:\Google\depot_tools\metrics.py", line 267, in print_notice_and_exit
    yield
  File "C:\Google\depot_tools\gclient.py", line 3153, in <module>
    sys.exit(main(sys.argv[1:]))
  File "C:\Google\depot_tools\gclient.py", line 3136, in main
    setup_color.init()
  File "C:\Google\depot_tools\setup_color.py", line 70, in init
    buf = ctypes.create_string_buffer('\0', 1024)
  File "C:\Program Files\Python38\lib\ctypes\__init__.py", line 63, in create_string_buffer
    raise TypeError(init)
TypeError: <Unicode console <stderr>>.write: ArgumentError("argument 2: <class 'ValueError'>: embedded null character")

Simply not filling the buffer with NULLs doesn't change the behaviour.

Bug: 942522
Change-Id: I1feb81555e995597b0b70f4aee9151fea755510c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701402
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
bootstrap/win [bootstrap/win] Release Python 2.7.15 6 years ago
fetch_configs Invert ios_internal fetch spec. 6 years ago
git-templates Explicitly exec hooks inside a shell. 12 years ago
infra Roll recipe dependencies (trivial). 6 years ago
man Convert print statements to Python 3 style 6 years ago
recipes Add failure status on timeouts 6 years ago
support chromite_wrapper: add python3 support for except 7 years ago
testing_support subprocess2, gerrit_test_case: Use SIGTERM instead of SIGKILL for Windows support 6 years ago
tests git-cl: add --preserve-tryjobs option for upload command. 6 years ago
third_party depot_tools: Remove unused third_party libraries. 6 years ago
win_toolchain Convert print statements to Python 3 style 6 years ago
zsh-goodies Remove unmaintained "gclient export" command, 14 years ago
.gitattributes Add autoninja* to .gitattributes. 7 years ago
.gitignore git-cl: Always collect git traces. 6 years ago
.style.yapf Add experimental support for python in 'git cl format' 10 years ago
CROS_OWNERS OWNERS: start a CrOS specific list for CrOS files in here 6 years ago
LICENSE Create the Next Generation of depot_tools. Eh. 16 years ago
OWNERS [OWNERS] revive agable 6 years ago
PRESUBMIT.py Call new CheckJsonParses in PRESUBMIT 6 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md Proofread README.git-cl.md. 9 years ago
README.md Update depot_tools README cpplint section 6 years ago
README.testing Move git_cl back into depot_tools. 14 years ago
WATCHLISTS Remove tandrii@ from watching git cl changes. 7 years ago
annotated_gclient.py Convert print statements to Python 3 style 6 years ago
appengine_mapper.py Automatically map urls to their raw appengine forms 9 years ago
auth.py Convert print statements to Python 3 style 6 years ago
autoninja [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 6 years ago
autoninja.bat [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 6 years ago
autoninja.py Update autoninja's psutil from v5.2.2 to v5.6.2 6 years ago
bb do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
bb.bat [bb] Deploy bb 6 years ago
breakpad.py Finally get rid of depot_tools' breakpad. 9 years ago
buildbucket.py Convert print statements to Python 3 style 6 years ago
cbuildbot Cleanup chromite_wrapper. 13 years ago
checkout.py Convert except statements to be Python 3 compatible 6 years ago
chrome_set_ver Cleanup chromite_wrapper. 13 years ago
cipd do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
cipd.bat [cipd] Check CIPD client hash during updates on Windows. 7 years ago
cipd.ps1 [cipd] More careful error handling during CIPD bootstrap on Windows. 7 years ago
cipd_bin_setup.bat [cipd] Bump version, log at warning (#2). 8 years ago
cipd_bin_setup.sh Fix depot_tools errors that cause runhooks to be inoperable for Cygwin 8 years ago
cipd_client_version [cipd] Update CIPD client to v2.2.19. 6 years ago
cipd_client_version.digests [cipd] Update CIPD client to v2.2.19. 6 years ago
cipd_manifest.txt [lucicfg] Update to the latest version. 6 years ago
cipd_manifest.versions [lucicfg] Update to the latest version. 6 years ago
cit Added tool to call tools in infra.git 10 years ago
cit.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cit.py Convert print statements to Python 3 style 6 years ago
clang-format Depot tools: use the clang-format binaries that are now included 11 years ago
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Convert print statements to Python 3 style 6 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Convert except statements to be Python 3 compatible 6 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Make it clear that compile_single_file.py doesn't support Jumbo builds 6 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py CppLint changes for VSCode cpplint plugin 6 years ago
cpplint_chromium.py Add lint check against "Foo *bar" and "Foo &bar" declarations. 14 years ago
cros Add cros wrapper to depot_tools. 13 years ago
cros_sdk Cleanup chromite_wrapper. 13 years ago
dart_format.py Convert except statements to be Python 3 compatible 6 years ago
depot-tools-auth Add OAuth2 support for end users (i.e. 3-legged flow with the browser). 10 years ago
depot-tools-auth.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
depot-tools-auth.py Convert print statements to Python 3 style 6 years ago
detect_host_arch.py Improve gclient Python 3 compatibility 6 years ago
download_from_google_storage Added posix and windows runner scripts for download_from_google_storage.py 12 years ago
download_from_google_storage.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
download_from_google_storage.py Show nice error on failure to enumerage input files. 6 years ago
ensure_bootstrap [depot_tools] Add "ensure_bootstrap" script. 8 years ago
fetch Update fetch to support more flexible refspecs 11 years ago
fetch.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
fetch.py depot_tools: bail out if $PATH contains tildes 6 years ago
fix_encoding.py Convert print statements to Python 3 style 6 years ago
gclient gclient setdep doesn't need to update_depot_tools 7 years ago
gclient-new-workdir.py Convert print statements to Python 3 style 6 years ago
gclient.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gclient.py Reland "Reland "gclient: Require a target ref when applying patches."" 6 years ago
gclient_completion.sh Added basic completion (the commands) for gclient. 11 years ago
gclient_eval.py Add 'X in tuple()' support to gclient conditionals. 6 years ago
gclient_paths.py Improve gclient Python 3 compatibility 6 years ago
gclient_scm.py Reland "Reland "gclient: Require a target ref when applying patches."" 6 years ago
gclient_utils.py Update colorama to 0.4.1 6 years ago
gerrit_client.py Add gerrit.abandon_change command 6 years ago
gerrit_util.py Convert print statements to Python 3 style 6 years ago
git-cache Generalize python_git_runner for use in non-git scripts. 10 years ago
git-cl Generalize python_git_runner for use in non-git scripts. 10 years ago
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-drover Generalize python_git_runner for use in non-git scripts. 10 years ago
git-find-releases Generalize python_git_runner for use in non-git scripts. 10 years ago
git-footers Generalize python_git_runner for use in non-git scripts. 10 years ago
git-freeze Generalize python_git_runner for use in non-git scripts. 10 years ago
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git-map Generalize python_git_runner for use in non-git scripts. 10 years ago
git-map-branches Generalize python_git_runner for use in non-git scripts. 10 years ago
git-mark-merge-base Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-downstream Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-number Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rebase-update Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rename-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-reparent-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-retry Generalize python_git_runner for use in non-git scripts. 10 years ago
git-runhooks Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-squash-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-thaw Generalize python_git_runner for use in non-git scripts. 10 years ago
git-upstream-diff Generalize python_git_runner for use in non-git scripts. 10 years ago
git_cache.py Pruning old directories/ready files. 6 years ago
git_cl.py git-cl: add --preserve-tryjobs option for upload command. 6 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py Ignore git submodules when calculating dirty files. 6 years ago
git_dates.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover.py Convert print statements to Python 3 style 6 years ago
git_find_releases.py Convert print statements to Python 3 style 6 years ago
git_footers.py Convert print statements to Python 3 style 6 years ago
git_freezer.py Convert print statements to Python 3 style 6 years ago
git_hyper_blame.py git hyper-blame: Fix tabulation of Unicode characters in author name. 7 years ago
git_map.py git-map: use committer date instead of author date 8 years ago
git_map_branches.py Convert print statements to Python 3 style 6 years ago
git_mark_merge_base.py Convert print statements to Python 3 style 6 years ago
git_nav_downstream.py Convert print statements to Python 3 style 6 years ago
git_new_branch.py Revert "Fix semantics of git new-branch --upstream" 6 years ago
git_number.py Convert print statements to Python 3 style 6 years ago
git_rebase_update.py Convert print statements to Python 3 style 6 years ago
git_rename_branch.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_reparent_branch.py Convert print statements to Python 3 style 6 years ago
git_retry.py [git retry] Fix Git wrapper fallthrough. 8 years ago
git_squash_branch.py Include branch name in git-squash-branch's default message 8 years ago
git_upstream_diff.py Convert print statements to Python 3 style 6 years ago
gn Add executable and line ending properties for GN. 12 years ago
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py Convert print statements to Python 3 style 6 years ago
gsutil.py Improve gclient Python 3 compatibility 6 years ago
gsutil.py.bat Add windows .bat file for gsutil.py. 6 years ago
gsutil.vpython Add the crcmod wheel for gsutil, to get it to shut up. 7 years ago
led do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
luci-auth do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
luci-auth.bat [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
lucicfg.bat [cipd] Add lucicfg tool. 6 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md metrics: Collect full timestamps. 6 years ago
metrics.py metrics: Convert timestamp and depot_tools_age to integers. 6 years ago
metrics_utils.py metrics: Collect full timestamps. 6 years ago
my_activity.py Make it clear in the help message that my_activity.py dates are mm/dd/yy 6 years ago
my_reviews.py Convert print statements to Python 3 style 6 years ago
ninja [ninja] update ninja repository url 6 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
ninjalog.README.md [ninjalog] add ninjalog.README.md 6 years ago
ninjalog_uploader.py [ninjalog_uploader] add path for httplib2 6 years ago
ninjalog_uploader_wrapper.py Convert print statements to Python 3 style 6 years ago
owners.py Improved comments for the recent optimization in owners.py 6 years ago
owners_finder.py Convert print statements to Python 3 style 6 years ago
patch.py Fix invalid Python file encoding "utf8" 6 years ago
post_build_ninja_summary.py Convert print statements to Python 3 style 6 years ago
presubmit_canned_checks.py Add JSON-parsing presubmit check 6 years ago
presubmit_support.py Make sure PresubmitResult can be converted to a json. 6 years ago
profile.xml Create the Next Generation of depot_tools. Eh. 16 years ago
prpc do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
prpc.bat [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
pylint Fix git-cl quoting, yet again. 12 years ago
pylint.py Permits running pylint without pylintrc. 10 years ago
pylintrc pylint: reland upgrade to 1.5.6 7 years ago
python_runner.sh Multiple improvements to windows bash integration. 9 years ago
repo repo: update launcher to v1.13.1 6 years ago
rietveld.py Convert except statements to be Python 3 compatible 6 years ago
roll-dep Convenience tool for rolling git-style deps with an svn revision. 11 years ago
roll-dep-svn Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
roll-dep-svn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll-dep.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll_dep.py Convert print statements to Python 3 style 6 years ago
roll_dep_svn.py Convert print statements to Python 3 style 6 years ago
scm.py scm: Replace invalid UTF-8 in Git output 6 years ago
setup_color.py setup_color: Don't fill created string buffer with nulls 6 years ago
split_cl.py Convert print statements to Python 3 style 6 years ago
subcommand.py Revert "gclient: return non-zero exit code on unknown command" 8 years ago
subprocess2.py subprocess2, gerrit_test_case: Use SIGTERM instead of SIGKILL for Windows support 6 years ago
update_depot_tools fix fetch on aix 7 years ago
update_depot_tools.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_metrics.py Suppress URLErrors when uploading metrics. 7 years ago
upload_to_google_storage.py Convert print statements to Python 3 style 6 years ago
vpython do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
vpython.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
watchlists.py Convert except statements to be Python 3 compatible 6 years ago
weekly Convert print statements to Python 3 style 6 years ago
wtf Convert print statements to Python 3 style 6 years ago
yapf Update yapf version 0.22 -> 0.24 7 years ago
yapf.bat Fix git cl format --python on windows 7 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.