You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Jiewei Qian 6da6aecbb4 git-cl: make SetReview ReAuth capable
This CL changes SetReview to be ReAuth capable.

This is a potential breaking change if an downstream script relies on
gerrit_util.SetReview but hasn't implemented ReAuth.

If this caused breakage, please refer to https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/gerrit_reauth.md#Troubleshooting for troubleshooting instructions.

If the above doesn't work, please report a bug, then add `LUCI_BYPASS_REAUTH=1` to the environment to disable ReAuth for now.

Bug: 442666611
Change-Id: I7724f15f166f9975fc88be5d8e1c93be4e1ec302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939308
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
2 months ago
bootstrap
fetch_configs [cleanup] Remove DevTools internal 4 months ago
hooks
infra Roll recipe dependencies (trivial). 2 months ago
infra_lib/telemetry mcp: Add some buildbucket tools and the mcp server 4 months ago
man [git_auth] Add useHttpPath config for Gerrit auth 3 months ago
mcp Fix docstrings and add support for arbitrary CL try-results 2 months ago
metadata Fix: Use f-string for validation warning message. 2 months ago
python-bin better error message from python3 when not initialized 6 months ago
python2-bin
recipes Roll recipe dependencies (trivial). 2 months ago
testing_support
tests git-cl: make SetReview ReAuth capable 2 months ago
third_party
win_toolchain Add dump_file_list flag to package_from_installed.py 4 months ago
zsh-goodies
.cipd_impl.ps1
.flake8
.git-blame-ignore-revs
.gitattributes Make cipd available in recipe bundle for dirmd 5 months ago
.gitignore
.isort.cfg
.style.yapf
.vpython3 Add sqlparse to .vpython3 3 months ago
BUILD_OWNERS
CROS_OWNERS
DIR_METADATA [DIR_METADATA] Migrate from Monorail to Buganizer. 2 months ago
LICENSE
LUCI_OWNERS
OWNERS Remove dpranke@google.com from OWNERS 3 months ago
PRESUBMIT.py Add presubmit checks for mcp/ 3 months ago
README.gclient.md
README.git-cl.md
README.google_cloud_storage.md
README.md explain build tools and depot_tools installations 6 months ago
RECLIENT_OWNERS
WATCHLISTS
android_build_server_helper.py android: Allow anonymous pipes for benchmarking 6 months ago
auth.py auth.py: add ReAuth support 2 months ago
autoninja
autoninja.bat
autoninja.py autoninja: support running from outside of workspace 2 months ago
bazel
bazel.py
bb
bb.bat
black
bootstrap_python3
breakpad.py
build_telemetry
build_telemetry.bat
build_telemetry.py
caffeinate.py autoninja: Do not show caffeinate warning 5 months ago
cbuildbot
cipd Add linux-loong64 platform support 4 months ago
cipd.bat fix cipd_impl.ps1 failure when depot_tools path contains whitespaces 4 months ago
cipd_bin_setup.bat
cipd_bin_setup.sh cipd: ignore .cipd_client_root 5 months ago
cipd_client_version
cipd_client_version.digests
cipd_manifest.txt Roll git-credential-luci to support ReAuth on webrtc host 2 months ago
cipd_manifest.versions Roll git-credential-luci to support ReAuth on webrtc host 2 months ago
cipd_manifest_cros_python2.txt
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py Fix clang-format to work when you're not in a chromium checkout. 2 months ago
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py [cpplint] add nolint region support 7 months ago
cpplint_chromium.py
create_temp_file.py depot_tools: add create_temp_file.py 3 months ago
cros
cros_python2.vpython
cros_sdk
detect_host_arch.py Add linux-loong64 platform support 4 months ago
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py
ensure_bootstrap
fetch
fetch.bat
fetch.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py Refactors the GCS dependency handling to unify the check for Cog 3 months ago
gclient_completion.sh
gclient_eval.py
gclient_paths.py autoninja: support running from outside of workspace 2 months ago
gclient_scm.py set verbose=False for mirror.populate in _UpdateMirrorIfNotContains() 7 months ago
gclient_utils.py Improve ensure_gsutil reliability 6 months ago
gerrit
gerrit_client.py Fix setbotcommit comment on ambiguous revision 4 months ago
gerrit_util.py git-cl: make SetReview ReAuth capable 2 months ago
git-cache
git-cl
git-credential-luci [git-credential-luci] Redirect to batch file on Windows 7 months ago
git-credential-luci.bat
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-squash-branch-tree
git-thaw
git-upstream-diff
git_auth.py [git_auth] Disable auto configure logic 3 months ago
git_cache.py git_cache: give 20 secs timeout to lockfile.Lock() in contains_revision 5 months ago
git_cl.py git-cl: make SetReview ReAuth capable 2 months ago
git_cl_completion.sh
git_common.py git_common: raise CalledProcessError with the given cwd, if set 7 months ago
git_completion.sh
git_dates.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_squash_branch_tree.py
git_upstream_diff.py
gn Reland "Reland "Use bundled python to run gn"" 6 months ago
gn.bat Reland "Reland "Use bundled python to run gn"" 6 months ago
gn.py Fix clang-format to work when you're not in a chromium checkout. 2 months ago
gn_helper.py
google-java-format
google-java-format.bat
google_java_format.py
gsutil.py Improve ensure_gsutil reliability 6 months ago
gsutil.py.bat
gsutil.vpython3
isort
led
led.bat
lockfile.py lockfile: release the lock before closing the file handler 6 months ago
luci-auth
luci-auth-fido2-plugin Add luci-auth-fido2-plugin 3 months ago
luci-auth-fido2-plugin.bat Add luci-auth-fido2-plugin 3 months ago
luci-auth-ssh-helper add luci-auth-ssh-* entrypoints 3 months ago
luci-auth-ssh-helper.bat add luci-auth-ssh-* entrypoints 3 months ago
luci-auth-ssh-plugin add luci-auth-ssh-* entrypoints 3 months ago
luci-auth-ssh-plugin.bat add luci-auth-ssh-* entrypoints 3 months ago
luci-auth.bat
luci_auth_fido2_plugin.py luci-auth-fido2-plugin: add a --list-devices flag for troubleshooting 3 months ago
lucicfg
lucicfg.bat
mac_toolchain
metrics-xml-format
metrics.README.md
metrics.py
metrics_utils.py
metrics_xml_format.py Pretty print dwa.xml when git cl format is used 4 months ago
my_activity.py
newauth.py [newauth] Enable by default (reland) (include bots) 7 months ago
ninja
ninja.bat
ninja.py ninja: fix TypeError: check_out_dir() missing 1 required positional argument 2 months ago
ninjalog_uploader.py Attach siso metadata to the metadata, if provided. 6 months ago
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py Reland "presubmit: update CheckPatchFormatted to pass --input_diff_file" 2 months ago
presubmit_diff.py
presubmit_support.py presubmit: use git diff -U0 for CheckPatchFormatted() 2 months ago
prpc
prpc.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint-2.17
pylint-2.17.bat
pylint-3.2
pylint-3.2.bat
pylint_main.py
pylintrc-2.6
pylintrc-2.7
pylintrc-2.17
pylintrc-3.2
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py
reclient_helper.py autoninja: Do not collect Reclient build metrics 4 months ago
reclientreport
reclientreport.bat
reclientreport.py
repo
repo_launcher repo: Update from upstream 3 months ago
roll-dep
roll-dep.bat
roll_dep.py Change to '--no-update-readme' in commit message 6 months ago
roll_downstream_gcs_deps.py
rustfmt.py
scm.py presubmit: use git diff -U0 for CheckPatchFormatted() 2 months ago
setup_color.py
siso
siso.bat
siso.py siso: add .sisorc support 2 months ago
split_cl.py git cl split: Use relative path for $description 6 months ago
subcommand.py subcommand: Add type annotations 6 months ago
subprocess2.py
swift-format
swift_format.py
update_depot_tools
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py
upload_to_google_storage_first_class.py
utils.py
vpython3
vpython3.bat
watchlists.py
whitespace.txt
win32imports.py
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Also, includes shell script/batch file for tools required to build chromium, e.g.

  • gn: a meta-build system that generates build files for Ninja
  • autoninja: a wrapper for siso and ninja.
  • siso: a build tool that aims to significantly speed up Chromium's build.
  • ninja: a small build system with a focus on speed. deprecated by Siso.

These shell script/batch file runs python script with python-bin/python3 that find binaries in chromium checkout, and run with proper setup/check. To use these wrappers, you need to initialize/bootstrap depot_tools (using gclient, update_depot_tools or ensure_bootstrap).

Installing

See set-up documentation.

depot_tools is also available in

These depot_tools would not be initialized/bootstrapped (i.e. no python-bin/python3 binary available), so the build tool wrapper won't work, unless it is explicitly initialized by ensure_bootstrap. Or, directly call the python script instead of using the shell script/batch file.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

Running gclient will install python3 binary.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.