aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '5254da1843'
${ noResults }
depot_tools/tests
History
Aaron Gable 5254da1843 Revert "Capture ctrl-c in presubmit multiprocessing pool" 
This reverts commit 873c28d175.

Reason for revert: Broken on Windows (crbug.com/762389)

Original change's description:
> Capture ctrl-c in presubmit multiprocessing pool
> 
> Presubmit spins up lots of multiprocessing processes to run
> each individual test. If you cancel your presubmit run with
> <ctrl>+c, that signal gets passed through to each of those,
> which then raises its own KeyboardInterrupt, and prints its
> own stacktrace.
> 
> This change has each member of the multiprocessing pool instead
> exit gracefully (albeit with an error code) so that only the
> parent process prints its stacktrace.
> 
> R=​michaelpg@chromium.org
> 
> Bug: 635196
> Change-Id: If9081910a359889a43bc1b72c91a859ebe37a1d6
> Reviewed-on: https://chromium-review.googlesource.com/651764
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Aaron Gable <agable@chromium.org>

TBR=iannucci@chromium.org,agable@chromium.org,michaelpg@chromium.org

Change-Id: Ib8e5b2f59b0060dfbfbeba348e211db292318b3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 635196
Reviewed-on: https://chromium-review.googlesource.com/653434
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
 		8 years ago
..
gstools
…
abandon.sh Remove SVN (and dcommit) support from git-cl 9 years ago
basic.sh Remove SVN (and dcommit) support from git-cl 9 years ago
bot_update_coverage_test.py Add cleanup dir, use with bot_update. 9 years ago
checkout_test.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
download_from_google_storage_unittests.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
fix_encoding_test.py
…
gclient_eval_unittest.py gclient flatten: preserve variable placeholders (reland #1) 8 years ago
gclient_scm_test.py Fix depot_tools test for git 2.11 9 years ago
gclient_smoketest.py gclient flatten: only print DEPS info referenced by recursedeps 8 years ago
gclient_test.py gclient flatten: fixes for --pin-all-deps 8 years ago
gclient_utils_test.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
git_cache_test.py
…
git_cl_creds_check_report.txt git cl creds-check: improve report and give better recommendation. 8 years ago
git_cl_test.py git cl creds-check: special case parsing of chromium.org emails. 8 years ago
git_common_test.py Make git blame test pass independently of core.abbrev setting 9 years ago
git_dates_test.py
…
git_drover_test.py git-drover: send mail and don't use WIP mode 8 years ago
git_footers_test.py git_footers: fix bug stdin-based message input. 8 years ago
git_hyper_blame_test.py GitHyperBlameMainTest.testBadFilename: Work around git-blame bug. 8 years ago
git_number_test.py
…
git_rebase_update_test.py
…
gsutil_test.py
…
hooks.sh Remove SVN (and dcommit) support from git-cl 9 years ago
owners.sh Remove SVN (and dcommit) support from git-cl 9 years ago
owners_finder_test.py Only attribute comments to owners that are close to the comment 9 years ago
owners_unittest.py owners: handle CLs which only have partial OWNERS 9 years ago
patch.sh Remove SVN (and dcommit) support from git-cl 9 years ago
patch_test.py
…
post-land-hook-test.sh Remove SVN (and dcommit) support from git-cl 9 years ago
presubmit_unittest.py Revert "Capture ctrl-c in presubmit multiprocessing pool" 8 years ago
push-from-logs.sh Remove SVN (and dcommit) support from git-cl 9 years ago
recipes_test.py Stop running deprecated simulation_test 9 years ago
rietveld_test.py Rietveld: fix search query. 9 years ago
save-description-on-failure.sh Remove SVN (and dcommit) support from git-cl 9 years ago
scm_unittest.py Correct Git show's path format on Windows 9 years ago
submit-from-new-dir.sh Remove SVN (and dcommit) support from git-cl 9 years ago
subprocess2_test.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
test-lib.sh Remove SVN (and dcommit) support from git-cl 9 years ago
upload-local-tracking-branch.sh Remove SVN (and dcommit) support from git-cl 9 years ago
upload-stale.sh Remove SVN (and dcommit) support from git-cl 9 years ago
upload_to_google_storage_unittests.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
watchlists_unittest.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago