The limit set in /Library/LaunchDaemons/limit.maxfiles.plist appears
to no longer be respected in macOS Ventura 13.5 and the OS forces a
limit of 256 file descriptors, causing build with autoninja to fail
on macOS running this most recent version of the OS.
Force the max number of process to 200 until a new working way to
increase the file descriptor limit is found. This will allow devs
working on macOS to be able to build (albeit slower than before).
Fixes the following build failure when goma is enabled and running
on macOS Ventura 13.5:
    $ autoninja -C out/Debug-iphonesimulator chrome
    ninja: Entering directory `out/Debug-iphonesimulator'
    [0/3574] CXX ....oninja: fatal: pipe: Too many open files
Bug: 1467777
Change-Id: Ia7eaab552f7e6d26a2f48d72bb8235a70d6d442f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4720227
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
						
					
				
			 | 
			2 years ago | |
|---|---|---|
| bootstrap | 3 years ago | |
| fetch_configs | 2 years ago | |
| git-templates | ||
| infra | 2 years ago | |
| man | 2 years ago | |
| python-bin | 3 years ago | |
| python2-bin | 3 years ago | |
| recipes | 2 years ago | |
| testing_support | 2 years ago | |
| tests | 2 years ago | |
| third_party | 2 years ago | |
| win_toolchain | 3 years ago | |
| zsh-goodies | ||
| .cipd_impl.ps1 | 2 years ago | |
| .gitattributes | 3 years ago | |
| .gitignore | 2 years ago | |
| .isort.cfg | 4 years ago | |
| .style.yapf | ||
| .vpython | 4 years ago | |
| .vpython3 | 2 years ago | |
| BUILD_OWNERS | 3 years ago | |
| CROS_OWNERS | 3 years ago | |
| DIR_METADATA | 5 years ago | |
| LICENSE | ||
| LUCI_OWNERS | 2 years ago | |
| OWNERS | 2 years ago | |
| PRESUBMIT.py | 2 years ago | |
| README.gclient.md | ||
| README.git-cl.md | ||
| README.md | 4 years ago | |
| RECLIENT_OWNERS | 3 years ago | |
| WATCHLISTS | 2 years ago | |
| auth.py | 5 years ago | |
| autoninja | 4 years ago | |
| autoninja.bat | 3 years ago | |
| autoninja.py | 2 years ago | |
| autosiso | 3 years ago | |
| autosiso.bat | 2 years ago | |
| autosiso.py | 2 years ago | |
| bb | 5 years ago | |
| bb.bat | 5 years ago | |
| black | 4 years ago | |
| bootstrap_python3 | 3 years ago | |
| breakpad.py | ||
| cbuildbot | ||
| cipd | 2 years ago | |
| cipd.bat | 3 years ago | |
| cipd_bin_setup.bat | 3 years ago | |
| cipd_bin_setup.sh | ||
| cipd_client_version | 2 years ago | |
| cipd_client_version.digests | 2 years ago | |
| cipd_manifest.txt | 2 years ago | |
| cipd_manifest.versions | 2 years ago | |
| cipd_manifest_cros_python2.txt | 3 years ago | |
| cipd_manifest_cros_python2.versions | 3 years ago | |
| clang-format | 4 years ago | |
| clang-format.bat | 4 years ago | |
| clang_format.py | 3 years ago | |
| clang_format_merge_driver | 4 years ago | |
| clang_format_merge_driver.bat | 4 years ago | |
| clang_format_merge_driver.py | 4 years ago | |
| codereview.settings | 5 years ago | |
| compile_single_file | 4 years ago | |
| compile_single_file.bat | 4 years ago | |
| compile_single_file.py | 3 years ago | |
| cpplint.bat | 3 years ago | |
| cpplint.py | 2 years ago | |
| cpplint_chromium.py | 3 years ago | |
| cros | 2 years ago | |
| cros_python2.vpython | 3 years ago | |
| cros_sdk | ||
| crosjobs | 5 years ago | |
| detect_host_arch.py | 2 years ago | |
| dirmd | 5 years ago | |
| dirmd.bat | 5 years ago | |
| download_from_google_storage | 5 years ago | |
| download_from_google_storage.bat | 3 years ago | |
| download_from_google_storage.py | 3 years ago | |
| ensure_bootstrap | 4 years ago | |
| fetch | 3 years ago | |
| fetch.bat | 3 years ago | |
| fetch.py | 3 years ago | |
| fix_encoding.py | 4 years ago | |
| gclient | 3 years ago | |
| gclient-new-workdir.py | 4 years ago | |
| gclient.bat | 3 years ago | |
| gclient.py | 2 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 2 years ago | |
| gclient_paths.py | 3 years ago | |
| gclient_scm.py | 2 years ago | |
| gclient_utils.py | 2 years ago | |
| gerrit | 3 years ago | |
| gerrit_client.py | 2 years ago | |
| gerrit_util.py | 2 years ago | |
| git-cache | ||
| git-cl | ||
| git-crrev-parse | 4 years ago | |
| git-drover | ||
| git-find-releases | ||
| git-footers | ||
| git-freeze | ||
| git-gs | 4 years ago | |
| git-hyper-blame | ||
| git-map | ||
| git-map-branches | ||
| git-mark-merge-base | ||
| git-migrate-default-branch | ||
| git-nav-downstream | ||
| git-nav-upstream | ||
| git-new-branch | ||
| git-number | ||
| git-rebase-update | ||
| git-rename-branch | ||
| git-reparent-branch | ||
| git-retry | ||
| git-runhooks | 4 years ago | |
| git-squash-branch | ||
| git-thaw | ||
| git-upstream-diff | ||
| git_cache.py | 3 years ago | |
| git_cl.py | 2 years ago | |
| git_cl_completion.sh | ||
| git_common.py | 2 years ago | |
| git_dates.py | ||
| git_drover.py | 4 years ago | |
| git_find_releases.py | 4 years ago | |
| git_footers.py | 4 years ago | |
| git_freezer.py | 2 years ago | |
| git_hyper_blame.py | 4 years ago | |
| git_map.py | 4 years ago | |
| git_map_branches.py | 2 years ago | |
| git_mark_merge_base.py | 4 years ago | |
| git_migrate_default_branch.py | 3 years ago | |
| git_nav_downstream.py | 4 years ago | |
| git_new_branch.py | 4 years ago | |
| git_number.py | 4 years ago | |
| git_rebase_update.py | 2 years ago | |
| git_rename_branch.py | 4 years ago | |
| git_reparent_branch.py | 2 years ago | |
| git_retry.py | 3 years ago | |
| git_squash_branch.py | 4 years ago | |
| git_upstream_diff.py | 4 years ago | |
| gn | 4 years ago | |
| gn.bat | 4 years ago | |
| gn.py | 4 years ago | |
| goma_auth | 4 years ago | |
| goma_auth.bat | 4 years ago | |
| goma_ctl | 3 years ago | |
| goma_ctl.bat | 3 years ago | |
| gsutil.py | 3 years ago | |
| gsutil.py.bat | 3 years ago | |
| gsutil.vpython3 | 4 years ago | |
| infra_to_superproject | 3 years ago | |
| infra_to_superproject.bat | 3 years ago | |
| infra_to_superproject.py | 3 years ago | |
| isort | 4 years ago | |
| led | 5 years ago | |
| led.bat | 5 years ago | |
| lockfile.py | ||
| luci-auth | 5 years ago | |
| luci-auth.bat | 5 years ago | |
| lucicfg | 5 years ago | |
| lucicfg.bat | 5 years ago | |
| mac_toolchain | ||
| metrics.README.md | ||
| metrics.py | 3 years ago | |
| metrics_utils.py | 2 years ago | |
| my_activity.py | 4 years ago | |
| ninja | 3 years ago | |
| ninja.bat | 3 years ago | |
| ninja.py | 3 years ago | |
| ninja_reclient.py | 2 years ago | |
| ninjalog.README.md | 4 years ago | |
| ninjalog_uploader.py | 3 years ago | |
| ninjalog_uploader_wrapper.py | 4 years ago | |
| owners_client.py | 2 years ago | |
| owners_finder.py | 4 years ago | |
| pinpoint | 5 years ago | |
| pinpoint.bat | 5 years ago | |
| post_build_ninja_summary.py | 3 years ago | |
| presubmit_canned_checks.py | 2 years ago | |
| presubmit_support.py | 2 years ago | |
| profile.xml | ||
| prpc | 5 years ago | |
| prpc.bat | 5 years ago | |
| pylint-2.6 | 3 years ago | |
| pylint-2.6.bat | 4 years ago | |
| pylint-2.7 | 3 years ago | |
| pylint-2.7.bat | 4 years ago | |
| pylint_main.py | 4 years ago | |
| pylintrc | ||
| python_runner.sh | 3 years ago | |
| rdb | 5 years ago | |
| rdb.bat | 5 years ago | |
| rdb_wrapper.py | 3 years ago | |
| reclient_helper.py | 2 years ago | |
| reclient_metrics.README.md | 2 years ago | |
| reclient_metrics.py | 2 years ago | |
| reclientreport | 3 years ago | |
| reclientreport.bat | 2 years ago | |
| reclientreport.py | 3 years ago | |
| repo | 2 years ago | |
| repo_launcher | 2 years ago | |
| roll-dep | 3 years ago | |
| roll-dep.bat | 3 years ago | |
| roll_dep.py | 3 years ago | |
| rustfmt.py | 3 years ago | |
| scm.py | 3 years ago | |
| setup_color.py | 4 years ago | |
| siso | 3 years ago | |
| siso.bat | 3 years ago | |
| siso.py | 2 years ago | |
| split_cl.py | 2 years ago | |
| subcommand.py | 3 years ago | |
| subprocess2.py | 5 years ago | |
| swift-format | 4 years ago | |
| swift_format.py | 4 years ago | |
| update_depot_tools | 3 years ago | |
| update_depot_tools.bat | 3 years ago | |
| update_depot_tools_toggle.py | 4 years ago | |
| upload_metrics.py | 3 years ago | |
| upload_to_google_storage.py | 3 years ago | |
| utils.py | 3 years ago | |
| vpython | 3 years ago | |
| vpython.bat | 3 years ago | |
| vpython3 | 3 years ago | |
| vpython3.bat | 3 years ago | |
| watchlists.py | 4 years ago | |
| weekly | 4 years ago | |
| whitespace.txt | 5 years ago | |
| win32imports.py | ||
| wtf | 4 years ago | |
| yapf | 3 years ago | |
| yapf.bat | 5 years ago | |
		
			
				
				README.md
			
		
		
			
			
		
	
	depot_tools
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.