You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Raul Tambre 43271f94de fetch: Decode gclient output if returning stdout
In Python 3 the output of a subprocess is bytes, so they need to be decoded to be used as a string.

This previously caused the following error if there was an existing checkout during a fetch:
Traceback (most recent call last):
  File "C:\Google\depot_tools\\fetch.py", line 318, in <module>
    sys.exit(main())
  File "C:\Google\depot_tools\\fetch.py", line 313, in main
    return run(options, spec, root)
  File "C:\Google\depot_tools\\fetch.py", line 299, in run
    if not options.force and checkout.exists():
  File "C:\Google\depot_tools\\fetch.py", line 98, in exists
    return (os.path.exists(os.path.join(gclient_root, b'.gclient')) or
  File "C:\Program Files\Python38\lib\ntpath.py", line 109, in join
    genericpath._check_arg_types('join', path, *paths)
  File "C:\Program Files\Python38\lib\genericpath.py", line 151, in _check_arg_types
    raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components

Bug: 939847
Change-Id: Ibf5b4923268595ba439586d688894f92696ecbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701403
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
7 years ago
bootstrap/win [bootstrap/win] Release Python 2.7.15 7 years ago
fetch_configs Invert ios_internal fetch spec. 7 years ago
git-templates
infra Roll recipe dependencies (trivial). 7 years ago
man
recipes Add failure status on timeouts 7 years ago
support
testing_support
tests git-cl: add --preserve-tryjobs option for upload command. 7 years ago
third_party depot_tools: Remove unused third_party libraries. 7 years ago
win_toolchain Convert print statements to Python 3 style 7 years ago
zsh-goodies
.gitattributes
.gitignore
.style.yapf
CROS_OWNERS
LICENSE
OWNERS
PRESUBMIT.py
README.gclient.md
README.git-cl.md
README.md
README.testing
WATCHLISTS
annotated_gclient.py
appengine_mapper.py
auth.py
autoninja [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 7 years ago
autoninja.bat [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 7 years ago
autoninja.py Update autoninja's psutil from v5.2.2 to v5.6.2 7 years ago
bb
bb.bat
breakpad.py
buildbucket.py
cbuildbot
checkout.py
chrome_set_ver
cipd
cipd.bat
cipd.ps1
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version [cipd] Update CIPD client to v2.2.19. 7 years ago
cipd_client_version.digests [cipd] Update CIPD client to v2.2.19. 7 years ago
cipd_manifest.txt [lucicfg] Update to the latest version. 7 years ago
cipd_manifest.versions [lucicfg] Update to the latest version. 7 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py
cpplint_chromium.py
cros
cros_sdk
dart_format.py
depot-tools-auth
depot-tools-auth.bat
depot-tools-auth.py
detect_host_arch.py
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py Show nice error on failure to enumerage input files. 7 years ago
ensure_bootstrap
fetch
fetch.bat
fetch.py fetch: Decode gclient output if returning stdout 7 years ago
fix_encoding.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py
gclient_utils.py
gerrit_client.py
gerrit_util.py
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py
git_cl.py git-cl: add --preserve-tryjobs option for upload command. 7 years ago
git_cl_completion.sh
git_common.py
git_dates.py
git_drover.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
gsutil.py
gsutil.py.bat
gsutil.vpython
led
led.bat
luci-auth
luci-auth.bat
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 7 years ago
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py
metrics_utils.py
my_activity.py Make it clear in the help message that my_activity.py dates are mm/dd/yy 7 years ago
my_reviews.py
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md
ninjalog_uploader.py
ninjalog_uploader_wrapper.py
owners.py
owners_finder.py
patch.py
post_build_ninja_summary.py
presubmit_canned_checks.py
presubmit_support.py Make sure PresubmitResult can be converted to a json. 7 years ago
profile.xml
prpc
prpc.bat
pylint
pylint.py
pylintrc
python_runner.sh
repo
rietveld.py
roll-dep
roll-dep-svn
roll-dep-svn.bat
roll-dep.bat
roll_dep.py
roll_dep_svn.py
scm.py
setup_color.py setup_color: Don't fill created string buffer with nulls 7 years ago
split_cl.py
subcommand.py
subprocess2.py
update_depot_tools
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py
vpython
vpython.bat
watchlists.py
weekly
wtf
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.