You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Andreas Haas 417d89c32f Revert "Enable Javascript formatting by default"
This reverts commit 42a51f6af1.

Reason for revert: With this change also JavaScript code in the
V8 code base gets formatted. However, clang-format cannot deal with
V8 intrinsics, and therefore inserts a space between the `%` and the
intrinsics name. With that Clusterfuzz cannot detect intrinsics
anymore, and therefore the blacklisting of intrinsics would not
work anymore. The result is that Clusterfuzz then produces useless
test cases that are known to crash and could not exist in the wild.

Original change's description:
> Enable Javascript formatting by default
> 
> This removes the need for explicitly passing `--js` to `git cl format`
> to format both JavaScript and TypeScript. It would reduce a significant
> amount of mental overhead for formatting code in DevTools frontend,
> which is primarily JS/TS.
> 
> Fixed: 1007347
> Change-Id: Ia35c9af677d12ce9be72fe5fcdd6ceb6cb039c5f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029371
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I13e8ce8916f0685b667607f2c8e68b1185d43329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2041650
Reviewed-by: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
5 years ago
bootstrap Roll python to actually correct packages. 5 years ago
fetch_configs Add fetch configs for devtools-frontend 6 years ago
git-templates
infra Roll recipe dependencies (trivial). 5 years ago
man Default to origin's default branch instead of always origin/master. 5 years ago
python-bin depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
recipes tryserver: delete failure_hash support. 5 years ago
testing_support git-map: Refactor and add simple tests 5 years ago
tests Revert "presubmit_support: Add --all-files options." 5 years ago
third_party Improve git cl split 5 years ago
win_toolchain Also set LIBPATH in Windows toolchain environment 5 years ago
zsh-goodies
.gitattributes git-cl: Run using vpython 6 years ago
.gitignore depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
.style.yapf Update "git cl format --python" to default to PEP-8 5 years ago
.vpython depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 5 years ago
.vpython3 Reland "gerrit_util: Refactor ReadHttpResponse and add more tests." 6 years ago
CROS_OWNERS CROS_OWNERS: update 6 years ago
GOMA_OWNERS OWNERS: add the Goma client release rotation to cipd_manifest.* 5 years ago
LICENSE
OWNERS OWNERS: add the Goma client release rotation to cipd_manifest.* 5 years ago
PRESUBMIT.py git-map: Refactor and add simple tests 5 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md README.git-cl.md: Remove reference to Rietveld 6 years ago
README.md Update depot_tools README cpplint section 6 years ago
WATCHLISTS depot_tools: Add ehmaldonado to WATCHLISTS. 6 years ago
auth.py auth: Fix has_luci_context_local_auth. 6 years ago
autoninja Fix a python invocation that wasn't replaced with vpython. 5 years ago
autoninja.bat Run autoninja scripts using vpython. 5 years ago
autoninja.py Handle GOMA_DISABLED more precisely 6 years ago
bb do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
bb.bat [bb] Deploy bb 6 years ago
bootstrap_python3 Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
breakpad.py Finally get rid of depot_tools' breakpad. 9 years ago
cbuildbot simplify the chromite wrappers 6 years ago
chrome_set_ver simplify the chromite wrappers 6 years ago
cipd do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
cipd.bat [cipd] Check CIPD client hash during updates on Windows. 7 years ago
cipd.ps1 [cipd] More careful error handling during CIPD bootstrap on Windows. 7 years ago
cipd_bin_setup.bat Revert "put goma client in depot_tools" 6 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version [cipd] Update client v2.3.4 => v2.3.5. 5 years ago
cipd_client_version.digests [cipd] Update client v2.3.4 => v2.3.5. 5 years ago
cipd_manifest.txt roll out new goma client binary (VERSION=189) 5 years ago
cipd_manifest.versions roll out new goma client binary (VERSION=189) 5 years ago
cit Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.bat Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
clang-format
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Convert print statements to Python 3 style 6 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Convert except statements to be Python 3 compatible 6 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Make it clear that compile_single_file.py doesn't support Jumbo builds 6 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py cpplint: use list() for working with python3 5 years ago
cpplint_chromium.py
cros simplify the chromite wrappers 6 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add crosjobs shim script 6 years ago
dart_format.py Convert except statements to be Python 3 compatible 6 years ago
detect_host_arch.py depot_tools: Add tests for detect_host_arch. 5 years ago
download_from_google_storage Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.py Fix the --quiet flag of download_from_google_storage.py 5 years ago
ensure_bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch [fetch] use py3 for fetch 6 years ago
fetch.bat fetch: Fix GCLIENT_PY3 on Windows 6 years ago
fetch.py Reland "depot_tools: Use vpython to execute fetch." 6 years ago
fix_encoding.py gclient: Make smoketests run on Windows. 5 years ago
gclient gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient-new-workdir.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
gclient.bat gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient.py gclient: Make smoketests run on Windows. 5 years ago
gclient_completion.sh
gclient_eval.py python3 improvements 6 years ago
gclient_paths.py depot_tools: Add tests for gclient_paths 5 years ago
gclient_scm.py gclient: Make smoketests run on Windows. 5 years ago
gclient_utils.py depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 5 years ago
gerrit_client.py [git-cl] Lint and clean-up git-cl, test, and related modules 6 years ago
gerrit_util.py git-cl: Make tests run on Python 3. 6 years ago
git-cache Generalize python_git_runner for use in non-git scripts. 10 years ago
git-cl Generalize python_git_runner for use in non-git scripts. 10 years ago
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-drover Generalize python_git_runner for use in non-git scripts. 10 years ago
git-find-releases Generalize python_git_runner for use in non-git scripts. 10 years ago
git-footers Generalize python_git_runner for use in non-git scripts. 10 years ago
git-freeze Generalize python_git_runner for use in non-git scripts. 10 years ago
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git-map git-map: Refactor and add simple tests 5 years ago
git-map-branches Generalize python_git_runner for use in non-git scripts. 10 years ago
git-mark-merge-base Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-downstream Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-number Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rebase-update Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rename-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-reparent-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-retry Generalize python_git_runner for use in non-git scripts. 10 years ago
git-runhooks Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git-squash-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-thaw Generalize python_git_runner for use in non-git scripts. 10 years ago
git-upstream-diff Generalize python_git_runner for use in non-git scripts. 10 years ago
git_cache.py Revert "[bot_update] Also bootstrap in the case that there are 0 pack files" 5 years ago
git_cl.py Revert "Enable Javascript formatting by default" 5 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py git-map: Refactor and add simple tests 5 years ago
git_dates.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover.py Update git-drover to use branch CQ 5 years ago
git_find_releases.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_footers.py presubmit_support: Support getting and adding footers. 5 years ago
git_freezer.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_hyper_blame.py git-hyper-blame: Simplify code and tests. 5 years ago
git_map.py git-map: Refactor and add simple tests 5 years ago
git_map_branches.py python3 improvements 6 years ago
git_mark_merge_base.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_nav_downstream.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_new_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_number.py git-number: Make tests run on Python 3. 6 years ago
git_rebase_update.py python3 improvements 6 years ago
git_rename_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_reparent_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_retry.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_squash_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_upstream_diff.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
gn
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py Convert print statements to Python 3 style 6 years ago
goma_auth Reland "put goma client in depot_tools" 6 years ago
goma_auth.bat Reland "put goma client in depot_tools" 6 years ago
goma_ctl [goma_ctl] Use vpython to call goma_ctl.py. 5 years ago
goma_ctl.bat [goma_ctl] Use vpython to call goma_ctl.py. 5 years ago
gsutil.py depot_tools: Make gsutil compatible with python3. 5 years ago
gsutil.py.bat Add windows .bat file for gsutil.py. 6 years ago
gsutil.vpython gsutil.vpython: Set vpython_version: 2.7 5 years ago
led do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
luci-auth do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
luci-auth.bat [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
lucicfg.bat [cipd] Add lucicfg tool. 6 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md metrics: Update documentation 5 years ago
metrics.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
metrics_utils.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
my_activity.py my_activity: Make compatible with Python 3. 5 years ago
ninja properly detect msys_nt as windows in the ninja script 5 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
ninjalog.README.md [ninjalog] add ninjalog.README.md 6 years ago
ninjalog_uploader.py Run autoninja scripts using vpython. 5 years ago
ninjalog_uploader_wrapper.py Run autoninja scripts using vpython. 5 years ago
owners.py Randomize results of git cl owners 6 years ago
owners_finder.py Randomize results of git cl owners 6 years ago
post_build_ninja_summary.py Run autoninja scripts using vpython. 5 years ago
presubmit_canned_checks.py Reland "presubmit_canned_checks: Run pylint on parent directory for depot_tools." 5 years ago
presubmit_support.py Revert "presubmit_support: Add --all-files options." 5 years ago
profile.xml
prpc do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
prpc.bat [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
pylint pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.5 pylint: make pylint-quotes available 5 years ago
pylint-1.6 pylint: make pylint-quotes available 5 years ago
pylint-1.7 pylint: make pylint-quotes available 5 years ago
pylint-1.8 pylint: make pylint-quotes available 5 years ago
pylint-1.9 pylint: make pylint-quotes available 5 years ago
pylint.bat pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint_main.py pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylintrc pylint: make pylint-quotes available 5 years ago
python_runner.sh export PYTHONDONTWRITEBYTECODE instead of just defining constant 5 years ago
repo Reland "repo: pull in updates from latest release" 6 years ago
roll-dep Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll_dep.py [roll] Fix the command in the commit message 5 years ago
scm.py scm: Add GetAllFiles method. 5 years ago
setup_color.py setup_color: Don't output an error if GetConsoleMode fails 6 years ago
split_cl.py Improve git cl split 5 years ago
subcommand.py subcommand: Add tests. 5 years ago
subprocess2.py subprocess2: Ensure environment keys and values are strings on Python 3 5 years ago
update_depot_tools Escape forward slash to avoid undesired path conversion in Git 2.24.1(2). 5 years ago
update_depot_tools.bat Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_metrics.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
upload_to_google_storage.py gsutil: Decode output from subprocess. 6 years ago
vpython depot_tools: Use system's python for vpython. 6 years ago
vpython.bat Reland "vpython: Specify interpreter to run." 5 years ago
vpython3 vpython3: Fix path to python 3 5 years ago
vpython3.bat Reland "vpython: Specify interpreter to run." 5 years ago
watchlists.py depot_tools: Run watchlists tests on Python 3 6 years ago
weekly Convert print statements to Python 3 style 6 years ago
wtf Convert print statements to Python 3 style 6 years ago
yapf Update yapf version 0.22 -> 0.24 7 years ago
yapf.bat Fix git cl format --python on windows 7 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.