You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson 37740e2bc9 Randomize results of git cl owners
git cl owners orders owners by score with alphabetization being the tie
breaker. This leads to some owners being suggested far more often than
others.

Adding a tiny amount of randomization to the scoring leads to an even
distribution of equally qualified reviewers. Less qualified reviewers
will still be sorted into distinct buckets - the randomness is too small
to do anything except break ties.

The tests were updated so that they can tolerate the randomness, but
only for breaking ties.

Bug: 1024083
Change-Id: If7d39d1b3bbd980b80b46ab3f62c65215309bdc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913642
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
bootstrap depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
fetch_configs Add fetch configs for devtools-frontend 6 years ago
git-templates Explicitly exec hooks inside a shell. 12 years ago
infra Roll recipe dependencies (trivial). 6 years ago
man python3 improvements 6 years ago
python-bin depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
recipes Roll recipe dependencies (trivial). 6 years ago
testing_support depot_tools: Make owners tests run on Python 3 6 years ago
tests Randomize results of git cl owners 6 years ago
third_party depot_tools: Remove oauth2client. 6 years ago
win_toolchain python3 improvements 6 years ago
zsh-goodies Remove unmaintained "gclient export" command, 14 years ago
.gitattributes git-cl: Run using vpython 6 years ago
.gitignore depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
.style.yapf Add experimental support for python in 'git cl format' 10 years ago
.vpython depot_tools: Include httplib2 using vpython. 6 years ago
.vpython3 Reland "gerrit_util: Refactor ReadHttpResponse and add more tests." 6 years ago
CROS_OWNERS CROS_OWNERS: update 6 years ago
LICENSE Create the Next Generation of depot_tools. Eh. 16 years ago
OWNERS Add a COMPONENT entry to the OWNERS file. 6 years ago
PRESUBMIT.py gsutil: Decode output from subprocess. 6 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md README.git-cl.md: Remove reference to Rietveld 6 years ago
README.md Update depot_tools README cpplint section 6 years ago
WATCHLISTS depot_tools: Add ehmaldonado to WATCHLISTS. 6 years ago
annotated_gclient.py python3 improvements 6 years ago
auth.py auth: Fix has_luci_context_local_auth. 6 years ago
autoninja python3 improvements 6 years ago
autoninja.bat [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 6 years ago
autoninja.py Handle GOMA_DISABLED more precisely 6 years ago
bb do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
bb.bat [bb] Deploy bb 6 years ago
bootstrap_python3 Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
breakpad.py Finally get rid of depot_tools' breakpad. 9 years ago
cbuildbot simplify the chromite wrappers 6 years ago
chrome_set_ver simplify the chromite wrappers 6 years ago
cipd do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
cipd.bat [cipd] Check CIPD client hash during updates on Windows. 7 years ago
cipd.ps1 [cipd] More careful error handling during CIPD bootstrap on Windows. 7 years ago
cipd_bin_setup.bat Revert "put goma client in depot_tools" 6 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version cipd: update to 2a121dde. 6 years ago
cipd_client_version.digests cipd: update to 2a121dde. 6 years ago
cipd_manifest.txt [lucicfg] Update from v1.11.5 to v1.11.6. 6 years ago
cipd_manifest.versions [lucicfg] Update from v1.11.5 to v1.11.6. 6 years ago
cit Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.bat Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
clang-format Depot tools: use the clang-format binaries that are now included 11 years ago
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Convert print statements to Python 3 style 6 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Convert except statements to be Python 3 compatible 6 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Make it clear that compile_single_file.py doesn't support Jumbo builds 6 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py [tricium] Add string_view to list of C++ headers 6 years ago
cpplint_chromium.py Add lint check against "Foo *bar" and "Foo &bar" declarations. 14 years ago
cros simplify the chromite wrappers 6 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add crosjobs shim script 6 years ago
dart_format.py Convert except statements to be Python 3 compatible 6 years ago
detect_host_arch.py Improve gclient Python 3 compatibility 6 years ago
download_from_google_storage Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.py gsutil: Decode output from subprocess. 6 years ago
ensure_bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch [fetch] use py3 for fetch 6 years ago
fetch.bat fetch: Fix GCLIENT_PY3 on Windows 6 years ago
fetch.py Reland "depot_tools: Use vpython to execute fetch." 6 years ago
fix_encoding.py fix_encoding: Decode bytestrings on Python 3 6 years ago
gclient gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient-new-workdir.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
gclient.bat gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient.py python3 improvements 6 years ago
gclient_completion.sh Added basic completion (the commands) for gclient. 11 years ago
gclient_eval.py python3 improvements 6 years ago
gclient_paths.py Import gclient_utils for gclient_paths CheckCallAndFilter 6 years ago
gclient_scm.py Use git fetch --no-tags to fetch commits to apply via cherry-pick. 6 years ago
gclient_utils.py gclient_utils: Make FileRead always return a Unicode string. 6 years ago
gerrit_client.py [git-cl] Lint and clean-up git-cl, test, and related modules 6 years ago
gerrit_util.py git-cl: Make tests run on Python 3. 6 years ago
git-cache Generalize python_git_runner for use in non-git scripts. 10 years ago
git-cl Generalize python_git_runner for use in non-git scripts. 10 years ago
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-drover Generalize python_git_runner for use in non-git scripts. 10 years ago
git-find-releases Generalize python_git_runner for use in non-git scripts. 10 years ago
git-footers Generalize python_git_runner for use in non-git scripts. 10 years ago
git-freeze Generalize python_git_runner for use in non-git scripts. 10 years ago
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git-map Generalize python_git_runner for use in non-git scripts. 10 years ago
git-map-branches Generalize python_git_runner for use in non-git scripts. 10 years ago
git-mark-merge-base Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-downstream Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-number Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rebase-update Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rename-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-reparent-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-retry Generalize python_git_runner for use in non-git scripts. 10 years ago
git-runhooks Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git-squash-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-thaw Generalize python_git_runner for use in non-git scripts. 10 years ago
git-upstream-diff Generalize python_git_runner for use in non-git scripts. 10 years ago
git_cache.py Allow the bot_update api to not fetch tags from the git server. 6 years ago
git_cl.py git-cl: Make tests run on Python 3. 6 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py git-common: Explicitly specify utf-8 when encoding. 6 years ago
git_dates.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover.py git-drover: Fix tests to run on Python 3. 6 years ago
git_find_releases.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_footers.py depot_tools: Run git_footers_test on Python 3. 6 years ago
git_freezer.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_hyper_blame.py depot_tools: Run git_common_test in Python 3 6 years ago
git_map.py python3 improvements 6 years ago
git_map_branches.py python3 improvements 6 years ago
git_mark_merge_base.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_nav_downstream.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_new_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_number.py git-number: Make tests run on Python 3. 6 years ago
git_rebase_update.py python3 improvements 6 years ago
git_rename_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_reparent_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_retry.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_squash_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_upstream_diff.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
gn Add executable and line ending properties for GN. 12 years ago
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py Convert print statements to Python 3 style 6 years ago
goma_auth Reland "put goma client in depot_tools" 6 years ago
goma_auth.bat Reland "put goma client in depot_tools" 6 years ago
goma_ctl Reland "put goma client in depot_tools" 6 years ago
goma_ctl.bat Reland "put goma client in depot_tools" 6 years ago
gsutil.py gsutil: Decode output from subprocess. 6 years ago
gsutil.py.bat Add windows .bat file for gsutil.py. 6 years ago
gsutil.vpython gsutil: Bump asn1crypto version to 1.0.1 6 years ago
led do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
luci-auth do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
luci-auth.bat [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
lucicfg.bat [cipd] Add lucicfg tool. 6 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md metrics: Collect full timestamps. 6 years ago
metrics.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
metrics_utils.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
my_activity.py depot_tools: Include httplib2 using vpython. 6 years ago
ninja [ninja] update ninja repository url 6 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
ninjalog.README.md [ninjalog] add ninjalog.README.md 6 years ago
ninjalog_uploader.py Remove unused imports in depot_tools/*.py 6 years ago
ninjalog_uploader_wrapper.py Convert print statements to Python 3 style 6 years ago
owners.py Randomize results of git cl owners 6 years ago
owners_finder.py Randomize results of git cl owners 6 years ago
post_build_ninja_summary.py Change "CPU time" to "elapsed time" 6 years ago
presubmit_canned_checks.py presubmit_support: Fix tests on Python 3. 6 years ago
presubmit_support.py presubmit_support: Fix tests on Python 3. 6 years ago
profile.xml Create the Next Generation of depot_tools. Eh. 16 years ago
prpc do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
prpc.bat [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
pylint pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.5 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.6 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.7 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.8 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.9 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint.bat pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint_main.py pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylintrc pylintrc: disable score reports 6 years ago
python_runner.sh git-cl: Run using vpython 6 years ago
repo Reland "repo: pull in updates from latest release" 6 years ago
roll-dep Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep-svn Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep-svn.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll_dep.py python3 improvements 6 years ago
roll_dep_svn.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
scm.py depot_tools: Don't use basestring in scm.CaptureStatus. 6 years ago
setup_color.py setup_color: Don't output an error if GetConsoleMode fails 6 years ago
split_cl.py python3 improvements 6 years ago
subcommand.py depot_toools: Make subcommand Python 3 compatible. 6 years ago
subprocess2.py depot_tools: Simplify subprocess2. 6 years ago
update_depot_tools depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
update_depot_tools.bat Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_metrics.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
upload_to_google_storage.py gsutil: Decode output from subprocess. 6 years ago
vpython depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
vpython.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
vpython3 depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
vpython3.bat [vpython] Roll to 98a268c6432f18aedd55d62b9621765316dc2a16 6 years ago
watchlists.py Trivial: Removing gendered pronouns from watchlists.py. 6 years ago
weekly Convert print statements to Python 3 style 6 years ago
wtf Convert print statements to Python 3 style 6 years ago
yapf Update yapf version 0.22 -> 0.24 7 years ago
yapf.bat Fix git cl format --python on windows 7 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.