You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
aa5ced1815
This adds pluggable codereview-specific implementations into Changelist class. The specific implementation is chosen at Changelist automatically, with Rietveld being default for backwards compatibility. Gerrit implementation for Gerrit is incomplete, and will be added in later CLs. However, it is sufficient to ensure current functionality of this tool is not diminished. Sadly, the base class isn't completely free from Rietveld assumptions because of presubmit_support. Apparently, PRESUBMIT scripts can make use of Rietveld instance for RPCs directly. This use doesn't make sense for Gerrit, which substitutes rietveld instance with a dummy object, which raises exception on any attribute access with a diagnostic message. This also includes refactoring of some related code which (ab)used ChangeList. Overall, this CL adds a few extra call to git config in order to determine which codereview to use, but but it shouldn't have any performance impact. These is a reland of these 4 CLs + with several fixes. patch from issue 1827523003 at patchset 20001 (http://crrev.com/1827523003#ps20001) patch from issue 1830703004 at patchset 1 (http://crrev.com/1830703004#ps1) patch from issue 1830923002 at patchset 60001 (http://crrev.com/1830923002#ps60001) patch from issue 1805193002 at patchset 380001 (http://crrev.com/1805193002#ps380001) This CL without a fix was also committed and reverted as patch from issue 1830973003 at patchset 40001 (http://crrev.com/1830973003#ps40001) R=machenbach@chromium.org,sergiyb@chromium.org,andybons@chromium.org BUG=579160,597638 Review URL: https://codereview.chromium.org/1838143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299530 0039d316-1c4b-4281-b951-d872f2087c98 |
9 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| subversion_config | ||
| abandon.sh | ||
| basic.sh | ||
| checkout_test.py | ||
| download_from_google_storage_unittests.py | ||
| fix_encoding_test.py | ||
| gclient_scm_test.py | ||
| gclient_smoketest.py | ||
| gclient_test.py | ||
| gclient_utils_test.py | ||
| git_cache_test.py | ||
| git_cl_test.py | 9 years ago | |
| git_common_test.py | ||
| git_dates_test.py | ||
| git_drover_test.py | ||
| git_footers_test.py | 9 years ago | |
| git_hyper_blame_test.py | ||
| git_number_test.py | ||
| git_rebase_update_test.py | ||
| gsutil_test.py | ||
| hooks.sh | ||
| owners.sh | ||
| owners_finder_test.py | ||
| owners_unittest.py | ||
| patch.sh | ||
| patch_test.py | ||
| post-dcommit-hook-test.sh | ||
| presubmit_unittest.py | ||
| push-basic.sh | ||
| push-from-logs.sh | ||
| recipes_test.py | ||
| rename.sh | ||
| rietveld_test.py | ||
| sample_pre_commit_hook | ||
| save-description-on-failure.sh | ||
| scm_unittest.py | ||
| submit-from-new-dir.sh | ||
| submodule-merge-test.sh | ||
| subprocess2_test.py | ||
| test-lib.sh | ||
| trychange_unittest.py | ||
| upload-local-tracking-branch.sh | ||
| upload-stale.sh | ||
| upload_to_google_storage_unittests.py | ||
| upstream.sh | ||
| watchlists_unittest.py | ||