You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Suppose the final paragraph of a commit message looks like this: """ And here's the final paragraph. Bug: 1234 TBR=soandso Change-Id: deadbeef """ In this case, we don't want to lose the Bug and Change-Id footers, so we process the whole final paragraph. *But* we'd also like to help the user get things formatted correctly. This change lets git_footers notice this situation, and insert a newline before the first well-formed footer (Bug: in this case), so that the set of well- and mal-formed footers are separated from the rest of the malformed body text. In the rare case where the last line of the last non-trailer paragraph is a url, this will also visibly push the url into the block of trailers (where it doesn't belong), prompting the user to fix it. A more comprehensive fix for that particular case is coming later. Bug: 766234 Change-Id: I6ae0072fff68ddf06e6f43b70f9a82a7f247f4ab Reviewed-on: https://chromium-review.googlesource.com/849481 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> |
8 years ago | |
---|---|---|
.. | ||
gstools | 12 years ago | |
auth_test.py | 8 years ago | |
bot_update_coverage_test.py | 8 years ago | |
checkout_test.py | 8 years ago | |
download_from_google_storage_unittest.py | 8 years ago | |
fix_encoding_test.py | 14 years ago | |
gclient_eval_unittest.py | 8 years ago | |
gclient_scm_test.py | 8 years ago | |
gclient_smoketest.py | 8 years ago | |
gclient_test.py | 8 years ago | |
gclient_utils_test.py | 8 years ago | |
git_cache_test.py | 10 years ago | |
git_cl_creds_check_report.txt | 8 years ago | |
git_cl_test.py | 8 years ago | |
git_common_test.py | 8 years ago | |
git_dates_test.py | 9 years ago | |
git_drover_test.py | 8 years ago | |
git_footers_test.py | 8 years ago | |
git_hyper_blame_test.py | 8 years ago | |
git_number_test.py | 10 years ago | |
git_rebase_update_test.py | 10 years ago | |
gsutil_test.py | 8 years ago | |
owners_finder_test.py | 8 years ago | |
owners_unittest.py | 8 years ago | |
patch_test.py | 13 years ago | |
presubmit_unittest.py | 8 years ago | |
recipes_test.py | 8 years ago | |
scm_unittest.py | 8 years ago | |
subprocess2_test.py | 9 years ago | |
upload_to_google_storage_unittest.py | 8 years ago | |
watchlists_unittest.py | 9 years ago |