You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Junji Watanabe 3133f98f3f Retry switching to use CIPD ninja v1.8.2
This reverts commit 0a5bae7ebc + some modifications on recipe module.

The previous CL https://crrev.com/c/3697958 ensures depot_tools/.cipd_bin in recipe environments. This CL copies ninja.exe from .cipd_bin to depot_tools root as cipd_bin_setup.bat.
For developers, it's expected to run update_depot_tools which triggers cipd_bin_setup.
For CI/CQ, depot_tools._cipd_bin_setup() should be called before using ninja/autoninja recipe module APIs.

Builds with depot_tools recipe bundle are tested using led.

# Windows
> led get-build 8811491780369249585 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch
https://ci.chromium.org/swarming/task/5b7512ee9d91fc10?

# Linux
> led get-build 8811504372914233697 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch
https://ci.chromium.org/swarming/task/5b7515832d0f7c10

Original change's description:
> Revert "Switch to use CIPD ninja v1.8.2"
>
> This reverts commit c90a982106.
>
> Reason for revert:
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8811949917908303825/+/u/compile/stdout
>
> Original change's description:
> > Switch to use CIPD ninja v1.8.2
> >
> > https://crrev.com/c/3674981 installed CIPD ninja packages.
> > This CL switches from the old ninja binaries to them.
> >
> > Note that this CL doesn't change ninja version. the old/CIPD ninja binaries are v1.8.2.
> >
> > The differences from the old binaries are
> > - the CIPD packages don't use chromium's clang.
> > - the CIPD package for Linux doesn't use chromium's sysroot.
> > - the min macOS version is 10.13, which was 10.6.
> > Please also see https://crsrc.org/i/3pp/ninja/install_bootstrap.sh
> >
> >
> > On Windows, ninja.exe will be installed under .cipd_bin.
> > But there are many places that assume that ninja.exe exists on depot_tools root. So this CL also copies the ninja.exe from .cipd_bin to root in cipd_bin_setup.bat.
> >
> > Bug: 931218
> > Change-Id: Ib67eee5e9b6ad9b2937b789626970d9c85867dbd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674982
> > Commit-Queue: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Philipp Wollermann <philwo@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
>
> Bug: 931218
> Change-Id: I08d61dad119a0d23ae9ec8b1ed787dd3915de697
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686854
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Owners-Override: Takuto Ikuta <tikuta@chromium.org>

Bug: 931218
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: infra
Change-Id: Ic7a9395c0e858823375f1a6ec79034dbc54230bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696963
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
3 years ago
bootstrap git 2.35.1.chromium.8 to depot_tools stable. 3 years ago
fetch_configs [depot_tools] Remove references to adobe flash from fetch flow 3 years ago
git-templates
infra Roll recipe dependencies (trivial). 3 years ago
man [docs] Fix alias settings 4 years ago
python-bin Add python batch wrappers 4 years ago
python2-bin Add python batch wrappers 4 years ago
recipes Retry switching to use CIPD ninja v1.8.2 3 years ago
testing_support Explicitly run everything with python3 3 years ago
tests Remove duplicate sparse-checkout call. 3 years ago
third_party Remove unused third_party coverage library 3 years ago
win_toolchain Use python3 for cpplint and get_toolchain on Win 3 years ago
zsh-goodies
.cipd_impl.ps1 Try removing windows-386 from cipd_manifest.txt 4 years ago
.gitattributes Setup cipd bin before calling ninja/autoninja 3 years ago
.gitignore Retry switching to use CIPD ninja v1.8.2 3 years ago
.isort.cfg isort: make available to users 3 years ago
.style.yapf Update "git cl format --python" to default to PEP-8 5 years ago
.vpython Add explicit vpython verification tags which include mac-arm64. 4 years ago
.vpython3 Reland "Use py3 in gitiles recipe module" 3 years ago
CROS_OWNERS CROS_OWNERS: add more build peeps 4 years ago
DIR_METADATA [depot_tools] Migrate metadata to DIR_METADATA. 4 years ago
GOMA_OWNERS Update GOMA_OWNERS 4 years ago
LICENSE
LUCI_OWNERS Remove tandrii@ from OWNERS under depot_tools 4 years ago
OWNERS Revert "Add iannucci to depot_tools owners" 3 years ago
PRESUBMIT.py autoninja: add simple test 3 years ago
README.gclient.md
README.git-cl.md Replace non-inclusive terms 4 years ago
README.md Indicate py3 compatibility for update_depot_tools_toggle.py 3 years ago
WATCHLISTS Update Source team WATCHLIST entry. 3 years ago
auth.py [auth] log errors from luci-auth token invocation. 4 years ago
autoninja [autoninja] Respect user-provided AUTONINJA_BUILD_ID 3 years ago
autoninja.bat [autoninja] Respect user-provided AUTONINJA_BUILD_ID on Windows 3 years ago
autoninja.py [mac] Restore an upper limit on the number of jobs on macOS 3 years ago
bb Add revert instructions 4 years ago
bb.bat Add revert instructions 4 years ago
black black: add helper for formatting Python 3 years ago
bootstrap_python3 [mac/arm] pull python3 binary in cipd bootstrap now that it exists 4 years ago
breakpad.py
cbuildbot simplify the chromite wrappers 6 years ago
cipd Add riscv64 architecture detection 3 years ago
cipd.bat [cipd] Take cipd.ps1 out of %PATH%. 5 years ago
cipd_bin_setup.bat Retry switching to use CIPD ninja v1.8.2 3 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version Bump cipd to 2.6.5 3 years ago
cipd_client_version.digests Bump cipd to 2.6.5 3 years ago
cipd_manifest.txt Roll PGO CLI changes into depot_tools 3 years ago
cipd_manifest.versions Roll PGO CLI changes into depot_tools 3 years ago
cit Use py3 for remaining tools in depot_tools path 4 years ago
cit.bat Use py3 for remaining tools in depot_tools path 4 years ago
cit.py Use pylint 2.7 for depot_tools 3 years ago
clang-format Use py3 for remaining tools in depot_tools path 4 years ago
clang-format.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format.py Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.py Use pylint 2.7 for depot_tools 3 years ago
codereview.settings update stale codereview.chromium.org links 4 years ago
compile_single_file Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.bat Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.py Use pylint 2.7 for depot_tools 3 years ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 3 years ago
cpplint.py Tag cpplint errors 3 years ago
cpplint_chromium.py
cros cros: raise python version requirement to 3.6 5 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add revert instructions 4 years ago
detect_host_arch.py Add riscv64 architecture detection 3 years ago
dirmd Add revert instructions 4 years ago
dirmd.bat Add revert instructions 4 years ago
download_from_google_storage Switch download_from_google_storage to py3 4 years ago
download_from_google_storage.bat use python3 for download_from_google_storage.bat 3 years ago
download_from_google_storage.py Skip 'ls' when downloading from gs. 3 years ago
ensure_bootstrap Use python3 for gsutil bootstrapping 3 years ago
fetch Make Python 3 default on Windows 5 years ago
fetch.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
fetch.py Add protocol_override entry to .gclient 3 years ago
fix_encoding.py Fix \r\r\n line endings in presubmit output 3 years ago
gclient Skip depot_tools update for gclient recurse 3 years ago
gclient-new-workdir.py Explicitly run everything with python3 3 years ago
gclient.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gclient.py Add protocol_override entry to .gclient 3 years ago
gclient_completion.sh
gclient_eval.py Use pylint 2.7 for depot_tools 3 years ago
gclient_paths.py Change FindGclientRoot to Use os.path.abspath instead of os.path.realpath 4 years ago
gclient_scm.py Remove duplicate sparse-checkout call. 3 years ago
gclient_utils.py Update gclient cloning to work with cog. 3 years ago
gerrit_client.py Allow to pass CC list when create a gerrit change 3 years ago
gerrit_util.py [gerrit] Add more gerrit API wrappers 3 years ago
git-cache Add quotes around paths in bash scripts 5 years ago
git-cl Add quotes around paths in bash scripts. 5 years ago
git-crrev-parse Fix git-crrev-parse to work with both master & main branches 4 years ago
git-drover Add quotes around paths in bash scripts 5 years ago
git-find-releases Add quotes around paths in bash scripts 5 years ago
git-footers Add quotes around paths in bash scripts 5 years ago
git-freeze Add quotes around paths in bash scripts 5 years ago
git-gs Add *.ts (typescript files) to git-gs 3 years ago
git-hyper-blame Add quotes around paths in bash scripts 5 years ago
git-map Add quotes around paths in bash scripts 5 years ago
git-map-branches Add quotes around paths in bash scripts 5 years ago
git-mark-merge-base Add quotes around paths in bash scripts 5 years ago
git-migrate-default-branch Add git-migrate-default-branch 5 years ago
git-nav-downstream Add quotes around paths in bash scripts 5 years ago
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch Add quotes around paths in bash scripts 5 years ago
git-number Add quotes around paths in bash scripts 5 years ago
git-rebase-update Add quotes around paths in bash scripts 5 years ago
git-rename-branch Add quotes around paths in bash scripts 5 years ago
git-reparent-branch Add quotes around paths in bash scripts 5 years ago
git-retry Add quotes around paths in bash scripts 5 years ago
git-runhooks Revert "Remove unused functionality in bot_update.py" 3 years ago
git-squash-branch Add quotes around paths in bash scripts 5 years ago
git-thaw Add quotes around paths in bash scripts 5 years ago
git-upstream-diff Add quotes around paths in bash scripts 5 years ago
git_cache.py Use remote information about default branch 3 years ago
git_cl.py Run presubmit checks without GerritAccessor if GERRIT_HOST is not set. 3 years ago
git_cl_completion.sh Add git completion helper to cl upload 5 years ago
git_common.py Use pylint 2.7 for depot_tools 3 years ago
git_dates.py
git_drover.py Explicitly run everything with python3 3 years ago
git_find_releases.py Explicitly run everything with python3 3 years ago
git_footers.py Explicitly run everything with python3 3 years ago
git_freezer.py Explicitly run everything with python3 3 years ago
git_hyper_blame.py Explicitly run everything with python3 3 years ago
git_map.py Explicitly run everything with python3 3 years ago
git_map_branches.py Explicitly run everything with python3 3 years ago
git_mark_merge_base.py Explicitly run everything with python3 3 years ago
git_migrate_default_branch.py Update git fetch refspecs on git migrate 4 years ago
git_nav_downstream.py Explicitly run everything with python3 3 years ago
git_new_branch.py Explicitly run everything with python3 3 years ago
git_number.py Use pylint 2.7 for depot_tools 3 years ago
git_rebase_update.py Make the "mark branch dormant" instructions simpler to copy+paste. 3 years ago
git_rename_branch.py Explicitly run everything with python3 3 years ago
git_reparent_branch.py Explicitly run everything with python3 3 years ago
git_retry.py Explicitly run everything with python3 3 years ago
git_squash_branch.py Explicitly run everything with python3 3 years ago
git_upstream_diff.py Explicitly run everything with python3 3 years ago
gn gn: Call gn.bat in msysgit on Windows. 4 years ago
gn.bat Revert "Call python3.bat explicitly from gn.bat on Windows." 4 years ago
gn.py Use pylint 2.7 for depot_tools 3 years ago
goma_auth Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
goma_ctl Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
gsutil.py Reland "Update gsutil to use gsutil version 4.68" 3 years ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 3 years ago
isort isort: make available to users 3 years ago
led Add revert instructions 4 years ago
led.bat Add revert instructions 4 years ago
lockfile.py Reland "Use OS level locking in git_cache.py" 5 years ago
luci-auth Add revert instructions 4 years ago
luci-auth.bat Add revert instructions 4 years ago
lucicfg Add revert instructions 4 years ago
lucicfg.bat Add revert instructions 4 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md Replace non-inclusive terms 4 years ago
metrics.py Explicitly run everything with python3 3 years ago
metrics_utils.py Explicitly run everything with python3 3 years ago
my_activity.py Use pylint 2.7 for depot_tools 3 years ago
ninja Retry switching to use CIPD ninja v1.8.2 3 years ago
ninjalog.README.md ninjalog_uploader: use goma_auth to detect googler 3 years ago
ninjalog_uploader.py [ninjalog uploader] Collect more android GN args 3 years ago
ninjalog_uploader_wrapper.py Typo when countdown is more than 1. 3 years ago
owners.py Change to slash separator to fix a bug on Windows in owners.py 4 years ago
owners_client.py Reland "presubmit: Skip owners checks if code-owners plugin is enabled." 4 years ago
owners_finder.py Use pylint 2.7 for depot_tools 3 years ago
pinpoint Add revert instructions 4 years ago
pinpoint.bat Add revert instructions 4 years ago
post_build_ninja_summary.py autoninja: use pure python3 to get build id and for post_build_ninja_summary.py 4 years ago
presubmit_canned_checks.py Make tree-closed a warning for presubmit --all 3 years ago
presubmit_canned_checks_test.py Explicitly run everything with python3 3 years ago
presubmit_canned_checks_test_mocks.py Use pylint 2.7 for depot_tools 3 years ago
presubmit_support.py Report when vpython (Python 2) is run during presubmits 3 years ago
profile.xml
prpc Add revert instructions 4 years ago
prpc.bat Add revert instructions 4 years ago
pylint pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.5 Fix hangs when running pylint with py3 3 years ago
pylint-1.5.bat Add an option to specify pylint version 4 years ago
pylint-2.6 Fix hangs when running pylint with py3 3 years ago
pylint-2.6.bat Get pylint-2.6 to work under vpython3 on Windows. 4 years ago
pylint-2.7 Fix hangs when running pylint with py3 3 years ago
pylint-2.7.bat Add pylint-2.7 4 years ago
pylint.bat pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint_main.py Explicitly run everything with python3 3 years ago
pylintrc CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist 5 years ago
python_runner.sh Make Python 3 default on Windows 5 years ago
rdb Add revert instructions 4 years ago
rdb.bat Add revert instructions 4 years ago
rdb_wrapper.py Explicitly run everything with python3 3 years ago
repo repo: restore fstrings for Python 3.6 4 years ago
repo_launcher Explicitly run everything with python3 3 years ago
roll-dep Make Python 3 default on Windows 5 years ago
roll-dep.bat Make Python 3 default on Windows 5 years ago
roll_dep.py Explicitly run everything with python3 3 years ago
rustfmt.py [rust] [depot_tools] Minimal `rustfmt` support for `git cl format`. 4 years ago
scm.py Use pylint 2.7 for depot_tools 3 years ago
setup_color.py Explicitly run everything with python3 3 years ago
split_cl.py Explicitly run everything with python3 3 years ago
subcommand.py Use pylint 2.7 for depot_tools 3 years ago
subprocess2.py [subprocess2] Replace VOID with DEVNULL 4 years ago
swift-format Support git cl formatting for swift files 3 years ago
swift_format.py Make swift-format default True on Mac hosts 3 years ago
update_depot_tools Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
update_depot_tools.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
update_depot_tools_toggle.py Indicate py3 compatibility for update_depot_tools_toggle.py 3 years ago
upload_metrics.py Catch RemoteDisconnected on upload metrics 3 years ago
upload_to_google_storage.py Explicitly run everything with python3 3 years ago
utils.py Add a basic depot_tools version information 3 years ago
vpython Report when vpython (Python 2) is run during presubmits 3 years ago
vpython.bat Report when vpython (Python 2) is run during presubmits 3 years ago
vpython3 depot_tools: Simplify MinGW check. 5 years ago
vpython3.bat The python3 bin directory no longer needs to be added to PATH. 3 years ago
watchlists.py Explicitly run everything with python3 3 years ago
weekly Explicitly run everything with python3 3 years ago
whitespace.txt Change whitespace.txt 4 years ago
win32imports.py Reland "Use OS level locking in git_cache.py" 5 years ago
wtf Explicitly run everything with python3 3 years ago
yapf Revert "Update vpython spec for yapf" 4 years ago
yapf.bat Run yapf with vpython3 4 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.