You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Andrii Shyshkalov 25b1da95b3 Revert "Show GIT_TRACE for git command in bot_update.py"
This reverts commit 6e215cefe2.

Reason for revert: seems to have broken bot_update 
https://ci.chromium.org/swarming/task/39ff1814b3bb5b10?server=chromium-swarm.appspot.com

Original change's description:
> Show GIT_TRACE for git command in bot_update.py
> 
> GIT_TRACE=true tells us which internal git command is slow.
> https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables
> 
> I got following results in my local repository.
> Let me confirm the bots show similar behavior.
> 
> C:\src\chromium\src>set GIT_TRACE=true
> 
> C:\src\chromium\src>git rebase-update
> 21:32:36.519698 git.c:576               trace: exec: 'git-rebase-update'
> 21:32:36.519698 run-command.c:626       trace: run_command: 'git-rebase-update'
> 21:32:38.889848 git.c:344               trace: built-in: git 'fetch' '--multiple' 'origin'
> 21:32:38.893846 run-command.c:626       trace: run_command: 'fetch' '--append' 'origin'
> Fetching origin
> 21:32:38.911858 git.c:344               trace: built-in: git 'fetch' '--append' 'origin'
> 21:32:38.983909 run-command.c:626       trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:32:39.002923 git.c:576               trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:32:39.003923 run-command.c:626       trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:32:43.782266 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:32:43.827301 run-command.c:626       trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
> remote: Counting objects: 74400, done
> remote: Finding sources: 100% (19/19)
> 21:35:49.348951 run-command.c:626       trace: run_command: 'unpack-objects' '--pack_header=2,19'
> 21:35:49.368985 git.c:344               trace: built-in: git 'unpack-objects' '--pack_header=2,19'
> remote: Total 19 (delta 1), reused 18 (delta 1)
> Unpacking objects: 100% (19/19), done.
> 21:35:49.597328 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:35:49.612375 git.c:344               trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> From https://chromium.googlesource.com/chromium/src
>    e8994685157b..fd56d3ad0528  master     -> origin/master
> 21:35:50.281845 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
> 21:35:50.287848 run-command.c:1484      run_processes_parallel: done
> 21:35:50.309865 run-command.c:626       trace: run_command: 'gc' '--auto'
> 21:35:50.328880 git.c:344               trace: built-in: git 'gc' '--auto'
> 21:35:50.453967 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
> 21:35:50.460971 run-command.c:1484      run_processes_parallel: done
> 21:35:50.460971 run-command.c:626       trace: run_command: 'gc' '--auto'
> 21:35:50.480985 git.c:344               trace: built-in: git 'gc' '--auto'
> Rebasing: direct_goma
> Rebasing: python_pool
> 
> C:\src\chromium\src>git fetch
> 21:36:23.409703 git.c:344               trace: built-in: git 'fetch'
> 21:36:23.486758 run-command.c:626       trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:36:23.506772 git.c:576               trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:36:23.506772 run-command.c:626       trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
> 21:36:28.542596 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:36:28.578620 run-command.c:626       trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
> 21:36:28.601635 git.c:344               trace: built-in: git 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
> remote: Counting objects: 67598, done
> remote: Finding sources: 100% (28/28)
> 21:39:29.787441 run-command.c:626       trace: run_command: 'unpack-objects' '--pack_header=2,28'
> 21:39:29.812462 git.c:344               trace: built-in: git 'unpack-objects' '--pack_header=2,28'
> remote: Total 28 (delta 2), reused 20 (delta 2)
> Unpacking objects: 100% (28/28), done.
> 21:39:30.083690 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:39:30.108704 git.c:344               trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> From https://chromium.googlesource.com/chromium/src
>    fd56d3ad0528..fbcc09282dc8  master     -> origin/master
> 21:39:30.788186 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
> 21:39:30.795191 run-command.c:1484      run_processes_parallel: done
> 21:39:30.813200 run-command.c:626       trace: run_command: 'gc' '--auto'
> 21:39:30.836212 git.c:344               trace: built-in: git 'gc' '--auto'
> 
> 
> Bug:749709
> Change-Id: I5b94549c42271885365c2354dc3f58399d6aebe0
> Reviewed-on: https://chromium-review.googlesource.com/786691
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@google.com>

TBR=hinoka@chromium.org,agable@chromium.org,tandrii@chromium.org,tikuta@google.com

Change-Id: I970ddac1fd21e904c69dc18e48169d49293b1800
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749709
Reviewed-on: https://chromium-review.googlesource.com/786413
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
bootstrap/win Update depot_tools prod git to 2.15.0 8 years ago
fetch_configs Update fetch config with new Syzygy location. 8 years ago
git-templates
infra Roll recipe dependencies (trivial). 8 years ago
man git-upstream-diff: add optional branch argument 8 years ago
recipes Revert "Show GIT_TRACE for git command in bot_update.py" 8 years ago
support
testing_support Do not write gclient_gn_args_file too early. 8 years ago
tests [presubmit] Rename to CheckChangedLUCIConfigs 8 years ago
third_party [depot_tools] Add mock lib 8 years ago
win_toolchain Add --repackage option to VS packaging script 8 years ago
zsh-goodies
.gitattributes Add gsutil.vpython spec to recipe bundles 8 years ago
.gitignore Add vs_files.ciopfs to gitignore 8 years ago
.style.yapf
LICENSE
OWNERS Remove references to phajdan.jr 8 years ago
PRESUBMIT.py Remove defunct Rietveld end-to-end tests 8 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md Proofread README.git-cl.md. 9 years ago
README.md Add links to bug tracker, forum and review UI 8 years ago
README.testing
WATCHLISTS Remove myself (dpranke@) from the WATCHLISTS. 9 years ago
annotated_gclient.py
appengine_mapper.py Automatically map urls to their raw appengine forms 9 years ago
apply_issue
apply_issue.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
apply_issue.py apply_issue: remove old hack. 8 years ago
auth.py [presubmit] Extend depot tools auth to use luci context 8 years ago
autoninja autoninja - ninja wrapper to make goma easier 8 years ago
autoninja.bat Fix autoninja to allow compiling one source file 8 years ago
autoninja.py Fix autoninja to allow compiling one source file 8 years ago
breakpad.py Finally get rid of depot_tools' breakpad. 9 years ago
buildbucket.py
cbuildbot
checkout.py Revert "Fix checkout.py issues when p.patchlevel > 1." 8 years ago
chrome_set_ver
cipd depot_tools: Use armv6 for cipd's GOARCH when on armv7 host. 8 years ago
cipd.bat Revert "[cipd] Bump version, log at warning." 8 years ago
cipd.ps1 [cipd] Bump version, log at warning (#2). 8 years ago
cipd_bin_setup.bat [cipd] Bump version, log at warning (#2). 8 years ago
cipd_bin_setup.sh Fix depot_tools errors that cause runhooks to be inoperable for Cygwin 8 years ago
cipd_client_version [cipd] Add support for ppc64 and ppc64le. 8 years ago
cipd_manifest.txt [led] Roll led to latest version. 8 years ago
cit
cit.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cit.py cit.py: Use infra.git's cit branch instead of the deployed branch 8 years ago
clang-format
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Improve clang-format error messages when run outside of chromium checkout 8 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Make merge driver complain about older gits 9 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Add a script to make it easier to build a single source file with ninja 8 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py Remove presubmit check for DISALLOW_* macros 8 years ago
cpplint_chromium.py
cros
cros_sdk
dart_format.py
depot-tools-auth
depot-tools-auth.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
depot-tools-auth.py Fix coloring madness in depot_tools. 9 years ago
download_from_google_storage
download_from_google_storage.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
download_from_google_storage.py download_from_google_storage: call gsutil.py once before anything else happens 8 years ago
ensure_bootstrap [depot_tools] Add "ensure_bootstrap" script. 8 years ago
fetch
fetch.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
fetch.py [git] Remove hard-coded "depot_tools" Git. 8 years ago
fix_encoding.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
gclient Make msys depot_tools upgrade process smoother. 9 years ago
gclient-new-workdir.py Fix regression of gclient-new-workdir.py 8 years ago
gclient.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gclient.py [gclient hooks] add .bat to vpython on windows 8 years ago
gclient_completion.sh
gclient_eval.py gclient conditionals are supposed to allow '!=', but don't currently. 8 years ago
gclient_scm.py Revert "git_cache: Remove locks" 8 years ago
gclient_utils.py Reland "gclient runhooks: now with less spammy progress notifications" 8 years ago
gerrit_client.py depot_tools: Fix executable bit for gerrit_*.py 8 years ago
gerrit_util.py Do not delete users' draft comments 8 years ago
git-cache Generalize python_git_runner for use in non-git scripts. 10 years ago
git-cl Generalize python_git_runner for use in non-git scripts. 10 years ago
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-crsync
git-drover Generalize python_git_runner for use in non-git scripts. 10 years ago
git-find-releases Generalize python_git_runner for use in non-git scripts. 10 years ago
git-footers Generalize python_git_runner for use in non-git scripts. 10 years ago
git-freeze Generalize python_git_runner for use in non-git scripts. 10 years ago
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git-map Generalize python_git_runner for use in non-git scripts. 10 years ago
git-map-branches Generalize python_git_runner for use in non-git scripts. 10 years ago
git-mark-merge-base Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-downstream Generalize python_git_runner for use in non-git scripts. 10 years ago
git-nav-upstream
git-new-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-number Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rebase-update Generalize python_git_runner for use in non-git scripts. 10 years ago
git-rename-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-reparent-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-retry Generalize python_git_runner for use in non-git scripts. 10 years ago
git-runhooks
git-squash-branch Generalize python_git_runner for use in non-git scripts. 10 years ago
git-thaw Generalize python_git_runner for use in non-git scripts. 10 years ago
git-upstream-diff Generalize python_git_runner for use in non-git scripts. 10 years ago
git_cache.py Revert "git_cache: Remove locks" 8 years ago
git_cl.py Add OutputApi.AppendCC to allow presubmit checks to add CCs 8 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py [presubmit] Add check to call validation endpoint for config files 8 years ago
git_dates.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover.py git-drover: send mail and don't use WIP mode 8 years ago
git_find_releases.py find-releases: handle untagged merges 10 years ago
git_footers.py git_footers: fix bug stdin-based message input. 8 years ago
git_freezer.py
git_hyper_blame.py git hyper-blame: Fixed --no-default-ignores option to not take argument. 8 years ago
git_map.py git-map: use committer date instead of author date 8 years ago
git_map_branches.py Update help text for git-map-branches 8 years ago
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py Clarify how `new-branch` is different for --help 9 years ago
git_number.py Pass user name and email to git-number's initial commit. 8 years ago
git_rebase_update.py Flush stdout before squash attempt 8 years ago
git_rename_branch.py
git_reparent_branch.py Add better error messages to git_reparent_branch. 10 years ago
git_retry.py [git retry] Fix Git wrapper fallthrough. 8 years ago
git_squash_branch.py Include branch name in git-squash-branch's default message 8 years ago
git_upstream_diff.py git-upstream-diff: add optional branch argument 8 years ago
gn
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py
gsutil.py Fix depot_tools errors that cause runhooks to be inoperable for Cygwin 8 years ago
gsutil.vpython [gsutil.vpython] Update packages. 8 years ago
led [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
mac_toolchain depot_tools: add mac_toolchain shim 8 years ago
my_activity.py Add support for PDFium to my_activity.py 8 years ago
my_reviews.py Use dateutil.parser for parsing dates. 8 years ago
ninja Update ninja to v1.8.2 8 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
owners.py Also check override files before checking the fs 8 years ago
owners_finder.py Use OldContents() for OWNERS files to do checks 8 years ago
patch.py Revert "Fix checkout.py issues when p.patchlevel > 1." 8 years ago
presubmit_canned_checks.py [presubmit] Rename to CheckChangedLUCIConfigs 8 years ago
presubmit_support.py Add OutputApi.AppendCC to allow presubmit checks to add CCs 8 years ago
profile.xml
pylint
pylint.py Permits running pylint without pylintrc. 10 years ago
pylintrc depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
python_runner.sh Multiple improvements to windows bash integration. 9 years ago
repo repo: update to v1.12.34-cr2 9 years ago
rietveld.py Change rietveld.py to use GET on get_depends_on_patchset 8 years ago
roll-dep
roll-dep-svn Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
roll-dep-svn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll-dep.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll_dep.py roll-dep: Add comments indicating that --no-log needs to keep working 8 years ago
roll_dep_svn.py Update roll_dep_svn for new DEPS syntax 8 years ago
scm.py Correct Git show's path format on Windows 8 years ago
setup_color.py setup_color.py should not be executable, as it pollutes $PATH. 8 years ago
split_cl.py Fix git cl upload --send-mail typo in split_cl.py 8 years ago
subcommand.py Revert "gclient: return non-zero exit code on unknown command" 8 years ago
subprocess2.py depot_tools: Replace pylint error numbers with symbolic names. 9 years ago
update_depot_tools Revert "update_depot_tools: make cipd_bin_setup failures fatal" 8 years ago
update_depot_tools.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_to_google_storage.py Make download_from_google_storage.py print nothing in the happy case where it needs to do nothing. 8 years ago
vpython [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
vpython.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
watchlists.py watchlists: Precompile filepath regular expressions before using them. 8 years ago
weekly
wtf

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.