aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '246580c7b8'
${ noResults }
depot_tools/metadata
History
Jiewei Qian 79cfa048c0 metadata: early terminate certain fields to avoid over extraction 
This CL adds a "early terminate the field based on field value" parser
mechanism to end the field as soon as the field value provides an
unambiguous answer to the question we care about.

This is to prevent over-extraction over certain fields (specifically,
local modifications) which can either be a definitive answer (e.g. No
modification) or multi-line free-form texts (which may contain unknown
fields that we don't care about at this stage).

This mitigates over extraction of README.chromium files like:

```
Local Modifications:
None

How to Uprev:
Steps...
```

Where the old parser would extract "None\n\nHow to Uprev:\nSteps..."

This CL also refactors single line fields to use the same early
termination mechanism since single line field simply ends as soon as
the line is parsed.

Union[Something, None] is changed to Optional[Something] based on
styleguide.

Bug: b/324149233
Change-Id: I3fca80eaceb071263f8ae8730afda230fff0bbb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5394917
Reviewed-by: Anne Redulla <aredulla@google.com>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 		1 year ago
..
fields metadata: early terminate certain fields to avoid over extraction 1 year ago
tests metadata: early terminate certain fields to avoid over extraction 1 year ago
OWNERS [ssci] Defined basic metadata fields 2 years ago
PRESUBMIT.py [ssci] PEP8 formatting for metadata directory 2 years ago
README.md [ssci] Script to run validation on all metadata files 2 years ago
__init__.py Define main metadata validation functions 2 years ago
dependency_metadata.py [ssci] Support alias for Shipped field 2 years ago
discover.py metadata: sort discovered files and validation messages 1 year ago
parse.py metadata: early terminate certain fields to avoid over extraction 1 year ago
scan.py metadata: sort result summary 1 year ago
validate.py metadata: sort discovered files and validation messages 1 year ago
validation_result.py metadata: early terminate certain fields to avoid over extraction 1 year ago

README.md

Validation for Chromium's Third Party Metadata Files

This directory contains the code to validate Chromium third party metadata files, i.e. README.chromium files.

Prerequisites

  1. Have the Chromium source code checked out on disk
  2. Ensure you've run gclient runhooks on your source checkout

Run

metadata/scan.py can be used to search for and validate all Chromium third party metadata files within a repository. For example, if your chromium/src checkout is at ~/my/path/to/chromium/src, run the following command from the root directory of depot_tools:

vpython3 --vpython-spec=.vpython3 metadata/scan.py ~/my/path/to/chromium/src