You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Mohamed Heikal 171c07458e Fix crash were CL has no reviewers
Currently git cl owners tries to fetch the current reviewers of a CL
from gerrit. However, this fails with a KeyError when there are no
reviewers currently. This cl fixes that bug.

Bug: 895722
Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2
Reviewed-on: https://chromium-review.googlesource.com/c/1330122
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
7 years ago
bootstrap/win Deploy git 2.18 to prod win depot_tools users. 7 years ago
fetch_configs Add android_internal fetch spec. 7 years ago
git-templates
infra Roll recipe dependencies (trivial). 7 years ago
man Fix minor regression in git_upstream_diff. 7 years ago
recipes Roll recipe dependencies (trivial). 7 years ago
support chromite_wrapper: add python3 support for except 7 years ago
testing_support owners.py: Use os.path.split to handle file separators correctly 7 years ago
tests git-cl: Add tests for metrics collection. 7 years ago
third_party httplib: Update to 0.11.3 7 years ago
win_toolchain [win-cross] Support using a zip file for the Windows SDK 7 years ago
zsh-goodies
.gitattributes Add autoninja* to .gitattributes. 7 years ago
.gitignore git-cl: Log response IP and host for Gerrit RPC failures. 7 years ago
.style.yapf
LICENSE
OWNERS Add brucedawson to OWNERS of autoninja file 7 years ago
PRESUBMIT.py [cipd] Bump CIPD client version to 2.2.8, add presubmit check for *.digests. 7 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md Proofread README.git-cl.md. 9 years ago
README.md Third whitespace change to test builder. 7 years ago
README.testing
WATCHLISTS Remove tandrii@ from watching git cl changes. 7 years ago
annotated_gclient.py
appengine_mapper.py Automatically map urls to their raw appengine forms 9 years ago
auth.py auth: request refresh tokens with expiry <3 minutes. 7 years ago
autoninja Set unique build ID. 7 years ago
autoninja.bat Set unique build ID. 7 years ago
autoninja.py Quote the full path to ninja.exe. 7 years ago
breakpad.py
buildbucket.py [buildbucket] Fix printing build url 7 years ago
cbuildbot
checkout.py Use core.quotePath=false for more git diffs 7 years ago
chrome_set_ver
cipd [cipd] Check CIPD client hash against pinned SHA256 during updates. 7 years ago
cipd.bat [cipd] Check CIPD client hash during updates on Windows. 7 years ago
cipd.ps1 [cipd] More careful error handling during CIPD bootstrap on Windows. 7 years ago
cipd_bin_setup.bat [cipd] Bump version, log at warning (#2). 8 years ago
cipd_bin_setup.sh Fix depot_tools errors that cause runhooks to be inoperable for Cygwin 8 years ago
cipd_client_version [cipd] Bump CIPD client and vpython versions. 7 years ago
cipd_client_version.digests [cipd] Bump CIPD client and vpython versions. 7 years ago
cipd_manifest.txt [cipd] Bump CIPD client and vpython versions. 7 years ago
cipd_manifest.versions [cipd] Bump CIPD client and vpython versions. 7 years ago
cit
cit.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cit.py [cit] Use subprocess2 to properly sink stdout. 7 years ago
clang-format
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Improve clang-format error messages when run outside of chromium checkout 8 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Make merge driver complain about older gits 9 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Add a script to make it easier to build a single source file with ninja 8 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py Revert "cpplint: Pull in upstream changes" 7 years ago
cpplint_chromium.py
cros
cros_sdk
dart_format.py
depot-tools-auth
depot-tools-auth.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
depot-tools-auth.py
detect_host_arch.py Use lowercase machine architecture. 7 years ago
download_from_google_storage
download_from_google_storage.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
download_from_google_storage.py AIX: Enable usage of fetch and gclient 7 years ago
ensure_bootstrap [depot_tools] Add "ensure_bootstrap" script. 8 years ago
fetch
fetch.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
fetch.py Don't fetch tags when using --no-history. 7 years ago
fix_encoding.py depot_tools: Replace pylint error numbers with symbolic names. 8 years ago
gclient gclient setdep doesn't need to update_depot_tools 7 years ago
gclient-new-workdir.py os.realpath => os.path.realpath in gclient-new-workdir.py 7 years ago
gclient.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gclient.py gclient: Make built-in vars available for expansion. 7 years ago
gclient_completion.sh
gclient_eval.py gclient: Make built-in vars available for expansion. 7 years ago
gclient_scm.py gclient: set the push url to the actual repository instead of the mirror. 7 years ago
gclient_utils.py Reland "gclient: Add commands to edit dependencies and variables in DEPS" 7 years ago
gerrit_client.py depot_tools: Fix executable bit for gerrit_*.py 8 years ago
gerrit_util.py git-cl: Stop logging response headers on 404 Gerrit RPC status. 7 years ago
git-cache
git-cl
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-drover
git-find-releases
git-footers
git-freeze
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Use system unzip on macOS 7 years ago
git_cl.py Fix crash were CL has no reviewers 7 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py os.realpath => os.path.realpath in gclient-new-workdir.py 7 years ago
git_dates.py
git_drover.py Reland "Use core.quotePath=false when git is listing files" 7 years ago
git_find_releases.py
git_footers.py Let git_footers split final paragraphs in specific cases 7 years ago
git_freezer.py
git_hyper_blame.py git hyper-blame: Fix tabulation of Unicode characters in author name. 7 years ago
git_map.py git-map: use committer date instead of author date 8 years ago
git_map_branches.py Update help text for git-map-branches 8 years ago
git_mark_merge_base.py
git_nav_downstream.py metrics: Separate metrics collection and print notice logic. 7 years ago
git_new_branch.py Add a '--inject-current' option to 'git new-branch' 7 years ago
git_number.py Pass user name and email to git-number's initial commit. 8 years ago
git_rebase_update.py Flush stdout before squash attempt 8 years ago
git_rename_branch.py
git_reparent_branch.py
git_retry.py [git retry] Fix Git wrapper fallthrough. 8 years ago
git_squash_branch.py Include branch name in git-squash-branch's default message 8 years ago
git_upstream_diff.py Fix minor regression in git_upstream_diff. 7 years ago
gn
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py Fix unhelpful error when gn.py run in wrong directory. 7 years ago
gsutil.py gsutil update default version to 4.30 7 years ago
gsutil.vpython Add the crcmod wheel for gsutil, to get it to shut up. 7 years ago
led [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
luci-auth [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
luci-auth.bat [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
mac_toolchain depot_tools: add mac_toolchain shim 8 years ago
metrics.README.md git-cl: Report Gerrit RPC requests information. 7 years ago
metrics.py metrics: Collect git version. 7 years ago
metrics_utils.py Add the opt-in/out commands to metrics notice 7 years ago
my_activity.py Add skia reviews to my_activity 7 years ago
my_reviews.py Use dateutil.parser for parsing dates. 8 years ago
ninja Update ninja to v1.8.2 8 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
owners.py owners.py: Use os.path.split to handle file separators correctly 7 years ago
owners_finder.py Skip files owned by reviewers when quering for missing owners. 7 years ago
patch.py Revert "Fix checkout.py issues when p.patchlevel > 1." 8 years ago
post_build_ninja_summary.py Improve post_build_ninja_summary.py's incremental build handling 7 years ago
presubmit_canned_checks.py [cipd] Add presubmit support for checking *.digests file. 7 years ago
presubmit_support.py presubmit_support: Fix parallel execution of presubmit tests. 7 years ago
profile.xml
prpc [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
prpc.bat [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
pylint
pylint.py
pylintrc pylint: reland upgrade to 1.5.6 7 years ago
python_runner.sh
repo repo: update to v1.12.34-cr2 9 years ago
rietveld.py Change rietveld.py to use GET on get_depends_on_patchset 8 years ago
roll-dep
roll-dep-svn Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
roll-dep-svn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll-dep.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
roll_dep.py [roll-dep] Use Bug: instead of BUG= 7 years ago
roll_dep_svn.py Update roll_dep_svn for new DEPS syntax 8 years ago
scm.py git cl: add reviewers and ccs to git push command if possible. 7 years ago
setup_color.py setup_color.py should not be executable, as it pollutes $PATH. 8 years ago
split_cl.py `git cl split`: Fix typos in cq_dry_run code 7 years ago
subcommand.py Revert "gclient: return non-zero exit code on unknown command" 8 years ago
subprocess2.py depot_tools: Replace pylint error numbers with symbolic names. 8 years ago
update_depot_tools fix fetch on aix 7 years ago
update_depot_tools.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_metrics.py Suppress URLErrors when uploading metrics. 7 years ago
upload_to_google_storage.py Make download_from_google_storage.py print nothing in the happy case where it needs to do nothing. 8 years ago
vpython [vpython] Implement developer bypass parser in vpython wrapper. 7 years ago
vpython.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
watchlists.py watchlists: Precompile filepath regular expressions before using them. 8 years ago
weekly
wtf
yapf Update yapf version 0.22 -> 0.24 7 years ago
yapf.bat Add yapf 7 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.