You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Fletcher Woodruff 11b341547a cpplint: move a build/include check to subcategory
There is a cpplint include check that ensures that all includes have a
directory name preceding them. However, if all source lives in the root
of a repository, there is no point in having a directory.

Because this check lives under 'build/include', it's impossible to
filter without filtering other useful checks.

Move it to 'build/include_directory' so it can be more easily filtered.

BUG=chromium:1073191
TEST=cros lint on a file with 'filter=-build/include_directory' in
     CPPLINT.cfg

Change-Id: Ie15fb2398a6d0297ef96219e67076ea262abf853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159690
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Fletcher Woodruff <fletcherw@chromium.org>
6 years ago
bootstrap [cipd] Take cipd.ps1 out of %PATH%. 6 years ago
fetch_configs
git-templates
infra Roll recipe dependencies (trivial). 6 years ago
man [man] Followup: Fix order of depot_tools in PATH in html docs 6 years ago
python-bin
recipes Roll recipe dependencies (trivial). 6 years ago
testing_support Run spellchecker on depot_tools 6 years ago
tests Fix slash direction sensitivity in git cl owners 6 years ago
third_party Revert "Improve git cl split" 6 years ago
win_toolchain Skip sources downloaded by WinDbg when checking toolchain status. 6 years ago
zsh-goodies
.cipd_impl.ps1 [cipd] Take cipd.ps1 out of %PATH%. 6 years ago
.gitattributes
.gitignore
.style.yapf Update "git cl format --python" to default to PEP-8 6 years ago
.vpython depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 6 years ago
.vpython3
CROS_OWNERS
GOMA_OWNERS Add tikuta, <user>@chromium.org to GOMA_OWNERS 6 years ago
LICENSE
LUCI_OWNERS Make vadimsh@ an owner of cipd*. 6 years ago
OWNERS Add brucedawson@ to own post_build_ninja_summary.py 6 years ago
PRESUBMIT.py Fix Windows unit tests for roll-dep and use py3 6 years ago
README.gclient.md
README.git-cl.md
README.md
WATCHLISTS
auth.py
autoninja Fix a python invocation that wasn't replaced with vpython. 6 years ago
autoninja.bat Run autoninja scripts using vpython. 6 years ago
autoninja.py Run spellchecker on depot_tools 6 years ago
bb
bb.bat
bootstrap_python3 Add quotes around paths in bash scripts. 6 years ago
breakpad.py
cbuildbot
chrome_set_ver
cipd
cipd.bat [cipd] Take cipd.ps1 out of %PATH%. 6 years ago
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version [cipd] Update client v2.3.4 => v2.3.5. 6 years ago
cipd_client_version.digests [cipd] Update client v2.3.4 => v2.3.5. 6 years ago
cipd_manifest.txt Run spellchecker on depot_tools 6 years ago
cipd_manifest.versions Roll out new goma client binary VERSION=197 6 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py cpplint: move a build/include check to subcategory 6 years ago
cpplint_chromium.py
cros Reland "cros: switch CrOS programs to python3" 6 years ago
cros_sdk
crosjobs
dart_format.py
detect_host_arch.py
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py Run spellchecker on depot_tools 6 years ago
ensure_bootstrap
fetch Make Python 3 default on Windows 6 years ago
fetch.bat Make Python 3 default on Windows 6 years ago
fetch.py Make fetch compatible with py 3.5 6 years ago
fix_encoding.py Run spellchecker on depot_tools 6 years ago
gclient Make Python 3 default on Windows 6 years ago
gclient-new-workdir.py
gclient.bat Make Python 3 default on Windows 6 years ago
gclient.py Run spellchecker on depot_tools 6 years ago
gclient_completion.sh
gclient_eval.py Run spellchecker on depot_tools 6 years ago
gclient_paths.py depot_tools: Add tests for gclient_paths 6 years ago
gclient_scm.py gclient: Set with_branch_heads if asked to sync to refs/branch-heads/* 6 years ago
gclient_utils.py Run spellchecker on depot_tools 6 years ago
gerrit_client.py Add gerrit_client unit tests 6 years ago
gerrit_util.py ReadHttpResponse: Handle 429s with retries and adjust retry count 6 years ago
git-cache Add quotes around paths in bash scripts 6 years ago
git-cl Add quotes around paths in bash scripts. 6 years ago
git-crrev-parse
git-drover Add quotes around paths in bash scripts 6 years ago
git-find-releases Add quotes around paths in bash scripts 6 years ago
git-footers Add quotes around paths in bash scripts 6 years ago
git-freeze Add quotes around paths in bash scripts 6 years ago
git-gs
git-hyper-blame Add quotes around paths in bash scripts 6 years ago
git-map Add quotes around paths in bash scripts 6 years ago
git-map-branches Add quotes around paths in bash scripts 6 years ago
git-mark-merge-base Add quotes around paths in bash scripts 6 years ago
git-nav-downstream Add quotes around paths in bash scripts 6 years ago
git-nav-upstream
git-new-branch Add quotes around paths in bash scripts 6 years ago
git-number Add quotes around paths in bash scripts 6 years ago
git-rebase-update Add quotes around paths in bash scripts 6 years ago
git-rename-branch Add quotes around paths in bash scripts 6 years ago
git-reparent-branch Add quotes around paths in bash scripts 6 years ago
git-retry Add quotes around paths in bash scripts 6 years ago
git-runhooks
git-squash-branch Add quotes around paths in bash scripts 6 years ago
git-thaw Add quotes around paths in bash scripts 6 years ago
git-upstream-diff Add quotes around paths in bash scripts 6 years ago
git_cache.py git-cache: Also bootstrap in the case that there are 0 pack files 6 years ago
git_cl.py git_cl: add --parallel for yapf 6 years ago
git_cl_completion.sh
git_common.py Fix printing error on git-rebase failure 6 years ago
git_dates.py
git_drover.py Decode the returned encoded bytes of subprocess.check_all/check_output. 6 years ago
git_find_releases.py Add unit tests for git_find_releases 6 years ago
git_footers.py Run spellchecker on depot_tools 6 years ago
git_freezer.py
git_hyper_blame.py Add support for git_hyper_blame for Windows 6 years ago
git_map.py git-map: Refactor and add simple tests 6 years ago
git_map_branches.py git cl: use short URLs in `git cl status`. 6 years ago
git_mark_merge_base.py
git_nav_downstream.py depot_tools: Use gclient_utils.AskForData instead of raw_input. 6 years ago
git_new_branch.py git-cl: Fix invocation of git new-branch 6 years ago
git_number.py Run spellchecker on depot_tools 6 years ago
git_rebase_update.py Revert "Fix printing error on git-rebase failure" 6 years ago
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
goma_auth
goma_auth.bat Fix goma_auth.bat to use nul instead of null. 6 years ago
goma_ctl [goma_ctl] Use vpython to call goma_ctl.py. 6 years ago
goma_ctl.bat Fixed goma_ctl.bat to pipe to nul instead of creating a file called null. 6 years ago
gsutil.py
gsutil.py.bat
gsutil.vpython gsutil.vpython: Set vpython_version: 2.7 6 years ago
led
led.bat
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md metrics: Update documentation 6 years ago
metrics.py Reland "metrics: Use vpython3 instead of sys.executable" 6 years ago
metrics_utils.py
my_activity.py depot_tools: Use gclient_utils.AskForData instead of raw_input. 6 years ago
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md
ninjalog_uploader.py Run autoninja scripts using vpython. 6 years ago
ninjalog_uploader_wrapper.py Run autoninja scripts using vpython. 6 years ago
owners.py Fix slash direction sensitivity in git cl owners 6 years ago
owners_finder.py depot_tools: Use gclient_utils.AskForData instead of raw_input. 6 years ago
post_build_ninja_summary.py More detailed build-step type summary for android 6 years ago
presubmit_canned_checks.py [Presubmit] Allow GetUnitTestsRecursively() to restrict Python versions. 6 years ago
presubmit_support.py Fix slash direction sensitivity in git cl owners 6 years ago
profile.xml
prpc
prpc.bat
pylint
pylint-1.5
pylint-1.6
pylint-1.7
pylint-1.8
pylint-1.9
pylint.bat
pylint_main.py
pylintrc
python_runner.sh Make Python 3 default on Windows 6 years ago
repo repo: update to 2.5 launcher 6 years ago
roll-dep Make Python 3 default on Windows 6 years ago
roll-dep.bat Make Python 3 default on Windows 6 years ago
roll_dep.py Fix Python3 integer division issue in roll-dep. 6 years ago
scm.py Run spellchecker on depot_tools 6 years ago
setup_color.py
split_cl.py git-cl: Fix git-cl split. 6 years ago
subcommand.py Run spellchecker on depot_tools 6 years ago
subprocess2.py subprocess2: Fix CalledProcessError str() method on Python 3. 6 years ago
update_depot_tools Add quotes around paths in bash scripts 6 years ago
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py
vpython
vpython.bat Reland "vpython: Specify interpreter to run." 6 years ago
vpython3 depot_tools: Simplify MinGW check. 6 years ago
vpython3.bat Fix git-* commands when using python3 on Win 6 years ago
watchlists.py
weekly
wtf
yapf yapf: support --parallel flag 6 years ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.