You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Philipp Wollermann 0b943400a4 Execute Ninja / Siso directly from autoninja.py.
Instead of printing a command-line, we just directly call into the respective main functions from Python. This saves spawning another interpreter and prevents things that can go wrong from having to quote, unquote, split and tunnel arguments through shells.

Part of my bigger auto{ninja,siso} refactoring.

Tested:
- Handling of the ^^ suffix on Windows still works correctly.
- Handling of error codes - i.e.; making sure
  "autoninja base_unittests && base_unittests.exe" behaves properly
  in the success/failure case.
- Make sure the command prompt title is reliably reset on exit.

I tested autoninja with all combinations of these:
- Host platform: Linux, macOS, Windows
- Remote GN args: <none>, use_goma=true, use_remoteexec=true
- Siso GN args: <none>, use_siso=true
- Targets: base, ../../base/types/expected_macros_unittest.cc^ (on Linux) and ../../base/types/expected_macros_unittest.cc^^ (on Windows)

R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org

Bug: b/293657720
Change-Id: I275a775fdc5abb6555f79d4beab76cd0914d4bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924185
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
2 years ago
bootstrap switch to 4 space indent 2 years ago
fetch_configs Remove __future__ imports 2 years ago
git-templates
hooks Require prompt from users to confirm submodules commit. 2 years ago
infra Roll recipe dependencies (trivial). 2 years ago
man Remove __future__ imports 2 years ago
metadata Remove __future__ imports 2 years ago
python-bin cipd/python: optimize cat usage 3 years ago
python2-bin cipd/python: optimize cat usage 3 years ago
recipes Roll recipe dependencies (trivial). 2 years ago
testing_support Remove __future__ imports 2 years ago
tests Execute Ninja / Siso directly from autoninja.py. 2 years ago
third_party Remove last py2 workarounds 2 years ago
win_toolchain Remove __future__ imports 2 years ago
zsh-goodies
.cipd_impl.ps1 Import Get-FileHash from PowerShell's version specific path 3 years ago
.flake8 Add a config file for the flake8 linter. 2 years ago
.gitattributes Define main metadata validation functions 2 years ago
.gitignore Update gitignore to be explicit about directories 2 years ago
.isort.cfg isort: make available to users 4 years ago
.style.yapf switch to 4 space indent 2 years ago
.vpython
.vpython3 Add brotli to .vpython3 for depot_tools 2 years ago
BUILD_OWNERS add siso wrapper 3 years ago
CROS_OWNERS CROS_OWNERS: switch to our common shared lists 3 years ago
DIR_METADATA
LICENSE
LUCI_OWNERS add peep-software-deploy team to luci owners 2 years ago
OWNERS Refactor the depot_tools OWNERS file. 2 years ago
PRESUBMIT.py switch to 4 space indent 2 years ago
README.gclient.md
README.git-cl.md
README.md Remove last py2 workarounds 2 years ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 3 years ago
WATCHLISTS Update WATCHLISTS for ninja, siso and reclient changes 2 years ago
auth.py [auth] Be able to generate id_token 2 years ago
autoninja Execute Ninja / Siso directly from autoninja.py. 2 years ago
autoninja.bat Execute Ninja / Siso directly from autoninja.py. 2 years ago
autoninja.py Execute Ninja / Siso directly from autoninja.py. 2 years ago
autosiso [siso] add autosiso wrappers 3 years ago
autosiso.bat [autosiso] Add single file compile support on Windows 2 years ago
autosiso.py [reclient] Only show shutdown msg if ctrl-C end the build 2 years ago
bazel [ChromiumOS] Add a launcher for Bazel 2 years ago
bazel.py switch to 4 space indent 2 years ago
bb
bb.bat
black black: add helper for formatting Python 4 years ago
bootstrap_python3 Use relative path for cipd 3 years ago
breakpad.py switch to 4 space indent 2 years ago
cbuildbot
cipd Revert "[cipd] Detect Mac ARM running under Rosetta" 2 years ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 3 years ago
cipd_bin_setup.bat Revert "Retry switching to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh cipd_bin_setup: load cipd script instead of running it 2 years ago
cipd_client_version [auth]: Update CIPD to include version update of luci-auth change. 2 years ago
cipd_client_version.digests [auth]: Update CIPD to include version update of luci-auth change. 2 years ago
cipd_manifest.txt [dirmd] Roll dirmd in depot_tools 2 years ago
cipd_manifest.versions [dirmd] Roll dirmd in depot_tools 2 years ago
cipd_manifest_cros_python2.txt Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cipd_manifest_cros_python2.versions Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
clang-format
clang-format.bat
clang_format.py Remove __future__ imports 2 years ago
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py Remove __future__ imports 2 years ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 4 years ago
cpplint.py switch to 4 space indent 2 years ago
cpplint_chromium.py switch to 4 space indent 2 years ago
cros cros: handle CitC checkouts 2 years ago
cros_python2.vpython Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cros_sdk
crosjobs
detect_host_arch.py Remove __future__ imports 2 years ago
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat use python3 for download_from_google_storage.bat 4 years ago
download_from_google_storage.py Remove __future__ imports 2 years ago
ensure_bootstrap setup & share path to depot_tools checkout 2 years ago
fetch [py2] Drop envvar to run scripts with py2 3 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 3 years ago
fetch.py Remove __future__ imports 2 years ago
fix_encoding.py Remove __future__ imports 2 years ago
gclient [py2] Drop envvar to run scripts with py2 3 years ago
gclient-new-workdir.py switch to 4 space indent 2 years ago
gclient.bat [py2] Drop envvar to run scripts with py2 3 years ago
gclient.py Clarify that gclient gitmodules' changes need to be committed. 2 years ago
gclient_completion.sh
gclient_eval.py Remove last py2 workarounds 2 years ago
gclient_paths.py Cache values in gclient_paths.py 2 years ago
gclient_scm.py Fix path's current and new url comparison. 2 years ago
gclient_utils.py switch to 4 space indent 2 years ago
gerrit Symlink gerrit CLI into depot_tools 3 years ago
gerrit_client.py Remove last py2 workarounds 2 years ago
gerrit_util.py Remove last py2 workarounds 2 years ago
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs Add *.ts (typescript files) to git-gs 4 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py switch to 4 space indent 2 years ago
git_cl.py Do not fail formatting when google-java-formatter is not found 2 years ago
git_cl_completion.sh
git_common.py git: tweak fsmonitor warning message to mention the git version fix 2 years ago
git_completion.sh Bash autocompletion for 'git new-branch' and 'git reparent-branch' 2 years ago
git_dates.py switch to 4 space indent 2 years ago
git_drover.py switch to 4 space indent 2 years ago
git_find_releases.py switch to 4 space indent 2 years ago
git_footers.py switch to 4 space indent 2 years ago
git_freezer.py switch to 4 space indent 2 years ago
git_hyper_blame.py switch to 4 space indent 2 years ago
git_map.py switch to 4 space indent 2 years ago
git_map_branches.py switch to 4 space indent 2 years ago
git_mark_merge_base.py switch to 4 space indent 2 years ago
git_migrate_default_branch.py switch to 4 space indent 2 years ago
git_nav_downstream.py switch to 4 space indent 2 years ago
git_new_branch.py switch to 4 space indent 2 years ago
git_number.py switch to 4 space indent 2 years ago
git_rebase_update.py switch to 4 space indent 2 years ago
git_rename_branch.py switch to 4 space indent 2 years ago
git_reparent_branch.py switch to 4 space indent 2 years ago
git_retry.py switch to 4 space indent 2 years ago
git_squash_branch.py switch to 4 space indent 2 years ago
git_upstream_diff.py switch to 4 space indent 2 years ago
gn
gn.bat
gn.py Remove __future__ imports 2 years ago
goma_auth
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 4 years ago
goma_ctl Skip goma on unsupported platforms 3 years ago
goma_ctl.bat Handle goma_ctl/autoninja /? 3 years ago
gsutil.py Remove __future__ imports 2 years ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 4 years ago
infra_to_superproject Use shutil.copytree instead for migration script instead. 3 years ago
infra_to_superproject.bat Use shutil.copytree instead for migration script instead. 3 years ago
infra_to_superproject.py switch to 4 space indent 2 years ago
isort switch to 4 space indent 2 years ago
led
led.bat
lockfile.py Remove __future__ imports 2 years ago
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py Remove __future__ imports 2 years ago
metrics_utils.py Remove __future__ imports 2 years ago
my_activity.py Remove __future__ imports 2 years ago
ninja Revert "Use depot_tools python3 to call ninja.py" 3 years ago
ninja.bat Add single file compile support for Windows in ninja wrappers 3 years ago
ninja.py [gn] Fallback GN in PATH 2 years ago
ninja_reclient.py Revert "Enable racing for ninja+reclient developer builds" 2 years ago
ninjalog.README.md
ninjalog_uploader.py [ninja_log_uploader] fix minor issues 2 years ago
ninjalog_uploader_wrapper.py Remove __future__ imports 2 years ago
owners_client.py switch to 4 space indent 2 years ago
owners_finder.py Remove __future__ imports 2 years ago
pinpoint
pinpoint.bat
post_build_ninja_summary.py Automatically run siso metrics summary for siso builds 2 years ago
presubmit_canned_checks.py Clarify that gclient gitmodules' changes need to be committed. 2 years ago
presubmit_support.py Remove __future__ imports 2 years ago
profile.xml
prpc
prpc.bat
pylint-2.6 switch to 4 space indent 2 years ago
pylint-2.6.bat
pylint-2.7 switch to 4 space indent 2 years ago
pylint-2.7.bat
pylint_main.py Remove __future__ imports 2 years ago
pylintrc
python_runner.sh [py2] Drop envvar to run scripts with py2 3 years ago
rdb
rdb.bat
rdb_wrapper.py switch to 4 space indent 2 years ago
reclient_helper.py [reclient] Only show shutdown msg if ctrl-C end the build 2 years ago
reclient_metrics Add reclient_metrics command 2 years ago
reclient_metrics.README.md [reclient] Update reclient_metrics.README.md to reflect that we collect googler hostnames 2 years ago
reclient_metrics.bat Add reclient_metrics command 2 years ago
reclient_metrics.py switch to 4 space indent 2 years ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 3 years ago
reclientreport.bat Remove unnesisary quotes from propagated args in reclientreport.bat 2 years ago
reclientreport.py [reclient] Use python impl for reclientreport for all platorms temporarily 2 years ago
repo switch to 4 space indent 2 years ago
repo_launcher Remove __future__ imports 2 years ago
roll-dep [py2] Drop envvar to run scripts with py2 3 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 3 years ago
roll_dep.py Remove __future__ imports 2 years ago
rustfmt.py switch to 4 space indent 2 years ago
scm.py sync: Ensure child dependencies are always removed first. 2 years ago
setup_color.py Remove __future__ imports 2 years ago
siso add siso wrapper 3 years ago
siso.bat add siso wrapper 3 years ago
siso.py switch to 4 space indent 2 years ago
split_cl.py Remove __future__ imports 2 years ago
subcommand.py switch to 4 space indent 2 years ago
subprocess2.py switch to 4 space indent 2 years ago
swift-format Support git cl formatting for swift files 4 years ago
swift_format.py switch to 4 space indent 2 years ago
update_depot_tools setup & share path to depot_tools checkout 2 years ago
update_depot_tools.bat Call goma_ctl update_hook only after python3 is bootstrapped. 3 years ago
update_depot_tools_toggle.py switch to 4 space indent 2 years ago
upload_metrics.py switch to 4 space indent 2 years ago
upload_to_google_storage.py Remove __future__ imports 2 years ago
utils.py switch to 4 space indent 2 years ago
vpython vpython: clear DEPOT_TOOLS_DIR before running scripts 2 years ago
vpython.bat Remove Python 2 support for presubmit Commands 3 years ago
vpython3 vpython: clear DEPOT_TOOLS_DIR before running scripts 2 years ago
vpython3.bat Use the bundled interpreter instead of passing -vpython-interpreter. 3 years ago
watchlists.py Remove __future__ imports 2 years ago
weekly Remove __future__ imports 2 years ago
whitespace.txt
win32imports.py switch to 4 space indent 2 years ago
wtf Remove __future__ imports 2 years ago
yapf Update vpython spec for yapf to 0.31.0 3 years ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.