Instead of printing a command-line, we just directly call into the respective main functions from Python. This saves spawning another interpreter and prevents things that can go wrong from having to quote, unquote, split and tunnel arguments through shells.
Part of my bigger auto{ninja,siso} refactoring.
Tested:
- Handling of the ^^ suffix on Windows still works correctly.
- Handling of error codes - i.e.; making sure
"autoninja base_unittests && base_unittests.exe" behaves properly
in the success/failure case.
- Make sure the command prompt title is reliably reset on exit.
I tested autoninja with all combinations of these:
- Host platform: Linux, macOS, Windows
- Remote GN args: <none>, use_goma=true, use_remoteexec=true
- Siso GN args: <none>, use_siso=true
- Targets: base, ../../base/types/expected_macros_unittest.cc^ (on Linux) and ../../base/types/expected_macros_unittest.cc^^ (on Windows)
R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org
Bug: b/293657720
Change-Id: I275a775fdc5abb6555f79d4beab76cd0914d4bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924185
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
|
2 years ago | |
|---|---|---|
| bootstrap | 2 years ago | |
| fetch_configs | 2 years ago | |
| git-templates | ||
| hooks | 2 years ago | |
| infra | 2 years ago | |
| man | 2 years ago | |
| metadata | 2 years ago | |
| python-bin | 3 years ago | |
| python2-bin | 3 years ago | |
| recipes | 2 years ago | |
| testing_support | 2 years ago | |
| tests | 2 years ago | |
| third_party | 2 years ago | |
| win_toolchain | 2 years ago | |
| zsh-goodies | ||
| .cipd_impl.ps1 | 3 years ago | |
| .flake8 | 2 years ago | |
| .gitattributes | 2 years ago | |
| .gitignore | 2 years ago | |
| .isort.cfg | 4 years ago | |
| .style.yapf | 2 years ago | |
| .vpython | ||
| .vpython3 | 2 years ago | |
| BUILD_OWNERS | 3 years ago | |
| CROS_OWNERS | 3 years ago | |
| DIR_METADATA | ||
| LICENSE | ||
| LUCI_OWNERS | 2 years ago | |
| OWNERS | 2 years ago | |
| PRESUBMIT.py | 2 years ago | |
| README.gclient.md | ||
| README.git-cl.md | ||
| README.md | 2 years ago | |
| RECLIENT_OWNERS | 3 years ago | |
| WATCHLISTS | 2 years ago | |
| auth.py | 2 years ago | |
| autoninja | 2 years ago | |
| autoninja.bat | 2 years ago | |
| autoninja.py | 2 years ago | |
| autosiso | 3 years ago | |
| autosiso.bat | 2 years ago | |
| autosiso.py | 2 years ago | |
| bazel | 2 years ago | |
| bazel.py | 2 years ago | |
| bb | ||
| bb.bat | ||
| black | 4 years ago | |
| bootstrap_python3 | 3 years ago | |
| breakpad.py | 2 years ago | |
| cbuildbot | ||
| cipd | 2 years ago | |
| cipd.bat | 3 years ago | |
| cipd_bin_setup.bat | 3 years ago | |
| cipd_bin_setup.sh | 2 years ago | |
| cipd_client_version | 2 years ago | |
| cipd_client_version.digests | 2 years ago | |
| cipd_manifest.txt | 2 years ago | |
| cipd_manifest.versions | 2 years ago | |
| cipd_manifest_cros_python2.txt | 3 years ago | |
| cipd_manifest_cros_python2.versions | 3 years ago | |
| clang-format | ||
| clang-format.bat | ||
| clang_format.py | 2 years ago | |
| codereview.settings | ||
| compile_single_file | ||
| compile_single_file.bat | ||
| compile_single_file.py | 2 years ago | |
| cpplint.bat | 4 years ago | |
| cpplint.py | 2 years ago | |
| cpplint_chromium.py | 2 years ago | |
| cros | 2 years ago | |
| cros_python2.vpython | 3 years ago | |
| cros_sdk | ||
| crosjobs | ||
| detect_host_arch.py | 2 years ago | |
| dirmd | ||
| dirmd.bat | ||
| download_from_google_storage | ||
| download_from_google_storage.bat | 4 years ago | |
| download_from_google_storage.py | 2 years ago | |
| ensure_bootstrap | 2 years ago | |
| fetch | 3 years ago | |
| fetch.bat | 3 years ago | |
| fetch.py | 2 years ago | |
| fix_encoding.py | 2 years ago | |
| gclient | 3 years ago | |
| gclient-new-workdir.py | 2 years ago | |
| gclient.bat | 3 years ago | |
| gclient.py | 2 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 2 years ago | |
| gclient_paths.py | 2 years ago | |
| gclient_scm.py | 2 years ago | |
| gclient_utils.py | 2 years ago | |
| gerrit | 3 years ago | |
| gerrit_client.py | 2 years ago | |
| gerrit_util.py | 2 years ago | |
| git-cache | ||
| git-cl | ||
| git-crrev-parse | ||
| git-drover | ||
| git-find-releases | ||
| git-footers | ||
| git-freeze | ||
| git-gs | 4 years ago | |
| git-hyper-blame | ||
| git-map | ||
| git-map-branches | ||
| git-mark-merge-base | ||
| git-migrate-default-branch | ||
| git-nav-downstream | ||
| git-nav-upstream | ||
| git-new-branch | ||
| git-number | ||
| git-rebase-update | ||
| git-rename-branch | ||
| git-reparent-branch | ||
| git-retry | ||
| git-runhooks | ||
| git-squash-branch | ||
| git-thaw | ||
| git-upstream-diff | ||
| git_cache.py | 2 years ago | |
| git_cl.py | 2 years ago | |
| git_cl_completion.sh | ||
| git_common.py | 2 years ago | |
| git_completion.sh | 2 years ago | |
| git_dates.py | 2 years ago | |
| git_drover.py | 2 years ago | |
| git_find_releases.py | 2 years ago | |
| git_footers.py | 2 years ago | |
| git_freezer.py | 2 years ago | |
| git_hyper_blame.py | 2 years ago | |
| git_map.py | 2 years ago | |
| git_map_branches.py | 2 years ago | |
| git_mark_merge_base.py | 2 years ago | |
| git_migrate_default_branch.py | 2 years ago | |
| git_nav_downstream.py | 2 years ago | |
| git_new_branch.py | 2 years ago | |
| git_number.py | 2 years ago | |
| git_rebase_update.py | 2 years ago | |
| git_rename_branch.py | 2 years ago | |
| git_reparent_branch.py | 2 years ago | |
| git_retry.py | 2 years ago | |
| git_squash_branch.py | 2 years ago | |
| git_upstream_diff.py | 2 years ago | |
| gn | ||
| gn.bat | ||
| gn.py | 2 years ago | |
| goma_auth | ||
| goma_auth.bat | 4 years ago | |
| goma_ctl | 3 years ago | |
| goma_ctl.bat | 3 years ago | |
| gsutil.py | 2 years ago | |
| gsutil.py.bat | 3 years ago | |
| gsutil.vpython3 | 4 years ago | |
| infra_to_superproject | 3 years ago | |
| infra_to_superproject.bat | 3 years ago | |
| infra_to_superproject.py | 2 years ago | |
| isort | 2 years ago | |
| led | ||
| led.bat | ||
| lockfile.py | 2 years ago | |
| luci-auth | ||
| luci-auth.bat | ||
| lucicfg | ||
| lucicfg.bat | ||
| mac_toolchain | ||
| metrics.README.md | ||
| metrics.py | 2 years ago | |
| metrics_utils.py | 2 years ago | |
| my_activity.py | 2 years ago | |
| ninja | 3 years ago | |
| ninja.bat | 3 years ago | |
| ninja.py | 2 years ago | |
| ninja_reclient.py | 2 years ago | |
| ninjalog.README.md | ||
| ninjalog_uploader.py | 2 years ago | |
| ninjalog_uploader_wrapper.py | 2 years ago | |
| owners_client.py | 2 years ago | |
| owners_finder.py | 2 years ago | |
| pinpoint | ||
| pinpoint.bat | ||
| post_build_ninja_summary.py | 2 years ago | |
| presubmit_canned_checks.py | 2 years ago | |
| presubmit_support.py | 2 years ago | |
| profile.xml | ||
| prpc | ||
| prpc.bat | ||
| pylint-2.6 | 2 years ago | |
| pylint-2.6.bat | ||
| pylint-2.7 | 2 years ago | |
| pylint-2.7.bat | ||
| pylint_main.py | 2 years ago | |
| pylintrc | ||
| python_runner.sh | 3 years ago | |
| rdb | ||
| rdb.bat | ||
| rdb_wrapper.py | 2 years ago | |
| reclient_helper.py | 2 years ago | |
| reclient_metrics | 2 years ago | |
| reclient_metrics.README.md | 2 years ago | |
| reclient_metrics.bat | 2 years ago | |
| reclient_metrics.py | 2 years ago | |
| reclientreport | 3 years ago | |
| reclientreport.bat | 2 years ago | |
| reclientreport.py | 2 years ago | |
| repo | 2 years ago | |
| repo_launcher | 2 years ago | |
| roll-dep | 3 years ago | |
| roll-dep.bat | 3 years ago | |
| roll_dep.py | 2 years ago | |
| rustfmt.py | 2 years ago | |
| scm.py | 2 years ago | |
| setup_color.py | 2 years ago | |
| siso | 3 years ago | |
| siso.bat | 3 years ago | |
| siso.py | 2 years ago | |
| split_cl.py | 2 years ago | |
| subcommand.py | 2 years ago | |
| subprocess2.py | 2 years ago | |
| swift-format | 4 years ago | |
| swift_format.py | 2 years ago | |
| update_depot_tools | 2 years ago | |
| update_depot_tools.bat | 3 years ago | |
| update_depot_tools_toggle.py | 2 years ago | |
| upload_metrics.py | 2 years ago | |
| upload_to_google_storage.py | 2 years ago | |
| utils.py | 2 years ago | |
| vpython | 2 years ago | |
| vpython.bat | 3 years ago | |
| vpython3 | 2 years ago | |
| vpython3.bat | 3 years ago | |
| watchlists.py | 2 years ago | |
| weekly | 2 years ago | |
| whitespace.txt | ||
| win32imports.py | 2 years ago | |
| wtf | 2 years ago | |
| yapf | 3 years ago | |
| yapf.bat | ||
README.md
depot_tools
Tools for working with Chromium development. It requires python 3.8.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.