aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '09d7a6a817'
${ noResults }
depot_tools/third_party/cq_client
History
tandrii@chromium.org a1afbb986d Roll cq_client. 
From infra_internal, revisions 6f979a..cd0150f.

TBR=sergiyb@chromium.org,machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1697053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298789 0039d316-1c4b-4281-b951-d872f2087c98
 		9 years ago
..
testdata Roll cq_client. 9 years ago
OWNERS Remove akuegel@ from OWNERS. 9 years ago
README.md Roll cq_client. 9 years ago
__init__.py
…
cq.pb.go Roll cq_client. 9 years ago
cq.proto Roll cq_client. 9 years ago
cq_pb2.py Roll cq_client. 9 years ago

README.md

CQ Client Library.

This directory contains CQ client library to be distributed to other repos. If you need to modify some files in this directory, please make sure that you are changing the canonical version of the source code and not one of the copies, which should only be updated as a whole using Glyco (when available, see chromium issue 489420).

The canonical version is located at https://chrome-internal.googlesource.com/infra/infra_internal/+/master/commit_queue/cq_client.

When modifying cq.proto, consider adding checks to validator in https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/commit_queue/src/commitqueue/validate.go.

Generation of Python and Go bindings

tl;dr

make

Details

All commands below assume you are working in a standard infra_internal gclient checkout (e.g., after you ran mkdir src && cd src && fetch infra_internal) and are in current directory of this README.md (that is, in cd infra_internal/commit_queue/cq_client).

To generate Python's cq_pb2.py you'll need to get and protoc of version 2.6.1. You can get it by make py-prepare.

make py

To generate Golang's protobuf file cq.pb.go, you'll need to bootstrap infra/infra repository and go utilities make go-prepare.

make go

Notes

  1. Please make sure to use proto3-compatible yntax, e.g. no default values, no required fields. As of this writing (Jan 2016), the Go protobuf compiler has been upgraded to 3.0.0. So, if you can generate go bindings, all is good.

  2. If after generating Python binding, CQ tests fail with:

     TypeError: __init__() got an unexpected keyword argument 'syntax'

You've probably used 3.0.0 protoc generator. We should eventually switch to 3x Python version as well, but it requires upgrading infra's Python ENV to newer package. See bootstrap/README.md for more information. We may end up deprecating Python before all infra's Python code can be moved to protobuf v3.