Commit Graph

10 Commits (ff416a73fbe00d95b178829c4a95140f2d998c49)

Author SHA1 Message Date
Nodir Turakulov ff416a73fb deprecate build path
Update recipe modules that use path "build" to either check whether it
is defined or fail with an explanation if it is not defined.

This CL marks failure code paths as `# pragma: no cover`. This comment
will be removed in https://chromium-review.googlesource.com/c/411989/

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ieb7637deefa6e366dfe4c30c7711d60daa06575a
Reviewed-on: https://chromium-review.googlesource.com/412225
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
9 years ago
Nodir Turakulov cb1beaa79f deprecate depot_tools path
Use depot_tools module's methods or package_repo_resource function to
determine paths of tools that live in depot_tools

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ic3172308c140f7f19e982ec6ec5a4b1b83261e1b
Reviewed-on: https://chromium-review.googlesource.com/411936
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
9 years ago
martiniss@chromium.org 25837199f3 Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
Hopefully everything will be back to normal now...

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org d34c90601f Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
Reason for revert:
re-landing because wrong order of reverts :(

Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
> 
> Reason for revert:
> breaks skia bots :(
> 
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> > 
> > Depends on https://codereview.chromium.org/1906323003
> > 
> > BUG=chromium:605919
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
> 
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1921373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org 54e0d26399 Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
Reason for revert:
breaks skia bots :(

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
> 
> Depends on https://codereview.chromium.org/1906323003
> 
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1917263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org f30e872853 depot_tools: add infra_paths recipe module for infra-specific paths
Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org cb3fd431fd Generalize patch_project to patch root conversion.
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.

This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.

R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563

Review URL: https://codereview.chromium.org/1917433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 4c3969479a depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1)
Previous attempt: https://codereview.chromium.org/1642023002

TBR=martiniss

BUG=582074

Review URL: https://codereview.chromium.org/1651033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org f77c42a6a3 Revert of depot_tools: import bot_update gclient git rietveld tryserver recipe modules (patchset #6 id:100001 of https://codereview.chromium.org/1642023002/ )
Reason for revert:
breakages: https://code.google.com/p/chromium/issues/detail?id=582229

Original issue's description:
> depot_tools: import bot_update gclient git rietveld tryserver recipe modules
> 
> BUG=582074
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298447

TBR=maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582074, 582229

Review URL: https://codereview.chromium.org/1644173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298457 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 29689c6822 depot_tools: import bot_update gclient git rietveld tryserver recipe modules
BUG=582074

Review URL: https://codereview.chromium.org/1642023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298447 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago