Commit Graph

119 Commits (fbfa601efda3f683e305ff9c82873dd017e11b82)

Author SHA1 Message Date
agable fbfa601efd Remove svn from gclient recipe module example
R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002
9 years ago
iannucci 045d107c23 Remove patch_url from bot_update.
R=hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2310113003
9 years ago
iannucci 95f3d317e4 Just disable force to ensure that bot_update really is running everywhere.
This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.

Removal of the force option (and related options) to come shortly.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2311673002
9 years ago
tandrii 4cb6fb7fbd bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects.
R=machenbach@chromium.org,andybons@chromium.org
BUG=602906
TEST=manual run of Angle recipe locally

Review-Url: https://codereview.chromium.org/2299693003
9 years ago
andybons 6911b06750 Make rebase and sync the default for Gerrit updates.
BUG=602906
R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility.
Review-Url: https://codereview.chromium.org/2298883002
9 years ago
agable c8f3a3498e Remove non-trivial SVN config from gclient recipe module
R=martiniss@google.com
BUG=640251
Recipe-Tryjob-Bypass-Reason: can't mock expectation changes downstream

Review-Url: https://codereview.chromium.org/2285213004
9 years ago
agable 9741c590a4 Remove defunct SVN-based gclient configs
The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.

R=hinoka@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2291583003
9 years ago
agable 7090f652d1 Remove all references to GIT_MODE from depot_tools
BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003
9 years ago
hinoka 0b7cf885e0 Remove Deps2Git references from bot_update.py
BUG=

Review-Url: https://codereview.chromium.org/2283043002
9 years ago
agable 4b21db06e4 Default gclient's GIT_MODE to True
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004
9 years ago
agable 75e7fc2af1 Just use git refs for lkcr and lkgr
R=iannucci@chromium.org, martiniss@chromium.org
BUG=640251
Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll

Review-Url: https://codereview.chromium.org/2268893004
9 years ago
rmistry 2250d5b3b0 Add apply_gerrit_ref to bot_update api.
BUG=skia:5627

Review-Url: https://codereview.chromium.org/2249983004
9 years ago
phajdan.jr 2cbf79f3c9 git: use new python script to bootstrap git on windows
BUG=635421, 629679

Recipe-Tryjob-Bypass-Reason: downstream changes expected
Review-Url: https://codereview.chromium.org/2264583002
9 years ago
tandrii 0c561b329b Cleanup old debugging code.
TBR=phajdan.jr@chromium.org
BUG=537417

Review-Url: https://codereview.chromium.org/2242123003
9 years ago
phajdan.jr 7929675b19 Add cipd recipe module to depot_tools
Copied from dfd62794c4/scripts/slave/recipe_modules/cipd/

It's being moved so that we can use the module in git recipe module in depot_tools. See https://goto.google.com/jmywn for more context.

BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2243773002
9 years ago
hinoka d2c82a25e8 Bot_update recipe output: Add 'Try Rebasing' to patch failure output
I still see confusion around patch failures.  This should clearify things.

BUG=

Review-Url: https://codereview.chromium.org/2231953002
9 years ago
Andrew Bonventre f83fa37b34 Add flag to rebase before gclient sync when applying a Gerrit patch
BUG=612417

Change-Id: I695bb93afd5ccde2c34b0dfc78989248e9b923e9
9 years ago
phajdan.jr d755329820 git: fix git cache support
It's now based on bot_update logic.

BUG=630601

Review-Url: https://codereview.chromium.org/2209383002
9 years ago
borenet 9d5696da80 Make git recipe api add depot_tools to PATH
"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002
9 years ago
machenbach 1278dbd127 Enable testing ICU CLs on chromium trybots
BUG=631575

Review-Url: https://codereview.chromium.org/2183393002
9 years ago
tandrii 6da50398be bot_update: improve UX when gclient is not configured.
Instead of long stacktrace, explain what went wrong.

R=sergiyb@chromium.org,andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175343002
9 years ago
martiniss 8697dfcf8b Fix bot_update to correctly handle exceptions
If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Review-Url: https://codereview.chromium.org/2175103002
9 years ago
nodir 248331450c infra_paths module: swarmbucket config
add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.

This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.

TBR=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176913002
9 years ago
nodir b96f2d5b1d Revert of bot_update: fix git dir check (patchset #1 id:1 of https://codereview.chromium.org/2174923002/ )
Reason for revert:
this is wrong. if directory is not empty, git clone fails

Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: cdac80c9fb

TBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2173683003
9 years ago
nodir cdac80c9fb bot_update: fix git dir check
existance of a dir does not mean it is a git repo. Check .git dir
presence instead.

This is the reason why swarmbucket build.git builds fail.

TBR=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2174923002
9 years ago
tandrii dc24ee1a99 git recipe_module: add experimental git-cache support.
BUG=630601
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2173823002
9 years ago
mikecase 1f2c9b78ae Add config to gclient to pull in Chromedriver test deps.
BUG=

Review-Url: https://codereview.chromium.org/2166443002
9 years ago
phajdan.jr 6a33f25283 git: apply a 5 minutes timeout to "ensure git tooling on windows" step
This covers 99% of successful runs on all builders based on event_mon
data.

BUG=629025

Review-Url: https://codereview.chromium.org/2162143004
9 years ago
smut ae7ea3167e Revert "Remove all safesync_url functionality from gclient"
This reverts commit 99a7f80578.
This reverts commit 2697cd19a7.
This reverts commit 8c51b6f148.
This reverts commit d4aedc811b.

Reason for revert:
Breaks iOS release branch builds.

BUG=623762
TBR=agable,maruel

Review URL: https://codereview.chromium.org/2162583004 .
9 years ago
phajdan.jr 27726869d2 tryserver: make it possible to override cwd for get_files_affected_by_patch
BUG=584079, 593999

Review-Url: https://codereview.chromium.org/2144473003
9 years ago
phajdan.jr b2580abf45 Manually roll recipes.cfg recipe_engine 2c5509f:9d78ba3
TBR=estaab, iannucci, martiniss

BUG=chromium:593999

Review-Url: https://codereview.chromium.org/2132363002
9 years ago
phajdan.jr 7dba71bfbc remove blink_or_chromium gclient config
It's not needed after blink merge.

TBR=emso, sergiyb, tandrii

BUG=none

Review-Url: https://codereview.chromium.org/2117063002
9 years ago
phajdan.jr 4f00aa0b49 infra_paths: keep cache paths super short to avoid long path issues (attempt #2)
This is a reland of https://codereview.chromium.org/2102613002/ .

See https://goto.google.com/ljfzu (Google-internal) for more context. Summary:
- the only builders with chromium checkout affected by this are on chromium.fyi
- we can't clean up old cache directories before switching to new ones

Also see https://goto.google.com/oyxwm why so short directory names are OK.
Similarly https://codereview.chromium.org/2061213002 .

BUG=623575

Review-Url: https://codereview.chromium.org/2102403002
9 years ago
martiniss 575e6766f2 bot_update: Allow patch_oauth2 to work in kitchen
site config is not present on builders which use kitchen, so we need to use credentials provided by puppet in the /creds directory.

BUG=624212
TBR=hinoka

Review-Url: https://codereview.chromium.org/2108073002
9 years ago
martiniss 808d7ea4f6 Add upload and issue to git_cl recipe module
Depends on https://codereview.chromium.org/2088343002

Review-Url: https://codereview.chromium.org/2087093002
9 years ago
nodir 460d557eec Revert of infra_paths: keep cache paths super short to avoid long path issues (patchset #1 id:1 of https://codereview.chromium.org/2102613002/ )
Reason for revert:
/b/cache dir on slaves were not cleaned up and now disk alerts are firing

please come up with a cleanup strategy before re-landing this CL

Original issue's description:
> infra_paths: keep cache paths super short to avoid long path issues
>
> BUG=623575
>
> Committed: aa0b3b6bd0

TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,thakis@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623575

Review-Url: https://codereview.chromium.org/2100793004
9 years ago
phajdan.jr aa0b3b6bd0 infra_paths: keep cache paths super short to avoid long path issues
BUG=623575

Review-Url: https://codereview.chromium.org/2102613002
9 years ago
phajdan.jr 426e4271da bot_update: add /chrome-internal/trunk/src-internal to RECOGNIZED_PATHS
The script already contains references to chrome-internal, and when running
under remote_run we have no access to hacky build_internal checkout.

BUG=593999, 584079

Review-Url: https://codereview.chromium.org/2101573002
9 years ago
phajdan.jr c2054c2fb0 infra_paths: enable persistent cache also on Windows
BUG=584079, 459840, 593999, 596887

Review-Url: https://codereview.chromium.org/2102503002
9 years ago
phajdan.jr 44945e7838 infra_paths: enable persistent cache also on Mac
BUG=584079, 459840, 593999, 596887

Review-Url: https://codereview.chromium.org/2095333002
9 years ago
agable 99a7f80578 Remove all safesync_url functionality from gclient
R=maruel@chromium.org
BUG=109184

Review-Url: https://codereview.chromium.org/2087313002
9 years ago
phajdan.jr cd0b7abe26 gclient: fix patch_project handling for the recipe engine
This is needed after d88f0c8311

BUG=none

Review-Url: https://codereview.chromium.org/2091313003
9 years ago
phajdan.jr@chromium.org 166ac05c03 depot_tools: expose paths to presubmit_support.py and upload_to_google_storage.py
They're needed by infra recipes (https://codereview.chromium.org/2045493002).

BUG=617565

Review-Url: https://codereview.chromium.org/2045473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300695 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
dpranke@chromium.org c2a88544c3 Add 'catapult' to gclient config to enable trybots.
With this change, we can run chromium tryjobs for changes to catapult.

R=tandrii@chromium.org, nednguyen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2030623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org bf23eff330 Make WebRTC patches apply to Chromium checkouts on Windows.
The change in https://codereview.chromium.org/1982243002
didn't take into account that the script runs on the actual
bot OS, so Windows will have backslashes as dir separators.

BUG=438952

Review-Url: https://codereview.chromium.org/2021783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300672 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
nodir@chromium.org 7ae58956f6 bot_update: remove activation check for non-masters
Cherry-pick https://codereview.chromium.org/2000403004/ to depot_tools's
bot_update.py

R=hinoka@chromium.org
BUG=613641

Review-Url: https://codereview.chromium.org/2022453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300670 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 08b0e06ebc depot_tools: add gclient config for bare recipes-py repo
BUG=chromium:459840

Review-Url: https://codereview.chromium.org/2017843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300665 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
martiniss@chromium.org 456ca7f0c2 tryserver recipe_module: Add get_tags.
Lets you get CL tags for a given CL.

BUG=591172

Review-Url: https://codereview.chromium.org/1915833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300658 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org 71929a5f85 Use --extra_patchlevel for WebRTC patches on Chromium trybots.
The --extra_patchlevel flag was added in
https://codereview.chromium.org/1988583002/

In order to make it possible for WebRTC patches to apply in
src/third_party/webrtc of a Chromium checkout, one directory
level needs to be trimmed.

BUG=438952, 611808

Review-Url: https://codereview.chromium.org/1982243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300618 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org 2d845d4531 Set patch project path correct for WebRTC.
'git apply' works on Git indexes, so it's not possible
to apply a patch to src/third_party/webrtc with cwd=src/third_party.
Instead, set the cwd to the correct dir and add an extra patch
level using the new flag in https://codereview.chromium.org/1988583002/

This essentially reverts https://codereview.chromium.org/1977373002/
+ sets the project path correctly to src/third_party/webrtc.

BUG=438952

Review-Url: https://codereview.chromium.org/1984993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300616 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago