aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,975 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'f90b3b035c'
${ noResults }
Commit Graph

20 Commits (f90b3b035c31a13a08922ff0270dfc55fe5a176c)

Author SHA1 Message Date
Gavin Mak 642a989069 Reland "Drop py2 support in recipe modules" 
This is a reland of commit 5819c303f0

Original change's description:
> Drop py2 support in recipe modules
>
> python3 is the only supported version of python in depot_tools.
>
> Bug: 1475402
> Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 1475402
Change-Id: Ie4e6612a95511026b7602837f8dd3030bcf3ef8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4811285
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Gavin Mak a5f17dd7b3 Revert "Drop py2 support in recipe modules" 
This reverts commit 5819c303f0.

Reason for revert: breaking dart builds

Original change's description:
> Drop py2 support in recipe modules
>
> python3 is the only supported version of python in depot_tools.
>
> Bug: 1475402
> Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 1475402
Change-Id: I0fef7581835bb25ea7e4f22303eef11e72df9536
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4811596
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Gavin Mak 5819c303f0 Drop py2 support in recipe modules 
python3 is the only supported version of python in depot_tools.

Bug: 1475402
Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Takuto Ikuta 37d1312fcd presubmit: remove reference to omit_python2 experiment 
This is not used now.

Bug: 1441784
Change-Id: I7c332ff2738c697bb5ea4c14d4b938a2cdab9221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4584391
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2 years ago
Robert Iannucci 330de93b15 [recipe_modules/presubmit] Only run with vpython3. 
The time has come :).

R=aravindvasudev@google.com

Bug: 1413668
Recipe-Nontrivial-Roll: build
Change-Id: Ie6e26cc87a22d17eb2e4bc6b8f86895738670eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4389545
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
Takuto Ikuta d37c0b505e Revert "presubmit: remove presubmit step running python2" 
This reverts commit f155639336.

Reason for revert:
https://ci.chromium.org/ui/p/infra/builders/try/infra-try-presubmit/b8781520593544576993/overview

Original change's description:
> presubmit: remove presubmit step running python2
>
> This is to deactivate `luci.buildbucket.omit_python2` experiment.
>
> I'll submit this after https://crrev.com/c/4515085 is submitted.
>
> Bug: 1401307, 1441784
> Recipe-Nontrivial-Roll: build
> Change-Id: I0aec58e9b96c961da21f0de0850c4078bb679c33
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4513661
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 1401307, 1441784
Change-Id: I47a9921b74917a4b0caa6f577c9fc6d3542f8b54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4519043
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Takuto Ikuta f155639336 presubmit: remove presubmit step running python2 
This is to deactivate `luci.buildbucket.omit_python2` experiment.

I'll submit this after https://crrev.com/c/4515085 is submitted.

Bug: 1401307, 1441784
Recipe-Nontrivial-Roll: build
Change-Id: I0aec58e9b96c961da21f0de0850c4078bb679c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4513661
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
Joanna Wang d04720454a Update recipes python tests. 
For: http://shortn/_j5mixA1Mjr

Change-Id: I7ac4471fbb1e0629d59263266b3470e372d03a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4368938
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
Michael Achenbach 86cfa62b07 [presubmit] Use vpython3 on bots without vpython2 
Bug: 1401307
Change-Id: Ie81608be8e8ec64ed569b0367f1426b4b2ab8b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4110968
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Riley Wong ea876290e0 Accepting new flag for --all flag and allowing CI to run. 
Bug:1322936
Change-Id: Idc829268aa11846325bd9db1b6b8d33094025f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3861697
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Gavin Mak 326546b771 Add PYTHON_VERSION_COMPATIBILITY to presubmit recipe module 
Bug: 1227140
Change-Id: Ie11384422ef3a01fe6bc02d335a3525aeb91e7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3123952
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 4 years ago
Josip Sokcevic b7f797be55 Add support for py3 presubmit 
Depot tools git cl presubmit supports py2 and py3. However, presumbit
recipe only runs py2. This patch adds support for running py3 presubmit
checks too.

Bug: 1214829
Recipe-Nontrivial-Roll: build
Change-Id: I089460eaf65d4b6f1238eea13eb087fadb21cad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2934371
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
Yiwei Zhang b2659abe19 recipe: Adopt the breaking change in cq recipe_module 
cq changes: https://crrev.com/c/2773637

R=tandrii

Bug: 1177864
Recipe-Manual-Change: build
Recipe-Manual-Change: build_limited_scripts_slave
Change-Id: Ic89a2cd6c53bc69050dca4b1e3da8560a5f37dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2776469
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 4 years ago
Takuto Ikuta 5c4c28f111 [recipes] remove is_luci specification 
This is always True now.

Bug: 1128847
Change-Id: Ief951e9312ea8bd13c98b4bbc87c18d7307bb43a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2413667
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 5 years ago
Aaron Gable 1a0daf728c Let the presubmit recipe module skip owners checks when necessary 
The circumstances under which this might happen are left up to the
invoking recipe, which in most cases is the chromium presubmit.py.

Bug: 1034114
Change-Id: Ia8db6ab0da04750d6753e6281ef859e19aea4039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2018224
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
 5 years ago
Takuto Ikuta ad557c41da presubmit: deprecate vpython_spec_path 
This property is not used anymore.

Bug: 1002153
Change-Id: I19a503a73ec00e9121b2d9a2c130824a974d307a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877747
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Debrian Figueroa 0fb33b26eb Updated presubmit error message format. 
Changed all headers in message to be the size of header 4 tags.

Made sure there is always a new line after code tag(```).

Change-Id: I772941a8bbf0634c9496ec648533110997e23cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702293
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Debrian Figueroa 587f1feeee Fix Presubmit Infra Failure tests 
Change-Id: Ie807735f22e76ce0e2ee18c2ed8b149c342fa7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700149
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Debrian Figueroa 986505f489 Updated error message format 
Added headers and code tags

Made sure that when limiting message size, at least part of the message
is seen.

Change-Id: I404e2f7e86907f701332a62fe46334ff437cca03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1690741
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Debrian Figueroa <debrian@google.com>
 6 years ago
John Budorick f21ffb4f98 Copy presubmit logic up into the presubmit recipe module. 
Bug: 925774
Change-Id: I27e8670578095db71384d77cdb3d606bfdcf1077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1684760
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
 6 years ago