Those comments are from bots and not useful when running git cl
comments.
R=ajp@google.com
Fixed: 1266986
Change-Id: I6a8f8f81e02e4b4624027c4c95546bf5e3e7244b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3268350
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Andy Perelson <ajp@chromium.org>
Reviewed-by: Andy Perelson <ajp@chromium.org>
This adds a `fetch website` config to make it a bit easier
to fetch the Git repo for the new chromium.org website.
Bug: 1260171
Change-Id: I1c147dedf18debf8f24f59989b9ff443e4ddd1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3263176
Auto-Submit: Dirk Pranke <dpranke@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8831460817300785777
Please review the expectation changes, and LGTM+CQ.
recipe_engine:
ecdeebb466
ecdeebb (iannucci@chromium.org)
[doc] Add a small section about resources.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=jochen@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2c74e7811179aa4725c355f2da942e3fd472171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3262658
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>
Reviewed-by: Oliver Newman <olivernewman@google.com>
Run unit tests only on commit since it's way too slow for upload. User
can still run tests on local machine via `git cl presubmit` or directly.
This CL reduces time it takes to upload from 2+ minutes to ~10s.
R=apolito@google.com
Fixed: 1263688
Change-Id: Id96c049296eea7c0a4d1e484dce6ae4296aa8041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3249192
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
When CheckPatchFormatted presubmited canned check is executed, it runs
git cl format with --dry-run. When dry-run is used, exit codes are
ignored and we rely on only on stdout message to detect if formatting is
needed or not. This itself is wrong, but changing this will likely
require significant redesign.
This patch appends stderr output to stdout message on non-zero exit code
and therefore allowing git cl format to actually exit with code 2.
R=gavinmak@google.com
Fixed: 1264111
Change-Id: I5eccf34f533640fd93209c97d1c8d9c85bb94d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3249191
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
I can't see any users of this version via cs/, so drop it to speed up
the ensure_bootstrap phase.
Change-Id: Ib6e26490c9194959d55ed9199aade7b72ff3ebd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3246423
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
I can't see any users of this version via cs/, so drop it to speed up
the ensure_bootstrap phase.
Change-Id: I6598dacbde336ae555bdc101d4044c078907570d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3246422
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
I can't see any users of this version via cs/, so drop it to speed up
the ensure_bootstrap phase.
Change-Id: Ib1e3ca75f1d091161c57a33f238c64973949a584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3246413
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Running each bootstrap in serial seriously slows things down, and it
gets worse as we add more. On my very expensive desktop, the no-op
case takes 5 seconds. When running in parallel, it's now ~1.5 sec.
Change-Id: I4304fddf22ef5a718218a807aeb05e08e5418bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3245746
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
I can't see any users of this version via cs/, so drop it to speed up
the ensure_bootstrap phase.
Change-Id: I3779228daec2858d48c288023ffdb924b5038297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3245745
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
When using alias, we no longer can't nor need to prefix command with
git. This change updates all [alias] blocks and removes git from it.
Change-Id: Id89142ef86935e04e21872ce61fb63a511ed40a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3244473
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
This value is passed in the JSON body, not in the URL, so does not need
to be escaped, otherwise trying to make a branch/tag from another
branch/tag leads to errors like:
gerrit_util.GerritError: (400) Bad Request: invalid revision "refs%2Fheads%2Fchromium%2F4665"
BUG=1052179
R=linxinan@chromium.org, sokcevic@google.com
Change-Id: I80d709370165fcb84a3375e18b67d4a921be9a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3243724
Auto-Submit: Michael Moss <mmoss@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
These lints are redundant and in rare cases may conflict with
clang-format output. We treat clang-format's output as the correct
formatting, so disable the lints.
The following whitespace lints are retained, all others are disabled:
whitespace/blank_line
whitespace/comments
whitespace/empty_conditional_body
whitespace/empty_if_body
whitespace/empty_loop_body
whitespace/ending_newline
whitespace/todo
Bug: chromium:1240500
Change-Id: I22e2d8ea4de021ea389e155d8c9e096c3ae6f8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3231485
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8832347904217217633
recipe_engine:
151ff69edf~..9041c56a7c586eefee7cccb761fe305ed1681d87
151ff69 (jwata@google.com)
[swarming] update luci-go swarming version
9041c56 (mohrr@google.com)
Handle string exit_code in swarming task result
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaeafd072892426abcd44b77e7e7c4667a6d6b72f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3244108
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This version will start generating `lucicfg {...}` section in
project.cfg, but only when some other config file changes (so
that lucicfg version change itself doesn't require all configs
to be regenerated).
This information will be used by LUCI tooling to figure out how
to regenerate LUCI project configs en masse.
Use `lucicfg generate -force main.star` to forcefully generate
`lucicfg {...}` section in the existing configs.
R=iannucci@chromium.org
Change-Id: I001ceb0dae1df797c2f76c3f6a28b8420d18f4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232093
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Gitwatch supports closing bugs with a FIX(ES|ED|ING)? tag in the
commit message, but we only check BUG to ensure a bug is
specified, add the fix fields to BugsFromDescription so that presubmits
will still pass if only eg: FIXES=b:1234 is given.
Gitwatch reference:
http://shortn/_LGPgBjgi3A
FIXED=b:203812728
TEST=presubmit_unittest.py doesn't fail more than it already does
Change-Id: I6afc38c786e281dcefb4d359bb9212ebe5980ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3237598
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
This will make it easier to call new or uncommon Gerrit APIs, without
needing to add dedicated methods for each one. This also makes it easier
to debug API calls by exposing the raw response data, which is often
processed or filtered in the existing wrapper methods.
BUG=1052179
R=linxinan@chromium.org
Change-Id: I0b594a9fdaabae4b0ebb379dc5473f4d6de67a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235714
Auto-Submit: Michael Moss <mmoss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
recipe-roller
Josip Sokcevic
Dirk Pranke
Fumitoshi Ukai
Robert Iannucci
Gavin Mak
Scott Lee
Ryan Heise
Takuto Ikuta
Ben Pastene
Mike Frysinger
Michael Moss
Collin Baker
Vadim Shtayura
Sean McAllister
Chris McDonald