maruel@chromium.org
5de1397a35
Make AffectedFile usable as items.
...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118521
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18076 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
b0dfd35742
Make the presubmit output much more compact.
...
Disable prompting when using gcl presubmit xxx.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118498
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18054 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
b7d469083f
Add CheckChangeSvnEolStyle presubmit canned check.
...
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/119421
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18053 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3410d917f3
Add InputApi.AffectedSourceFile() and custom filtering support.
...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119365
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17975 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
44a17adf95
Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().
...
ReadFile limits to reading files inside the repository.
CheckChangeHasNoCR reads the text files looking for \r and fails if found.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118370
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17857 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
de0ba297d9
Fix presubmit_support.py run standalone and RunPythonUnitTests
...
TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119285
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17839 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
d7dccf5614
Add InputApi.is_committing to be able to return a failure or notification, depending on the check.
...
Add input_api.traceback, useful for dumping information.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119252
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17837 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
32ba260f1e
Added patchset persistence in gcl, this is necessary to implement a presubmit queue.
...
Now enforces ChangeInfo.issue (and .patchset) to be a int.
Renamed LoadChangelistInfo() to ChangeInfo.Load().
Removed ChangeInfo.__init__() default parameters.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118355
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17836 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1487d53b6c
Improve the presubmit_canned_checks testing by using a real mock and testing for more cases.
...
Remove a superfluous check in CheckLongLines().
Add unittest to InputApi.
Review URL: http://codereview.chromium.org/114082
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17805 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
4661e0c77b
The broken PRESUBMIT.py was fixed so reintegrating revision 17554 (which was good in the first place).
...
BUG=none
TEST=none
TBR=joi
Review URL: http://codereview.chromium.org/119130
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17578 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0018e7313d
Seems like revision 17554 busted the presubmit scripts, reverting.
...
TEST=None
BUG=None
TBR=joi
Review URL: http://codereview.chromium.org/119122
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17561 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8b40a9b81b
Fix ListRelevantPresubmitFiles().
...
It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
77c4f0f135
Remove SVN-specific function InputApi.FilterTextFiles().
...
Review URL: http://codereview.chromium.org/115923
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
15bdffa063
Make AffectedFile member variables private.
...
Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1e08c00d60
Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().
...
Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
6ebe68a73d
Make the member variable 'protected' in the python sense.
...
Review URL: http://codereview.chromium.org/113899
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e1a524ff00
Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.
...
Review URL: http://codereview.chromium.org/113883
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f3eee5692c
Add a unit test for input_api.change.tags.
...
Review URL: http://codereview.chromium.org/113859
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
9711bbafde
Add InputApi.version so the presubmit script can mark a minimum supported version for instance.
...
BUG=None
R=joi
Review URL: http://codereview.chromium.org/115719
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
dbbeedc691
Factor out SVN-specific methods out of AffectedFile.
...
TEST=New unit tests.
BUG=None
Review URL: http://codereview.chromium.org/113783
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
73e36ed387
Fix AffectedFile.IsDirectory() to use the right path.
...
BUG=gcl commit doesn't show any "svn: 'bleh' is not a working copy" error
R=jam
Review URL: http://codereview.chromium.org/113782
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16781 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0ff1fab804
Add repository root presubmit support.
...
Review URL: http://codereview.chromium.org/115616
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3d23524cb0
Add more presubmit support. Add PRESUBMIT.py to depot_tools.
...
Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1033accb23
Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.
...
Review URL: http://codereview.chromium.org/113337
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago