aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,608 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'f46c20fcee'
${ noResults }
Commit Graph

136 Commits (f46c20fcee6e6a0a7d75788847632cd4ac18e2e9)

Author SHA1 Message Date
recipe-roller 34aa4d98f1 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/82c60d376b779c86f78ce98884fd4f887382e9ec Add better documentation, trigger namedtuple. (dnj@chromium.org)

R=dnj@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2335163004
 9 years ago
martiniss 33061f78a1 Add recipe-roller as an OWNER of recipe modules. 
See https://codereview.chromium.org/2335163004 for why this is needed. The
roller can't land a non-trivial CL with the upstream author's LGTM, because
it's not an OWNER of the recipes in the repo it's rolling into.

Review-Url: https://codereview.chromium.org/2337263002
 9 years ago
recipe-roller 1ce79108a3 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3 Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2336313002
 9 years ago
rmistry ea9e93f28c Skip apply_gerrit rebase when there is a rebase failure. 
Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.

BUG=chromium:645955
BUG=skia:5749

Committed: 9736fe8938
Review-Url: https://codereview.chromium.org/2328313002
 9 years ago
rmistry b940385856 Revert of Skip apply_gerrit rebase when there is a rebase failure (patchset #2 id:20001 of https://codereview.chromium.org/2328313002/ ) 
Reason for revert:
The "git rebase --abort" should only happen when there is a failure during rebase not when it succeeds.

Original issue's description:
> Skip apply_gerrit rebase when there is a rebase failure.
>
> Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
> This causes the checkout to remain in the "rebase in progress" state.
>
>
> BUG=chromium:645955
> BUG=skia:5749
>
> Committed: 9736fe8938

TBR=agable@chromium.org,andybons@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:645955

Review-Url: https://codereview.chromium.org/2331103002
 9 years ago
rmistry 9736fe8938 Skip apply_gerrit rebase when there is a rebase failure. 
Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.

BUG=chromium:645955
BUG=skia:5749

Review-Url: https://codereview.chromium.org/2328313002
 9 years ago
iannucci d1d31d5d41 A bunch more little cleanups in bot_update. 
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2321203003
 9 years ago
kjellander 9abf453c3a WebRTC: Remove references to src/third_party/libjingle/source/talk 
A while back, we removed the last pieces of code in
src/third_party/libjingle/source/talk and it is no longer synced
in Chromium's DEPS file. Clean this up to avoid confusion in the
buildbot recipes.

BUG=webrtc:4256

Review-Url: https://codereview.chromium.org/2325043002
 9 years ago
agable c958da4979 Switch bot_update to use exponential backoff on clone 
R=iannucci@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2324073002
 9 years ago
iannucci 3dd7436899 Remove unused PATCH_TOOL and resulting dead code from bot_update. 
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2328883002
 9 years ago
agable 3454ae85da Reland "Delete lots of svn logic from bot_update" 
This is a reland of 082267a659
which was reverted in 4dcad385f4

BUG=472386

Review-Url: https://codereview.chromium.org/2325513002
 9 years ago
iannucci 0abcd2640a Fix typobug in bot_update.py. 
Extra comma changes type from dict to tuple :(

TBR=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2325763002
 9 years ago
iannucci 16e7f097a7 Remove bogus master/builder/slave parameters from bot_update. 
Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2308193002
 9 years ago
iannucci 990ab1b42c Remove force parameter from bot_update.ensure_checkout. 
This is the simplest change I can make here. The bot_update.py script already
ignores the value of force (and sets it to True in all cases). This is an
expectations-only change.

I'll refactor the content of the bot_update.py script to account for this
removed option in a followup CL as well.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2316323002
 9 years ago
bpastene 4dcad385f4 Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of https://codereview.chromium.org/2280213002/ ) 
Reason for revert:
Everything's purple :(

Original issue's description:
> Delete lots of svn logic from bot_update
>
> R=hinoka@chromium.org
> BUG=472386
>
> Committed: 082267a659

TBR=hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472386

Review-Url: https://codereview.chromium.org/2320653003
 9 years ago
agable 082267a659 Delete lots of svn logic from bot_update 
R=hinoka@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2280213002
 9 years ago
andybons f0b0378318 Remove gerrit_rebase_patch_ref flag from bot_update API 
BUG=612417

Review-Url: https://codereview.chromium.org/2317213002
 9 years ago
agable fbfa601efd Remove svn from gclient recipe module example 
R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002
 9 years ago
iannucci 045d107c23 Remove patch_url from bot_update. 
R=hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2310113003
 9 years ago
iannucci 95f3d317e4 Just disable force to ensure that bot_update really is running everywhere. 
This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.

Removal of the force option (and related options) to come shortly.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2311673002
 9 years ago
tandrii 4cb6fb7fbd bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects. 
R=machenbach@chromium.org,andybons@chromium.org
BUG=602906
TEST=manual run of Angle recipe locally

Review-Url: https://codereview.chromium.org/2299693003
 9 years ago
andybons 6911b06750 Make rebase and sync the default for Gerrit updates. 
BUG=602906
R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility.
Review-Url: https://codereview.chromium.org/2298883002
 9 years ago
agable c8f3a3498e Remove non-trivial SVN config from gclient recipe module 
R=martiniss@google.com
BUG=640251
Recipe-Tryjob-Bypass-Reason: can't mock expectation changes downstream

Review-Url: https://codereview.chromium.org/2285213004
 9 years ago
agable 9741c590a4 Remove defunct SVN-based gclient configs 
The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.

R=hinoka@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2291583003
 9 years ago
agable 7090f652d1 Remove all references to GIT_MODE from depot_tools 
BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003
 9 years ago
hinoka 0b7cf885e0 Remove Deps2Git references from bot_update.py 
BUG=

Review-Url: https://codereview.chromium.org/2283043002
 9 years ago
agable 4b21db06e4 Default gclient's GIT_MODE to True 
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004
 9 years ago
agable 75e7fc2af1 Just use git refs for lkcr and lkgr 
R=iannucci@chromium.org, martiniss@chromium.org
BUG=640251
Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll

Review-Url: https://codereview.chromium.org/2268893004
 9 years ago
rmistry 2250d5b3b0 Add apply_gerrit_ref to bot_update api. 
BUG=skia:5627

Review-Url: https://codereview.chromium.org/2249983004
 9 years ago
phajdan.jr 2cbf79f3c9 git: use new python script to bootstrap git on windows 
BUG=635421, 629679

Recipe-Tryjob-Bypass-Reason: downstream changes expected
Review-Url: https://codereview.chromium.org/2264583002
 9 years ago
tandrii 0c561b329b Cleanup old debugging code. 
TBR=phajdan.jr@chromium.org
BUG=537417

Review-Url: https://codereview.chromium.org/2242123003
 9 years ago
phajdan.jr 7929675b19 Add cipd recipe module to depot_tools 
Copied from dfd62794c4/scripts/slave/recipe_modules/cipd/

It's being moved so that we can use the module in git recipe module in depot_tools. See https://goto.google.com/jmywn for more context.

BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2243773002
 9 years ago
hinoka d2c82a25e8 Bot_update recipe output: Add 'Try Rebasing' to patch failure output 
I still see confusion around patch failures.  This should clearify things.

BUG=

Review-Url: https://codereview.chromium.org/2231953002
 9 years ago
Andrew Bonventre f83fa37b34 Add flag to rebase before gclient sync when applying a Gerrit patch 
BUG=612417

Change-Id: I695bb93afd5ccde2c34b0dfc78989248e9b923e9
 9 years ago
phajdan.jr d755329820 git: fix git cache support 
It's now based on bot_update logic.

BUG=630601

Review-Url: https://codereview.chromium.org/2209383002
 9 years ago
borenet 9d5696da80 Make git recipe api add depot_tools to PATH 
"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002
 9 years ago
machenbach 1278dbd127 Enable testing ICU CLs on chromium trybots 
BUG=631575

Review-Url: https://codereview.chromium.org/2183393002
 9 years ago
tandrii 6da50398be bot_update: improve UX when gclient is not configured. 
Instead of long stacktrace, explain what went wrong.

R=sergiyb@chromium.org,andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175343002
 9 years ago
martiniss 8697dfcf8b Fix bot_update to correctly handle exceptions 
If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Review-Url: https://codereview.chromium.org/2175103002
 9 years ago
nodir 248331450c infra_paths module: swarmbucket config 
add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.

This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.

TBR=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176913002
 9 years ago
nodir b96f2d5b1d Revert of bot_update: fix git dir check (patchset #1 id:1 of https://codereview.chromium.org/2174923002/ ) 
Reason for revert:
this is wrong. if directory is not empty, git clone fails

Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: cdac80c9fb

TBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2173683003
 9 years ago
nodir cdac80c9fb bot_update: fix git dir check 
existance of a dir does not mean it is a git repo. Check .git dir
presence instead.

This is the reason why swarmbucket build.git builds fail.

TBR=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2174923002
 9 years ago
tandrii dc24ee1a99 git recipe_module: add experimental git-cache support. 
BUG=630601
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2173823002
 9 years ago
mikecase 1f2c9b78ae Add config to gclient to pull in Chromedriver test deps. 
BUG=

Review-Url: https://codereview.chromium.org/2166443002
 9 years ago
phajdan.jr 6a33f25283 git: apply a 5 minutes timeout to "ensure git tooling on windows" step 
This covers 99% of successful runs on all builders based on event_mon
data.

BUG=629025

Review-Url: https://codereview.chromium.org/2162143004
 9 years ago
smut ae7ea3167e Revert "Remove all safesync_url functionality from gclient" 
This reverts commit 99a7f80578.
This reverts commit 2697cd19a7.
This reverts commit 8c51b6f148.
This reverts commit d4aedc811b.

Reason for revert:
Breaks iOS release branch builds.

BUG=623762
TBR=agable,maruel

Review URL: https://codereview.chromium.org/2162583004 .
 9 years ago
phajdan.jr 27726869d2 tryserver: make it possible to override cwd for get_files_affected_by_patch 
BUG=584079, 593999

Review-Url: https://codereview.chromium.org/2144473003
 9 years ago
phajdan.jr b2580abf45 Manually roll recipes.cfg recipe_engine 2c5509f:9d78ba3 
TBR=estaab, iannucci, martiniss

BUG=chromium:593999

Review-Url: https://codereview.chromium.org/2132363002
 9 years ago
phajdan.jr 7dba71bfbc remove blink_or_chromium gclient config 
It's not needed after blink merge.

TBR=emso, sergiyb, tandrii

BUG=none

Review-Url: https://codereview.chromium.org/2117063002
 9 years ago
phajdan.jr 4f00aa0b49 infra_paths: keep cache paths super short to avoid long path issues (attempt #2) 
This is a reland of https://codereview.chromium.org/2102613002/ .

See https://goto.google.com/ljfzu (Google-internal) for more context. Summary:
- the only builders with chromium checkout affected by this are on chromium.fyi
- we can't clean up old cache directories before switching to new ones

Also see https://goto.google.com/oyxwm why so short directory names are OK.
Similarly https://codereview.chromium.org/2061213002 .

BUG=623575

Review-Url: https://codereview.chromium.org/2102403002
 9 years ago