Commit Graph

4 Commits (e7695c5e4b9a0e151d1dd795435f279270065598)

Author SHA1 Message Date
Oliver Newman 4b2a96e76c Remove PYTHON_VERSION_COMPATIBILITY from cipd example
This test's expectation files include exception strings, which differ
between py2 and py3. This didn't actually break the tests in the past
because one of the cipd module's transitive dependencies,
`recipe_engine/proto`, was not py3-compatible, so the test results were
ignored.

However, I'm working on making `recipe_engine/proto` py3-compatible, and
now that it is compatible, these test failures are considered fatal. See
https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket/8837185422185352433/+/u/train_recipes_at_upstream_CL/stdout

I imagine the exception-formatting issue will eventually by fixed in the
recipe engine, but until that happens these tests can't be considered
py3-compatible.

Bug: 1227140
Change-Id: I75b2b9c0090f418cb412d497e914a30155c2b12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3140151
Auto-Submit: Oliver Newman <olivernewman@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>
4 years ago
Gavin Mak 094e3dd2cd Add PYTHON_VERSION_COMPATIBILITY to cipd recipe module
Bug: 1227140
Change-Id: Ic7eb822cc04b95322ff87ad8d871c8620c6b94ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3123751
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
Chong Gu 473499ba26 [cipd] Add verification-timeout as a passable flag
For Fuchsia official builders, we need a way to increase
the verification timeout so that our packages are uploaded
successfully

Bug:1215771
Change-Id: Ie59dc149e2b88864afea1aaf6700a94324593196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2973226
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Robert Iannucci 56038f517d rename example.py -> examples/full.py for all modules
R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org

Bug:
Change-Id: I47d8f9311b6ee71583fb989888a1e4d28b5495df
Reviewed-on: https://chromium-review.googlesource.com/520731
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago