Commit Graph

2 Commits (e6f40ea0341552c3e78fb107fe9f37b87d95f321)

Author SHA1 Message Date
Alex Gough 1c7dec337d [windows_sdk] Use correct path within cipd package
Previous CL[0] had the paths inside the SDK wrong so did not
correctly find the SetEnv.x64.json files in recent cipd packaged
SDKs. The 'win_sdk' portion was not necessary.

Downloading the cipd packages and verifies the old and new paths:

gci . -File -Recurse | Where-Object {$_.Name -match 'SetEnv.x64.json'}

CPID-----------------\
C:\src\dt\tmp\new-sdk\ Windows Kits\10\bin\SetEnv.x64.json
C:\src\dt\tmp\old-sdk\ win_sdk\bin\SetEnv.x64.json

[0] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800

R=iannucci@chromium.org

Bug: 1250098
Change-Id: I579fd288824ca9014176b7b1c221affd966fb953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3290913
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
4 years ago
Robert Iannucci 2efe3d74ba [windows_sdk] Make sdk json-finding more flexible.
R=ajgo@google.com

Bug: 1250098
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Change-Id: I0a65193ed3c880ecfabef222ca85ea77bc3a75da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Alex Gough <ajgo@google.com>
4 years ago