This is necessary for msysgit usage on windows.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7858008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100267 0039d316-1c4b-4281-b951-d872f2087c98
It result in less code, forces uploading the change for eventual review and most
importantly enables the commit queue to correctly handle this.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7253015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98
It was broken in 88979. Someone my limited testing missed that.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7147016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88987 0039d316-1c4b-4281-b951-d872f2087c98
Properly load --contributor value or use the git config user.email value.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7134097
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88979 0039d316-1c4b-4281-b951-d872f2087c98
presubmit_support.py can now creates a Rietveld object on its own.
This is necessary since the object needs to be recreated out of process. The
commit queue runs the presubmit check out of process for sanity reasons.
Added TODO to push the cookie instead of the password.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7058054
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87842 0039d316-1c4b-4281-b951-d872f2087c98
The regression was introduced in r87253.
TBR=dpranke@chromium.org
BUG=
TEST=
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87550 0039d316-1c4b-4281-b951-d872f2087c98
Add "git cl set_commit" command to set the flag more easily.
Add --commit to "git cl upload" to streamline workflow even more.
Continue conversion to Rietveld object.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7084037
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87253 0039d316-1c4b-4281-b951-d872f2087c98
Exposes InputApi.rietveld and deprecate host_url.
This is useful since it places authentication at a single place.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6825008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98
Add propagation of verbose flag from git cl to presubmit_support
Rename NotImplementedException to standard NotImplementError.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80798 0039d316-1c4b-4281-b951-d872f2087c98
Also fix a few issues found along the way.
Tests had regressed a lot. Add a lot of tweaks to make most test pass.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6792060
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise I get useless stack traces and the user too.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6794020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80338 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise tree status with non-ascii characters could throw at the console.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6788013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80173 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=Poor mac users should be able to use git-cl back again.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79932 0039d316-1c4b-4281-b951-d872f2087c98
This make possible to apply private issues or rietveld instances requiring
authentication.
Forces simplejson to be installed or uses python 2.6's json
Make local_rietveld.py usable standalone.
R=dpranke@chromium.org
TEST=unit tests + manual testing, owners.sh is currentl broken, unrelated to this change.
BUG=none
Review URL: http://codereview.chromium.org/6721031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79734 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
bauerb@chromium.org
dpranke@chromium.org