Commit Graph

7075 Commits (dcb5c85b51e16adb791aa86a6c9a226e6927a241)
 

Author SHA1 Message Date
recipe-roller f828cf36a3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/5334991eef8485e2a14914bc48e7fb7f726a8bd5 (nodir@chromium.org)
    [resultdb] Add resultdb.wrap function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb64c21de58007abf723a04c13eb2e5b8bbcdfe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181728
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 9e99f7c84e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/ebf006f6230e66be4733d74b31303e6102409944 (nodir@chromium.org)
    [resultdb] Use rdb-rpc to update inclusions

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic0856263d388c2c00ec6f0b410cd3801cc16802e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181643
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Nodir Turakulov 0f47d332f1 [resultdb] Add rdb and rdb.bat
This should have been a part of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176997

R=estaab@chromium.org

Change-Id: Ia362b562c9818ab759a793aeafd8fda221c86ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2177172
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
5 years ago
recipe-roller 082a11aa49 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/7f9177b9d1ab75e6a51176e7b227b7f85bcb9433 (nodir@chromium.org)
    [resultdb] Call `rdb-rpc`

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I138fdcd710ee431d9d9d8fe6f19c851cc6ce3cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2177283
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Nodir Turakulov 70631f9a81 [resultdb] Add rdb to depot_tools
Deploy rdb in depot_tools. It can be used to stream local test results
and query results from the server.

Change-Id: Ic2fe65952d24b79edd98bedb678ee220b165fef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176997
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
5 years ago
recipe-roller 4eadc54109 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/7fb8c48fa4af6fe1ceb0c885c8489967072b674a (iannucci@chromium.org)
    [autoroller] Update doc on tbr_emails field.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2a7fb3b4cc2c8ab3273f15797ab4e24b8919e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176682
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller ebb382b4f0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/da3e215ac8da2fa8aec935f69415d88c669ab117 (chanli@chromium.org)
    [ResultDB] Add is_enabled function to resultdb recipe_module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I702106fb7d12bc05d56c45b45e78df4b8e997180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176310
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Anthony Polito 177e70c03e update yapf to 0.27.0
Bug: 1074167
Change-Id: I9f0c1c8a1fa76d6bf2899000fd0b3665f7bf0994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174818
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
5 years ago
recipe-roller 634b6b8a57 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/db2f179387abaf196eb8221f376a2174663a4d28 (olivernewman@google.com)
    [buildbucket] Add fields arg to get()

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibeb5ed96b7db5b8be4e988519f6cc67b5db5ee48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176038
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 37518fb2ef Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/53ed08a539ff9e24188417136109b8cac0f8b47e (chanli@chromium.org)
    [ResultDB] Add link to ResultDB concepts doc

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I10ef0ade65b087e10e51d4a46d54ec65a571de9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174863
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller fdd2e3d34e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/1b1574d044a7f44430825aa929cdc5b4fe17ab7b (erikchen@chromium.org)
    Update user guide.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8aa0e687647a484b4bf08eb4928b10fb94de666a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173836
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Bruce Dawson 3e87ceaf33 Allow a space after __except
__except () is the canonical layout for code that uses __try/__except,
Microsoft's structured exception handling. The majority of __except
uses in our code use a space after the keyword. However cpplint.py
thinks that __except is a function name. Apparently we have been forcing
this through by ignoring the presubmits. This just adds __except to the
list of exceptions to the whitespace/parens rule.

Change-Id: I2384cd32f26e3aa6a4b0150451a9a61147483e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173644
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
5 years ago
Yoshisato Yanagisawa 2072ffc0a6 Roll out new goma client binary VERSION=198
b398f18fab

Bug: b/153832839
Change-Id: I24a4e8b5df26b2aa0d3bbec79987385993ca2c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174069
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
5 years ago
recipe-roller a150931117 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/d937e9525fff04f0a92f9ef1e41ceb0e985ecf7b (chanli@chromium.org)
    Mock resultdb info in buildbucket test_api

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib72d02dc1dfab2535b076fa672fa7f983f887fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171992
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 1c6ae9e0d9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/e9ccc9dd63ce31ec535c7b4b69d1f15618bf4d78 (olivernewman@google.com)
    [swarming] Fix typos and pylint errors

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54fe12f43ec6ff07dd26b36d1582766337e6687a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172340
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller f2b5e1d58c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/1ec8faaaa559d4876f9c9c009a1be564286a8bba (olivernewman@google.com)
    [swarming] Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6801c67e3c1ff66128144eb064012d407143c09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172337
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Josip Sokcevic d24ae26520 Remove curl verbose printing
R=apolito@google.com, ehmaldonado@chromium.org

Change-Id: Ie453bb95208561a09a5f1f62cb9543e31cbe031f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171923
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Josip Sokcevic 350a913fad Terminate stale bot_update process
Introduce a process observer that terminates child process if there is
not stdout activity. It can be overridden by an environment variable.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: I11de9d29e716587614cf336725c8d4a368a9d61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167220
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Edward Lesmes b806e17eb2 git-drover: Don't attempt to decode output of check_call.
When interactive is true, check_call is used instead of check_output,
and check_call doesn't return the command output.

Bug: 1074357
Change-Id: Ib9e761d41d754df58c9ee1f897dde173ce4d9eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2170805
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Josip Sokcevic d70aa16fd5 Reland "Print ps in intervals while the process is running"
This is a reland of 50c6d8d348

Original change's description:
> Print ps in intervals while the process is running
>
> R=apolito@google.com, ehmaldonado@chromium.org
>
> Bug: 1074355
> Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: I488b521e4a3b859c37f0bb1e21cad7d037f8f97e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169392
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Josip Sokcevic 7d66c798bb Revert "Print ps in intervals while the process is running"
This reverts commit 50c6d8d348.

Reason for revert: self argument missing

Original change's description:
> Print ps in intervals while the process is running
> 
> R=​apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1074355
> Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I3c90576d0c6403f0d2f9119876a400c1380a8e14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1074355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169391
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
recipe-roller 3d10b7646b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/3809ffa82d6bc08da66eae89bc87cdbe5c5b5905 (olivernewman@google.com)
    [swarming] Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9dd8ee949024310a048cddad2abec07f1c43288e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168955
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Takuto Ikuta 26b02c109b Revert "git_cl: add --parallel for yapf"
This reverts commit 8533236d09.

Reason for revert:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086/4#message-dcd4603d5914c681d0e1ad498e7bb9b59576a24d

Original change's description:
> git_cl: add --parallel for yapf
> 
> see
> https://github.com/google/yapf#usage
> 
> Bug: 1073708
> Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1073708
Change-Id: Ib8245dca57a11a386e78089630df61ff773b1789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168971
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
5 years ago
Edward Lesmes 259d6bb191 git-cl: Remove formatting support for dart.
The support for Dart in canned_checks.CheckPatchFormatted can be removed.
It was used in Chromium, when Chromium included a Dart SDK in its
checkout.
Dart was removed from Chromium years ago, and none of the current Dart
repositories use this in their presubmit.

Current repositories using Dart and depot_tools are
dart.googlesource.com/sdk and Flutter engine.
The SDK source tree has extensive custom code written for format checking
in the presubmit, and Flutter engine has none.
So adapting the exiting code to work with a new SDK location, or
searching the path for any Dart SDK (which would be too fragile) would
not be useful for these projects.

The support code was introduced in:
https://codereview.chromium.org/933383002

Bug: 1075502
Change-Id: I1ceed1ed6c1b4ff05071b0db1c52016f03c47c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168851
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Josip Sokcevic 50c6d8d348 Print ps in intervals while the process is running
R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
recipe-roller a57cf48d52 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a1f700042dd072e39d521f74c71bea4f488282eb (yiwzhang@google.com)
    [warning] add user guide for warning feature in recipe engine

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia1c601b76b74c87f1543c965c2474a8b469fec22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167224
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 7a5b03ad4a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/d305b98624bda32f20b4b4a25499f3e8464a3868 (olivernewman@google.com)
    [swarming] Add `verbose` argument to collect()

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c44602b3cd09aaeaa93fb4b2572d6562959d1e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166819
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller dd2f620cce Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/1362e821b88409d2bde0c95b65813f9f5daf701a (iannucci@chromium.org)
    [pywin32] Remove pywin32 dependency completely.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib3a65fb390502e380df7d15ab3bd0dc254571f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166148
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 6cdd21a66c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/3a620b0ada4e8b3aa6c436828d94cdaf0eef3086 (olivernewman@google.com)
    [swarming] Pass -verbose to collect

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifac46fbe076199cf5569c69a95936d03ee0d4173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2165419
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Josip Sokcevic 5e18b605d3 Fix git cl upload on Windows
Use ISO8601 time format standard to avoid localized result and need to
encode.

R=ehmaldonado@chromium.org

Bug: 1074002
Change-Id: I95c2ddd55a9661351f2b45601f7bba24c2951c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163401
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Fletcher Woodruff 11b341547a cpplint: move a build/include check to subcategory
There is a cpplint include check that ensures that all includes have a
directory name preceding them. However, if all source lives in the root
of a repository, there is no point in having a directory.

Because this check lives under 'build/include', it's impossible to
filter without filtering other useful checks.

Move it to 'build/include_directory' so it can be more easily filtered.

BUG=chromium:1073191
TEST=cros lint on a file with 'filter=-build/include_directory' in
     CPPLINT.cfg

Change-Id: Ie15fb2398a6d0297ef96219e67076ea262abf853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159690
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Fletcher Woodruff <fletcherw@chromium.org>
5 years ago
Takuto Ikuta 8533236d09 git_cl: add --parallel for yapf
see
https://github.com/google/yapf#usage

Bug: 1073708
Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Takuto Ikuta adbef02c2c yapf: support --parallel flag
see
https://github.com/google/yapf#usage

Bug: 1073708
Change-Id: I3824bbecc6c52d6b7f82aaa05e5108a8619124d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162227
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
5 years ago
recipe-roller a676816357 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/fed4eae33606a63ad477a80c895e965bb929f69e (yiwzhang@google.com)
    [luciexe] Fix the issue where build status is not properly updated

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b32a1dae9a51bb9b68078f1dc893abedef7f806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163198
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Josip Sokcevic 72f991f760 Fix printing error on git-rebase failure
Reverted commit 4511b131e6 had a bug where
squash_ret.success = True and empty_rebase = False. In that case, stdout
and stderr would already be string and trying to decode would fail.

Bug: 1071280
Change-Id: Iadcc526147ebb98aa7a91a7daa64ef44066e83b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163387
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Bruce Dawson 7a0b07a8a5 Fix slash direction sensitivity in git cl owners
Slashes and backslashes are interchangeable on Windows in many contexts.
But not all. In particular, if you add a path to a dictionary and then
try looking it up with an equivalent path that has different slashes
then - not surprisingly - the lookup will fail. Therefore it is
important to always use slashes when populating _paths_to_owners. This
is now done, and documented.

Additionally, while fnmatch.fnmatch handles comparing slash separated
paths to backslash separated paths, fnmatch.translate does not. This is
arguably a bug in fnmatch.translate, or at least something that should
be documented. This bug is worked around by having _fnmatch sanitize
file names to always use slashes, and asserting that the patterns do
not contain backslashes.

With these changes this command:
  git cl owners --ignore-current --show-all chrome/browser/BUILD.gn
now correctly gives the same results as this command on Windows:
  git cl owners --ignore-current --show-all chrome\browser\BUILD.gn

The modified test fails without the other changes, passes with them.

Bug: 1009104
Change-Id: I416c7131281f00e352c1d2b85c30fcc463417fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915410
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
recipe-roller 0f15c2729b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/ac4b520aa1f7a8cec925349bc7cf6c3a2d0fb78c (olivernewman@google.com)
    [swarming] Add eager argument to collect()

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida26f1bd4a50d28e95bd989b15cb19de6fc40828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163186
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Wez fef5cf8e22 Revert "Fix printing error on git-rebase failure"
This reverts commit 4511b131e6.

Reason for revert: Broke git_rebase_update.py under Python3, which does
not support calling decode() on string objects.

Original change's description:
> Fix printing error on git-rebase failure
> 
> R=​ehmaldonado@chromium.org
> 
> Bug: 1071280
> Change-Id: I8b1f00bb7c454297b10d5e047ae35c2686f69fb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2155154
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071280, 1073768
Change-Id: I58c1b24ba2aef255068c81be25475b2abbbf4fcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161111
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
5 years ago
recipe-roller f12989fa6c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/3559ca4d7586d19e6e3d548a5708b32d64a3c08a (mseaborn@google.com)
    [swarming] Sort dictionary keys when constructing swarming request

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe9775200beaaa743fc7bc03bb88032ce3f490f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162145
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 8ab41801a6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/36f4d31f57f0ab3d5e6925a724dced97cc3eeac2 (mseaborn@google.com)
    [file][json] Sort dictionary keys when writing JSON data

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I27f2d22bf8f032256adcbed9f60b10c5c3320ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161902
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Josip Sokcevic c621315d17 Make Python 3 default on Windows
Users can still set GCLIENT_PY3=0 to use Python 2.

R=ehmaldonado@chromium.org

Change-Id: Ic7657a091bfe3b9c426ab36063b106aadf2d1c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161266
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Allen Bauer 64c1faf0fb Fix goma_auth.bat to use nul instead of null.
Change-Id: I30284634b2c5bdf1d155fe2f8d6f72538c9e2f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161634
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
5 years ago
recipe-roller 88e690c833 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/9c7dd835e208fa6268d7c06f0ba15823b257b4bb (iannucci@chromium.org)
    [vpython] Bump version of pywin32 to 227.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0afd28e145f05ecae5c87332e4807fe7bbc7e0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161270
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Iannucci bffd63b243 [cipd] Take cipd.ps1 out of %PATH%.
Having it in %PATH% means that powershell users will accidentally
run 'cipd.ps1' when they should be running 'cipd.bat'; This would
cause them to get requests for input parameters (like the backend URL)
which they have no idea how to supply.

R=agable@chromium.org, nodir@chromium.org, vadimsh@google.com

Bug: 1073529
Change-Id: I62a3bd9e00229a2047293dba1ba480d28f77bf63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161645
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
5 years ago
recipe-roller 4a39f37e48 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/096f05fa40b6864c8d22e6df8e154e43d7c778c6 (jsca@google.com)
    Add milo recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c91f04e85e69605beb6df1a5da91e33041f48a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160407
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 8bd9179c42 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/940d2483cca29dba541c42f1bdb6d33745269e97 (yekuang@google.com)
    Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia332e0d33da35942374efdd379dd2bd9eba361c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160214
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Dale Curtis 0e7788d16b Skip sources downloaded by WinDbg when checking toolchain status.
This avoids the toolchain being wiped after using WinDbg.

Bug: None
Change-Id: I989ef7744b46254bab4c5a707724dc38a9b9a548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159998
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
5 years ago
recipe-roller 1e113e605b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/19949b53d1682935c77c39354dd6b3b0056bdd24 (chanli@chromium.org)
    [Resultdb] Add function `exonerate` in resultdb recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefe2a6f510e5be4c84a6515b0afffdc2b7a559ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159697
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Anthony Polito b009c0643f revert git to 2.24.1
Bug: 1070694, b/154543469
Change-Id: I5099e3bb8c1aa9d3003d82e7dbb545fc75a1f749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157801
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
recipe-roller 062833f387 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/05e3d21945daf81423e55c5eb908d1782c133873 (iannucci@chromium.org)
    Add led job.proto and update all luci-go protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I90b91a5b8019dd8c57ff7bdfbb3897f1d5ecd180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157797
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago