Commit Graph

18 Commits (d6d15b8e29d85f898388d521b919231df278df54)

Author SHA1 Message Date
djacques@chromium.org d9c6d995fd Fix gsutil execution on Windows.
5498b95831 runs gsutil using 'os.execv',
which, on Windows, apparently causes it to return before completion.

Also add verbosity to '7z' failures on toolchain downloading.

BUG=chromium:445425
TEST=bot
  - Ran on bot, this fix solves the problem that we were seeing.

R=pgervais@chromium.org, sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/828463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293507 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
scottmg@chromium.org c60ecf9e04 Update toolchain script to package SDK 8.1 instead of 8.0
See also https://codereview.chromium.org/720033003/

BUG=311488,432748

Review URL: https://codereview.chromium.org/719343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292950 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
scottmg@chromium.org b8e529fae4 Revert 284349 "Add winrt to the INCLUDE directories of the toolc..."
Sorry, I screwed up. This breaks Express-only per skia:2781. I'll reland it before I push the next VS update.

> Add winrt to the INCLUDE directories of the toolchain bundler.
> 
> The motivation is that vcvarsall sets it, and that it might make it possible to
> land https://codereview.chromium.org/405723002/ one day.
> 
> BUG=395405
> TBR=jochen
> 
> Review URL: https://codereview.chromium.org/393233004

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/424813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285924 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
thakis@chromium.org a7f26ee0af Add winrt to the INCLUDE directories of the toolchain bundler.
The motivation is that vcvarsall sets it, and that it might make it possible to
land https://codereview.chromium.org/405723002/ one day.

BUG=395405
TBR=jochen

Review URL: https://codereview.chromium.org/393233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@284349 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 0d23d776e8 Move Googlers to gs:// based toolchain pull
The gs:// download path is much faster. Move anyone who could have
access to gs://chrome-wintoolchain/ over to that for less pain.

The downside is that we have to prompt them to run
download_from_google_storage --config which people are going to
complain about, but I think this is a better experience overall.

R=iannucci@chromium.org,hinoka@chromium.org
BUG=349964

Review URL: https://codereview.chromium.org/191373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255696 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 454f2ca9ed CHROME_HEADLESS is always Pro
Follow up to https://codereview.chromium.org/185423004/

The unzip is always Pro, and without setting this the data.json will
be getting the Express settings and so gyp will generate the wrong
project.

TBR=iannucci@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/188673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255378 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
viettrungluu@chromium.org 5b9f90e592 Make toolchain2013.py work properly if there's a space in the temp path.
TBR=maruel@chromium.org
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/184103027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254932 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 71756329cb Add toolchain simple mirror option used for bots
I tried a git-ish tree/blob model, but way too slow for a ton of files.
This maps easily on to the current way the tree is mapped, saves
temp space on bots (because the full isos aren't downloaded), and is
a lot faster too. It means we can pull old revisions too now.

TBR=iannucci@chromium.org
BUG=348350

Review URL: https://codereview.chromium.org/185423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254421 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 4a56efe4a5 Add some missing parts from MFC to toolchain
TBR=iannucci@chromium.org
BUG=345993

Review URL: https://codereview.chromium.org/169053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252757 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 360f032356 Move data.json to win_toolchain to its abs paths aren't hashed
TBR=iannucci@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/173523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252737 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 5d17b921db Move toolchain update control into src, but keep download logic in depot_tools
Moves the update functionality out of update_depot_tools into src/ in https://codereview.chromium.org/175573004 .

get_toolchain_if_required.py now expects a list of hashes on the
command line, and makes sure that it gets one of those.

toolchain2013.py saves a .json which contains information relevant to the
interests of the caller, so that it can set up the parent environment. This
is returned via the --output-json command line argument to get_...py

R=iannucci@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/168603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252725 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 40167ed584 win_toolchain: Add DIA SDK to extracted pieces
The goal of this change is to include the DIA SDK (and strip out
a bit extra that was unnecessary).

Unfortunately, the msi that includes the DIA SDK includes a file with an
extraordinarily long path, 241 characters long. When prepended with
"C:\Program Files (x86)\" it extracts OK, however, when we extract to
%TEMP% it's not hard for it to exceed _MAX_PATH and have the msi tool
fail. So, when extracting MSIs, also do the equivalent of
"subst X: temp_dir" and use X:\ as the path given to msiexec. (sigh)

R=maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/150333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251085 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 26cb836b5b Support VS2013 Express for automatic toolchain too
And for now, defaults to Express.

Main changes:
- Valid hash becomes a set of hashes one for Pro, one for Express
- Include WDK to get an old copy of ATL as that doesn't come
  with Express

BUG=323300
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/148453008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248622 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 22b2ec72a9 Use sys.exit rather than raise SystemExit
TBR=iannucci@chromium.org
R=iannucci@google.com

Review URL: https://codereview.chromium.org/148523009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247469 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 7923129658 Pull toolchain isos from gs:// when on bots
VS2013 isos are mirrored to gs://chrome-wintoolchain/ (which is googler-
only accessible). This is used to isolate bots from external dependency
as detected by CHROME_HEADLESS=1 in the environment.

TBR=iannucci@chromium.org
R=hinoka@chromium.org
BUG=324987

Review URL: https://codereview.chromium.org/148613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247398 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org dfaf79d831 win: Add windbg and command line debuggers to automatic toolchain
R=maruel@chromium.org, jochen@chromium.org
BUG=321187

Review URL: https://codereview.chromium.org/137613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245311 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
thakis@chromium.org 9eabb22cc8 Fix presubmit errors in toolchain2013, so that cq works for depot_tools.
No functionality change.

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/136793018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245073 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 7cc7a1c5dc Automatic Windows toolchain
Per comments in linked bug, this is simply moved from chromium. The
only new thing is hooking it into update_depot_tools.bat, and
updating a few paths in the scripts.

This is currently opt-in via "set DEPOT_TOOLS_WIN_TOOLCHAIN=1" but
that will be removed once it's ready for deployment.

R=iannucci@chromium.org, maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/135933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244983 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago