This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org)
R=phajdan.jr@chromium.org
Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/454341
Commit-Queue: <recipe-roller@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
BUG=635641
Change-Id: Ibfeda2ab32d10a8a4e229a428a846ce9809e8dcd
Reviewed-on: https://chromium-review.googlesource.com/444094
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Currently if path_config is not specified, infra_paths
defaults to buildbot paths. We want to make this behavior explicit,
so we don't have to introduce a new "luci" path configuration which
tells infra_paths module to do nothing.
Buildbot now specifies path_config=buildbot since
https://chromium-review.googlesource.com/c/412029/ ,
so now we can remove this default.
This also affects all expectation files because this CL switches
the default path configuration from Buildbot to LUCI.
In particular, it changes default git cache dir from [GIT_CACHE]
to [CACHE]/git.
Also code paths that work only in Buildbot environment has to
have a test with path_config=buildbot.
R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586
Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae
Reviewed-on: https://chromium-review.googlesource.com/411989
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reason for revert:
Pointing to the wrong file :(
Original issue's description:
> bot_update: add --auth-refresh-token-json passthrough for apply_issue
>
> BUG=642150
>
> Committed: e465667e78
TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642150
Review-Url: https://codereview.chromium.org/2350363003
Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.
Original issue's description:
> bot_update: ensure correct depot_tools checkout is used.
>
> R=vadimsh@chromium.org,martiniss@chromium.org
> BUG=635641,647446
>
> Committed: 972ac50401
TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446
Review-Url: https://codereview.chromium.org/2349673002
This is the simplest change I can make here. The bot_update.py script already
ignores the value of force (and sets it to True in all cases). This is an
expectations-only change.
I'll refactor the content of the bot_update.py script to account for this
removed option in a followup CL as well.
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2316323002
This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.
Removal of the force option (and related options) to come shortly.
R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2311673002
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org)
R=phajdan.jr@chromium.org
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1926633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
Removes deprecated patch_project_roots in bot_update,
and the TODOs used for migration.
Depends: https://codereview.chromium.org/1913863002
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1920933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300153 0039d316-1c4b-4281-b951-d872f2087c98
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.
This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1917433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
Avoid to call git reset --soft to preserve current revision to
FETCH_HEAD. 'got_revision' property would also be that from
FETCH_HEAD.
BUG=596787
Review URL: https://codereview.chromium.org/1837453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299721 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
I believe this breaks trybot patching on Windows.
Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811
Error:
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command,
operable program or batch file.
I'm speculatively reverting.
Original issue's description:
> bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
>
> BUG=437264
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556
TBR=jochen@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437264
Review URL: https://codereview.chromium.org/1662763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298561 0039d316-1c4b-4281-b951-d872f2087c98
recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist.
R=martiniss@chromium.org,luqui@chromium.org
TBR=iannucci@chromium.org
BUG=582280
Review URL: https://codereview.chromium.org/1660163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98
recipe-roller
Ryan Tseng
Nodir Turakulov
tandrii
iannucci
andybons
agable
rmistry
phajdan.jr
martiniss@chromium.org
yyanagisawa@chromium.org
szager@chromium.org
hinoka@chromium.org
kjellander@chromium.org