Commit Graph

6 Commits (cc11b065c54bae31b125f8ee0431cf9a08b1fe4f)

Author SHA1 Message Date
szager@chromium.org a7d7d7ec35 Explicitly exec hooks inside a shell.
We don't want to permit the execution of an arbitrary binary.

TBR=ilevy@chromium.org
BUG=

Review URL: https://codereview.chromium.org/21012004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214193 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
raphael.kubo.da.costa@intel.com 233fb7d050 The scripts are simple enough and should work fine under any POSIX shell,
which is particularly helpful when one is using `gclient sync' on a platform
that does not have /bin/bash (ie. it's installed in another location or not
present at all), since the hooks are automatically added to the git
checkouts.

While here, just `exec' the scripts directly instead of invoking another
shell by hand and remove the redundant `exit 0' lines.

R=cmp@chromium.org,dpranke@chromium.org,szager@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19278004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214181 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
ilevy@chromium.org 08218ed6c4 Revert 214177 "Use plain sh instead of bash in the git template ..."
> Use plain sh instead of bash in the git template hooks.
> 
> The scripts are simple enough and should work fine under any POSIX shell,
> which is particularly helpful when one is using `gclient sync' on a platform
> that does not have /bin/bash (ie. it's installed in another location or not
> present at all), since the hooks are automatically added to the git
> checkouts.
> 
> While here, just `exec' the scripts directly instead of invoking another
> shell by hand and remove the redundant `exit 0' lines.
> 
> R=cmp@chromium.org,dpranke@chromium.org,szager@chromium.org

TBR=raphael.kubo.da.costa@intel.com

Review URL: https://codereview.chromium.org/21066002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214178 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
raphael.kubo.da.costa@intel.com 2666f735b1 Use plain sh instead of bash in the git template hooks.
The scripts are simple enough and should work fine under any POSIX shell,
which is particularly helpful when one is using `gclient sync' on a platform
that does not have /bin/bash (ie. it's installed in another location or not
present at all), since the hooks are automatically added to the git
checkouts.

While here, just `exec' the scripts directly instead of invoking another
shell by hand and remove the redundant `exit 0' lines.

R=cmp@chromium.org,dpranke@chromium.org,szager@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214177 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org ecb7542302 Get rid of place-holder for commit-msg hook.
This caused problems for repo-based projects that need to install the
standard Change-Id commit-msg hook.

With the commit-msg hook gone, we can also reinstate the --template
argument to 'git clone'.

BUG=235215
R=iannucci@chromium.org, ilevy@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/18083033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@211464 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org 9aca104a0f git template files for chromium checkouts.
To be used in conjunction with the --template argument to git-clone.

The hooks all redirect to build/git-hooks, which are files under
revision control.  This allows us to version the hooks along with
the source code.

TBR=mmoss@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11689005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174738 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago