https://crrev.com/c/6796221 added a gsutil_urls output property that
provides the URLs of uploads to Google storage that were performed by
the build. It attempts to accumulate the URLs by updating a dictionary
on the result object's properties, but the properties on a step's
results object is empty when created, so it was just overriding the
property each time with a single element dict. This change keeps the
dict on the API object and updates it when an upload is performed so
that the final value includes all of the URLs produced by the build.
Change-Id: I6681ca7c137969cbef58e09ce24d0605155d2c3e
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_internal
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6880970
Commit-Queue: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Python3 is used by default in recipes now and this annotation is not
necessary anymore.
Bug: 440235171
Change-Id: Ifdf357129c9e42fee3752ac1c07aa6e94171d81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6875483
Commit-Queue: Scott Lee <ddoman@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
This reverts commit 778a576e20.
Reason for revert: This broke `git cl upload` for at least two people.
Bug: b/438584121
Original change's description:
> Roll git-credential-luci: enable ReAuth by default
>
> This CL is potentially disruptive. If things break, please revert
> this CL and reach out to CL authors.
>
> Bug: b/438584121
> Change-Id: Ib5c493e1b89cdcfe065fcf096d9344da915d5da8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6865736
> Reviewed-by: Chenlin Fan <fancl@chromium.org>
> Commit-Queue: Jiewei Qian <qjw@chromium.org>
Bug: b/438584121
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Idf2a4f31df88ab0b4fcbd5babf1894a8f9fa4cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6871713
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Adam Rice <ricea@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
This change moves the IsEnvCog() check directly into the
IsDownloadNeeded() method. This makes IsDownloadNeeded() the single
source of truth for determining if a GCS download should proceed,
thereby simplifying the logic and removing the redundant check at the
call site. Also fixed the presubmit issue in cog.
Bug: 363232952
Change-Id: Id2d57bc7290999551410c1545012bf7425f1fd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6868730
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Jie Sheng <jiesheng@google.com>
This CL is potentially disruptive. If things break, please revert
this CL and reach out to CL authors.
Bug: b/438584121
Change-Id: Ib5c493e1b89cdcfe065fcf096d9344da915d5da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6865736
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Per the Git credential helper protocol, the credential helpers should
read stdin for attributes. Previously, we didn't implement the
attributes for git-credential-luci, so this wasn't an issue, but
we're (going to) use the attributes now, and if we don't explicitly
send or close stdin, the helper will hang
Bug: 411487838
Change-Id: I80d47c31e597187c05d5fc23438ae8a52147cb9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6868130
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Allen Li <ayatane@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Add entrypoints to luci-auth-ssh-* executables to fetch cipd packages
then run the binary.
Bug:b/435528916
Change-Id: Ic39b104d0ade8a65950fbbb755fa21c0b6514bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6864760
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
In https://crrev.com/c/6697693, presubmit's canned formatting checks
started looking at *.star files. This included enforcing a max line
length of 80 chars in such files.
Most (all?) *.star files found in gclient-managed repos are lucicfg
client repos, which generally have their own formatter and use 4-space
indents. This can lead to some friction with presubmit's 80 char limit.
So this uncaps that limit for all *.star files.
Bug: None
Change-Id: Ice68676c5d097d7951e83cf81ca9ac8adc8151ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6862147
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
This CL adds a --list-devices for luci-auth-fido2-plugin to print
information about detected FIDO2 devices, then exit itself.
This is useful for debugging udev / permission issues on Linux.
Bug:b/433851494
Change-Id: I4db7e6a56b99e077d4128c74f49d02829b667d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6850350
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
This reverts commit eb60ab38de.
Reason for revert: re-landing with an additional patch
-------------
* Problem
Browser infra runs ci.*-presubmit builders, such as linux-presubmit,
with --all to ensure that the entire chromium/src passes
presubmit checks.
crrev.com/c/6842238 changed the finding type for License Check
from warning to error, but the CI presubmit builders failed because
there are many files without valid CopyRight.
Not only the existing files, all the new files that are added with
`Bypass-Check-License: <reason> footer could also cause the presubmit
builder to fail.
* This CL
In addition to the original patch from crrev.com/c/6842238,
this CL makes additional patches to turn the CopyRight errors into
warnings, if --file or --all is given.
The same approach is used in
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_canned_checks.py;l=982-987;drc=eb60ab38deeda6975c9b0fef883978f2a9f69120
Bug: 435696543,40237859
Original change's description:
> Revert "presubmit: emit errors instead of warnings for bad copyright headers"
>
> This reverts commit fa62515ecb.
>
> Reason for revert: it seems that the existing files without valid copyright headers are causing linux-presubmit builds to fail. b/438791294
>
> Bug: 435696543,40237859
> Original change's description:
> > presubmit: emit errors instead of warnings for bad copyright headers
> >
> > This is an effective revert of https://crrev.com/c/4895337 with
> > additional patches to support a footer.
> >
> > https://crrev.com/c/3887721 updated CheckLicense() to emit errors
> > for bad copyright headers. However, https://crrev.com/c/4895337
> > was changed the finding type from error to warning, claiming that
> > the check is N/A for moved third files, but it's not so easy
> > to programatiically distinguish moved third-party files.
> >
> > After discussions, it was decided to change the finding type back
> > to error to prevent accidental submissions for new files without
> > correct CopyRight headers.
> >
> > To mitigate moved, third-party files, this CL adds support for
> > "Bypass-Check-License: <reason>" footer.
> >
> > If the check should be ignored in a given CL, CL authors should
> > use the footer instead.
> >
> > Bug: 435696543,40237859
> > Change-Id: I177915c65932a3d76ea60ee6a0e396f726bc400d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842238
> > Reviewed-by: Gavin Mak <gavinmak@google.com>
> > Commit-Queue: Scott Lee <ddoman@chromium.org>
>
> Bug: 435696543,40237859
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ibedf8d13e3742249947e29e625a14cceaf89879c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6852377
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
Bug: 435696543,40237859
Change-Id: Iafdb29b928c016eb3949e29fd43a2ba5f53e0ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6852108
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
This reverts commit fa62515ecb.
Reason for revert: it seems that the existing files without valid copyright headers are causing linux-presubmit builds to fail. b/438791294
Bug: 435696543,40237859
Original change's description:
> presubmit: emit errors instead of warnings for bad copyright headers
>
> This is an effective revert of https://crrev.com/c/4895337 with
> additional patches to support a footer.
>
> https://crrev.com/c/3887721 updated CheckLicense() to emit errors
> for bad copyright headers. However, https://crrev.com/c/4895337
> was changed the finding type from error to warning, claiming that
> the check is N/A for moved third files, but it's not so easy
> to programatiically distinguish moved third-party files.
>
> After discussions, it was decided to change the finding type back
> to error to prevent accidental submissions for new files without
> correct CopyRight headers.
>
> To mitigate moved, third-party files, this CL adds support for
> "Bypass-Check-License: <reason>" footer.
>
> If the check should be ignored in a given CL, CL authors should
> use the footer instead.
>
> Bug: 435696543,40237859
> Change-Id: I177915c65932a3d76ea60ee6a0e396f726bc400d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842238
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
Bug: 435696543,40237859
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ibedf8d13e3742249947e29e625a14cceaf89879c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6852377
Commit-Queue: Scott Lee <ddoman@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Adds unittest and pylint checks for the mcp/ directory.
Change-Id: I7aa6a33fea7ac60500b8c865e18f3cf72d425289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6847122
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
This is an effective revert of https://crrev.com/c/4895337 with
additional patches to support a footer.
https://crrev.com/c/3887721 updated CheckLicense() to emit errors
for bad copyright headers. However, https://crrev.com/c/4895337
was changed the finding type from error to warning, claiming that
the check is N/A for moved third files, but it's not so easy
to programatiically distinguish moved third-party files.
After discussions, it was decided to change the finding type back
to error to prevent accidental submissions for new files without
correct CopyRight headers.
To mitigate moved, third-party files, this CL adds support for
"Bypass-Check-License: <reason>" footer.
If the check should be ignored in a given CL, CL authors should
use the footer instead.
Bug: 435696543,40237859
Change-Id: I177915c65932a3d76ea60ee6a0e396f726bc400d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842238
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Deduplicates the various `prpc call` subprocess.run calls throughout
mcp/ in favor of a new run_prpc_call helper.
Also makes a few drive-by cleanup changes that were caught by WIP
presubmit checks.
Change-Id: I3e401cb959ba96f2224ea1a7f7f58795330f643a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6847120
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
WindowsClient works for both non-admin and admin users. There's no need
to branch and use Fido2Client for admin users.
Bug:b/433851494
Change-Id: I42d52d71749beaf0b2c68d9adc6027a5b6bb2ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6844138
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Include a few `git cl` tools, particularly try_builder_results which
returns the current branch's try results in a json format.
Bug: None
Change-Id: I853250fc1ea4745771cdcc74002522ace39f7f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6847119
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Adds several ResultDB-related tools to the depot_tools MCP server.
Specifically:
* get_non_exonerated_unexpected_results_from_build which gets all test
results from a build that a normal user would consider failures.
* expand_summary_html which is used to expand the summaryHtml field
included in a ResultDB result to include referenced artifact content.
* get_test_level_text_artifact which retrieves the content of a test
result level text artifact.
Together, these allow Gemini to perform some rudimentary test failure
analysis such as grouping related failures together.
Bug: 438226961
Change-Id: I81cd798d7568bb47b1aa476589816253e29a5630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842578
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Updates mcp/buildbucket_test.py to use `from unittest import mock`
instead of `from unittest.mock import ...` since the Google style guide
says to avoid importing specific pieces of a module except in a few
specific (typing-related) cases.
Change-Id: Ibefb62e492fbf48b89e97fc75bf55beda7030d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842579
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Adds two new tools to the depot_tools MCP server related to retrieving
recent builds from Buildbucket. get_recent_builds retrieves the N most
recent completed builds from the specified builder, while
get_recent_failed_builds retrieves the N most recent failed (i.e. red)
builds.
Bug: 438226961
Change-Id: I55d93140fcf405276e622525a833c5717b5aca90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842576
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
This CL allows presubmit_support to run without any files in diff mode
if it's given --description "..."
Bug: 436813955
Change-Id: I43252c0fdbd1a87b6099d2c9cd19e4b0f9b7f64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6838150
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
This plugin handles FIDO2 security keys for doing auth and integrates
with luci-auth (specifically git-credential-luci).
(It's in Python because tl;dr the Python library is much better.)
Bug: 433851494
Change-Id: Ib956b614588aad8ad4fda7619bfbae17a670438f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6804585
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Trying to configure users' git config automatically has been more
trouble than it's worth. All users should be on new auth now (with
the help of the manual wizard), so disable the auto logic (and then
delete it later) so we don't get bitten by the auto logic
unintentionally interacting in a bad way later.
Bug: 430668572
Change-Id: Ia1f92d1bea834eb3be1887ea9c54d2e1a70ae33c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6821484
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
This is needed to pass the repo path to the credential helper, so we
can distinguish repos that need ReAuth.
Change-Id: I5aa72d6ec0421dcbff610f48f34129b8962050f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6822598
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
recipe-roller
Garrett Beaty
Riley
Matt Stark
Takuto Ikuta
Kameron Lutes
Adam Rice
Android Open Source Project
Jie Sheng
Jiewei Qian
Junji Watanabe
Allen Li
Ben Pastene
Scott Lee
Brian Sheedy
Brian Ryner
Struan Shrimpton
Erik Staab