No more trying to remember format differences between my_activity.py
and my_reviews.py.
Change-Id: Iaac34529899a78aef3bd2e0742e674c8754f8afb
Reviewed-on: https://chromium-review.googlesource.com/655420
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
This affects a bunch of files, but only changes comments,
and shouldn't make any difference to behavior.
The purpose is to slightly improve readability of pylint
disable comments.
Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11
Reviewed-on: https://chromium-review.googlesource.com/420412
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
It is done in preparation for switching to OAuth2 as default (and only)
authentication method. Having all auth options handled by the same code makes it
easier to gradually add OAuth2 support.
As part of this, some options that would no longer work with OAuth2 (and that
are not being used from anywhere now, as far as I can tell) are removed:
* Passing account password for authentication via command line.
* Overriding 'Host' header when making requests to Rietveld (won't work with
SSL anyway).
* --account_type option (seems to be ClientLogin specific).
R=maruel@chromium.org
BUG=356813
Review URL: https://codereview.chromium.org/1075723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
Handle KeyboardInterrupt gracefully rather the printing a
backtrace. Most users of these tools don't expect a
backtrace when then hit Ctrl-C.
Also, fix a few other inconsistencies found in the python
startup code of these different scripts:
- always call main function 'main' (rather than 'Main')
- always return 0 from main function
- if main takes args never include argv[0]
Review URL: https://codereview.chromium.org/955993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294250 0039d316-1c4b-4281-b951-d872f2087c98
Also, fix assertion that fires if all the reviews are
on the same day (first_day == last_day)
Also, don't print backtrace if no arguments at all are
specified.
Review URL: https://codereview.chromium.org/797523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293351 0039d316-1c4b-4281-b951-d872f2087c98
.search() may return results in unexpected order. Manually sort the entries
otherwise first_day and last_day could be inversed, leading to negative number
of days.
R=iannucci@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/16003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203792 0039d316-1c4b-4281-b951-d872f2087c98
Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is
broken _and_ slow.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8749005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98
I heard some people like to review their changes themselves. :)
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8045007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102670 0039d316-1c4b-4281-b951-d872f2087c98
Enforce a reviewer, when $EMAIL_ADDRESS is not set
BUG=
TEST=
Review URL: http://codereview.chromium.org/7988012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102340 0039d316-1c4b-4281-b951-d872f2087c98
It's now live on codereview.appspot, codereview.chromium and the internal
instance so it's far more easier to get review stats now.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7989013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102331 0039d316-1c4b-4281-b951-d872f2087c98
Output details to stderr to make it redirect-friendly. Silence upload.py.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7979034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102277 0039d316-1c4b-4281-b951-d872f2087c98
Daniel Cheng
Quinten Yearsley
vadimsh@chromium.org
sbc@chromium.org
thestig@chromium.org
maruel@chromium.org