2418b58763
Revert "Fix an exception when trying to report a non-referenced recursedeps entry"
...
This reverts commit e06356501ehttps://chromium-review.googlesource.com/c/440945/
>
> BUG=685443
>
> Change-Id: I16313bc7c09b0dd68c6ad118004f9d5cdfec0ddd
> Reviewed-on: https://chromium-review.googlesource.com/440394
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
>
TBR=dpranke@chromium.org,caseq@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=685443
Change-Id: I69b59e91b4019af112bd676c125119eee1edddda
Reviewed-on: https://chromium-review.googlesource.com/440490
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
8 years ago
e06356501e
Fix an exception when trying to report a non-referenced recursedeps entry
...
Problem originally introduced in https://chromium-review.googlesource.com/c/440945/
BUG=685443
Change-Id: I16313bc7c09b0dd68c6ad118004f9d5cdfec0ddd
Reviewed-on: https://chromium-review.googlesource.com/440394
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
8 years ago
812462026f
Make an error on wrong recursedeps entry.
...
BUG=685433
Change-Id: I5eb68c4a3bfd1c93edecf33127a459822f5a23ed
Reviewed-on: https://chromium-review.googlesource.com/440945
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
8 years ago
692edc1b72
Add gclient config option to add VR APK download to hooks
...
Adds the ability to only trigger the APK download hooks on bots we care
about instead of having them in the main Chromium DEPS file.
Hashes for the APKs are added in https://codereview.chromium.org/2666213002/
BUG=
Change-Id: I9fc3cadf621a954e0c2485ec16bf9d4f72c10f2f
Reviewed-on: https://chromium-review.googlesource.com/437710
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
8 years ago
fd239befb2
[recipes] manual roll and fix unicode.
...
Again, utf-8 encoded strings are the good thing to do in python2 :D
BUG=
Change-Id: I693a726f8407ea2ea135994ce6f49df76976e559
Reviewed-on: https://chromium-review.googlesource.com/440474
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
284af32556
[cipd] bump cipd client version.
...
BUG=689359
Change-Id: I6d76a5ac1c51db903bcfd00d91215981e9608bc8
Reviewed-on: https://chromium-review.googlesource.com/439783
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
af3a9993de
git cl: add temporary workaround for u200 chars in PolyGerrit.
...
(edited, so that next next line gets u200 char
between R= and reviewer email)
R=mstarzinger@chromium.org
TBR=agable@chromium.org
BUG=b/34702620 (internal)
Change-Id: I58f2528dd28e3a43d8eb2d7d4f5c046460d8a9ee
Reviewed-on: https://chromium-review.googlesource.com/440085
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
1dd692dc32
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/bab22ae9b2fb5541bee4cb60136a3c562f7a7fe9 Short-circut if result is None. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2682913005
8 years ago
c9dcb6ed64
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/0aa2b6364faf52b0536c37534efc4574708cecd6 [raw_io] prevent output_text from returning `unicode` object. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2681133003
8 years ago
b814797f9d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/699e274630d839a4d49ac48744ad71216b9553c6 split human reason (nodir@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2688473003
8 years ago
83051152f3
git cl: fix bugs in UpdateDescription.
...
R=kbr@chromium.org
BUG=633572,688765
Change-Id: I05130cfd05f89a4605c34b15cadf13a33e3565d9
Reviewed-on: https://chromium-review.googlesource.com/439445
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
8 years ago
3186301a4e
git cl: allow to forcibly bypass cache and fetch CL description.
...
R=kbr@chromium.org
BUG=633572,688765
Change-Id: I2ce6530148bc2f00fe9f6a80aaccc520c69a2f83
Reviewed-on: https://chromium-review.googlesource.com/439186
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
8 years ago
22e7a27c29
roll-dep: Add command used to make the roll in the CL description.
...
That's marketing 101. :)
R=sergeyberezin@chromium.org
BUG=
Change-Id: Ibbc1cd18650b7b601c27662fcb40ea7b15b40fc7
Reviewed-on: https://chromium-review.googlesource.com/439006
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
8 years ago
0551f8679e
Manual roll of raw_io output -> output_text refactor
...
BUG=686280,664352
TBR=iannucci
Change-Id: Ibd1feadffc440ea01790abe2bc73fc6a69092f54
Reviewed-on: https://chromium-review.googlesource.com/437821
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
8 years ago
1678a364a5
Add presubmit_support.EnsureCQIncludeTrybotsAreAdded.
...
The PostUploadHooks in the Chromium repository which add
CQ_INCLUDE_TRYBOTS entries to the issue description will be rewritten
in terms of this primitive, which will compose properly if multiple
sub-directories attempt to modify it.
BUG=688765
Change-Id: Icf72edb872f29af1e082038e96bc547504edfd07
Reviewed-on: https://chromium-review.googlesource.com/438925
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
8 years ago
52a23b3594
Remove svn support from tryserver module
...
Change-Id: Ic6109dff73f6726c1b50d107dc0996d1a0d0fcf4
Reviewed-on: https://chromium-review.googlesource.com/437637
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
328b00f95c
Fix typo in exclude file name
...
R=agable@chromium.org
BUG=
Change-Id: I744627d99454ddc71184b9251cf8a4a309f31b71
Reviewed-on: https://chromium-review.googlesource.com/437663
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
e9c78ffc95
git cl for Gerrit: add support for local git cache checkouts.
...
R=machenbach@chromium.org
BUG=689035
Change-Id: Ib7a56c52501a5d0dd6638a99bde3d376bd27bfb6
Reviewed-on: https://chromium-review.googlesource.com/438347
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
c907608a63
roll cipd client
...
Roll CIPD client in CIPD recipe module to version
git_revision:0f49ce7d793b80877633ed640c89547ece130abb
BUG=688918
Change-Id: Id4dbdc89a5b6b7d151996acb5ac6be4df7f4a5f0
Reviewed-on: https://chromium-review.googlesource.com/437993
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Emma Söderberg <emso@chromium.org>
8 years ago
85adaa343e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/5d4666c5340082e7bfad85ee01d47ebbc48aeab6 [path] Improve abs_to_path to include resource paths. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2677753002
8 years ago
a92e37a494
[cipd module] small cleanups in preparation for cipd 1.5.
...
Also bumps cipd client version to ac753ee37abd753a9a511210d3df362d003211f0.
BUG=
Change-Id: I5bb005eb603fd7106d8cf6125dc2cda3c6e1ac94
Reviewed-on: https://chromium-review.googlesource.com/436904
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
8 years ago
bf10708b7d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/1c4786ae10b3b4f17c2893cea345725c4a8cd135 [step|docs] Improve the nest docstring a bit. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2673583004
8 years ago
9d691d6427
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/77da9cfa8ca5cdf3d01c1ef30425d17af1f99592 [recipe_engine] Fix unnecessary plurality (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2672843004
8 years ago
f8fcfd8e06
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/37a1da981d744246d14a2c2e6fac554703ea4b1b [recipe_engine] Fix a couple path-related bugs. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2675613003
8 years ago
eb3af71509
git-cl: don't prompt after cleaning patchset title
...
BUG=688099
Change-Id: Ic505ab6553b1a9f1e6ab51377bb6519d805a847e
Reviewed-on: https://chromium-review.googlesource.com/436406
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
2a6c76ea36
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/a7a17ae6545a9ff04b71b3655ff4d08a0de32926 [recipe_modules/path] add abs_to_path. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2674593002
8 years ago
ae2e55b769
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/0e4d4e97edb04696b0b1452522eb26f1dc633e8e step: expose methods to read values from context (phajdan.jr@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2667863006
8 years ago
6db8ac71b3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/4fb4d4bdfda85253b842648abf8588749c68a5eb Fix multi-repo workflow overrides and add tests (phajdan.jr@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2666123002
8 years ago
71b8e66f89
Register v8/v8 in gclient for trying Gerrit v8 patches on chromium trybots.
...
R=machenbach@chromium.org
BUG=685318
Change-Id: I61192392eec98ad6b9a32ef933f2d22cf2aedd0e
Reviewed-on: https://chromium-review.googlesource.com/435318
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
9d32e4c137
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/30a672d26b45289947783932d8062fc70dfb1611 Make it possible to override more than one package (phajdan.jr@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2664843003
8 years ago
7afd16467e
Follow up on Gerrit git cl status: do not treat CQ comment as reviewer reply.
...
TBR=sergiyb@chromium.org,agable@chromium.org
BUG=
Change-Id: I37f02556f254fbdc78ab30e990a7cc6d05120038
Reviewed-on: https://chromium-review.googlesource.com/434477
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
33e88a4e19
Gerrit git cl status: do not treat CQ comment as reviewer reply.
...
R=sergiyb@chromium.org,agable@chromium.org
BUG=
Change-Id: I7684923c19fe7441cdd52b7707c28f01c95a4ba4
Reviewed-on: https://chromium-review.googlesource.com/433699
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
8 years ago
fe637498b6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/b120624b72ec851b0d9f2accccf58e525555be25 step: make all args to __call__ explicit (phajdan.jr@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2656133003
8 years ago
a732e984ff
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/bbcf1dc6436d1f89ffd35fe3354b9ee7701e272a Whitelisting python's copy module for recipes. (robertocn@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2660583002
8 years ago
eadad92e4a
git cl try: reduce number of RPCs to Gerrit from 3 to 1.
...
R=agable@chromium.org
BUG=681704
Change-Id: I3c0ab781e0357e0855d50157c5653df57f68ac9a
Reviewed-on: https://chromium-review.googlesource.com/432336
Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
8039be7cc8
git cl: reduce number of Gerrit RPCs in status check.
...
Also fixes git cl description <url> by propagating codereview host information
in all cases.
BUG=681704
R=agable@chromium.org
Change-Id: Ia79c10b19d72b5a8797a1428ad8a79c8f4480901
Reviewed-on: https://chromium-review.googlesource.com/431036
Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
8fc0c1d8f0
git cl: refactor tests to account for Gerrit GetChangeDetail RPCs.
...
BUG=681704
Change-Id: I7c8fd09f3c19b9facf876ebeef853e5d77b72a9c
Reviewed-on: https://chromium-review.googlesource.com/432316
Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
1090fd5b69
Fix git cl upload --dependencies for Gerrit.
...
BUG=640299
R=rmistry@chromium.org,agable@chromium.org
Change-Id: Iac987758065c57a4a08ce98f838fc0c30a8c1a02
Reviewed-on: https://chromium-review.googlesource.com/432676
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
056bef208a
Fix git-crrev-parse returning reverted commits instead of original commits
...
Also delete extraneous whitespace
BUG=685326
Change-Id: If7f68346fd27edf9a5dca315cfcfbca0decc2da6
Reviewed-on: https://chromium-review.googlesource.com/433158
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
8 years ago
8adfedcf43
Remove stip@ from OWNERS.
...
Change-Id: Id841c4720996ca3568cec8a5721469c34f00cf77
Reviewed-on: https://chromium-review.googlesource.com/431803
Commit-Queue: Mike Stipicevic <stip@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
5c34046d74
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/401a93b1055698158b3fb50a98aebb51e830ac44 [expect_tests] Add show_missing flag to coverage.report. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2655953002
8 years ago
1897532850
Python style fixes + unused imports removal in git cl and friends.
...
R=sergiyb@chromium.org
BUG=
Change-Id: I9b886100557bf6efa9be07d40175f7bb919f5294
Reviewed-on: https://chromium-review.googlesource.com/432456
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
18df0cdf0b
Improve debuggability of git cl tests.
...
Change-Id: If14776d86a687a6edf5917f2a63ff984b812ecb8
Reviewed-on: https://chromium-review.googlesource.com/432376
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
98cef5704b
git cl: _RietveldChangelistImpl should always have non-None auth_config.
...
TBR=phajdan.jr@chromium.org,sdefresne@chromium.org
Change-Id: I95cc6e61d044fd983c613fa7eeb21c8b77d7cee0
Reviewed-on: https://chromium-review.googlesource.com/432356
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
f3a20aed82
git cl: remove code related to pending refs and gnumbd.
...
Refactor _GitNumbererState to two functions and remove no longer
useful tests.
BUG=644915
R=agable@chromium.org
Change-Id: If5e3e3b141aee192211f6af130b01f20f9afdbfe
Reviewed-on: https://chromium-review.googlesource.com/431976
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
9c3a464bf7
For Gerrit: use CURRENT_COMMIT option to get description, not gitiles.
...
R=sergiyb@chromium.org
BUG=681704
Change-Id: I48804955d8e5e579eae6e60fccac304aaaa9230e
Reviewed-on: https://chromium-review.googlesource.com/430625
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
f732cd5c70
Add cl description backup to gerrit upload.
...
BUG=684261
Change-Id: I2716864526fcedf44e561be8512843e12810e3a9
Reviewed-on: https://chromium-review.googlesource.com/431459
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
cd091367bc
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/aae62c656032cf63284aecac5e974676064d8896 path module: fix tmp / cache dir creation (nodir@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2656753002
8 years ago
c5ba692d1e
Put git cl format JS formatting behind a flag.
...
This CL moves JS formatting behind the --js flag for git cl format
due to issue with LayoutTests. It also adds an option to check
javascript for the presubmit canned formatting check.
BUG=567770
Change-Id: I9c080b1136f6ffef9fb1b08d3bfc97ce5b3185dc
Reviewed-on: https://chromium-review.googlesource.com/430526
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Christopher Lam <calamity@chromium.org>
8 years ago
c87e36aaec
[git rebase-update] Handle error when chdir'ing to original workdir.
...
BUG=
Change-Id: I1dc7f20eea3f4b1be9179aa6d77bdee08ab8a04f
Reviewed-on: https://chromium-review.googlesource.com/431576
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Dirk Pranke
Andrey Kosyakov
Aleksandr Derbenev
bsheedy
Robert Iannucci
Andrii Shyshkalov
recipe-roller
Marc-Antoine Ruel
Stephen Martinis
Kenneth Russell
Nodir Turakulov
Aaron Gable
Jeff Carpenter
Mike Stipicevic
Christopher Lam