This is the simplest change I can make here. The bot_update.py script already
ignores the value of force (and sets it to True in all cases). This is an
expectations-only change.
I'll refactor the content of the bot_update.py script to account for this
removed option in a followup CL as well.
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2316323002
This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.
Removal of the force option (and related options) to come shortly.
R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2311673002
The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.
R=hinoka@chromium.org
BUG=640251
Review-Url: https://codereview.chromium.org/2291583003
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.
R=iannucci@chromium.org
BUG=640251
Review-Url: https://codereview.chromium.org/2270083004
"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.
BUG=
Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002
If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.
Review-Url: https://codereview.chromium.org/2175103002
add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.
This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.
TBR=dnj@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2176913002
Reason for revert:
this is wrong. if directory is not empty, git clone fails
Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: cdac80c9fbTBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2173683003
site config is not present on builders which use kitchen, so we need to use credentials provided by puppet in the /creds directory.
BUG=624212
TBR=hinoka
Review-Url: https://codereview.chromium.org/2108073002
Reason for revert:
/b/cache dir on slaves were not cleaned up and now disk alerts are firing
please come up with a cleanup strategy before re-landing this CL
Original issue's description:
> infra_paths: keep cache paths super short to avoid long path issues
>
> BUG=623575
>
> Committed: aa0b3b6bd0
TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,thakis@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623575
Review-Url: https://codereview.chromium.org/2100793004
The script already contains references to chrome-internal, and when running
under remote_run we have no access to hacky build_internal checkout.
BUG=593999, 584079
Review-Url: https://codereview.chromium.org/2101573002
With this change, we can run chromium tryjobs for changes to catapult.
R=tandrii@chromium.org, nednguyen@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2030623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98
The change in https://codereview.chromium.org/1982243002
didn't take into account that the script runs on the actual
bot OS, so Windows will have backslashes as dir separators.
BUG=438952
Review-Url: https://codereview.chromium.org/2021783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300672 0039d316-1c4b-4281-b951-d872f2087c98
Lets you get CL tags for a given CL.
BUG=591172
Review-Url: https://codereview.chromium.org/1915833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300658 0039d316-1c4b-4281-b951-d872f2087c98
The --extra_patchlevel flag was added in
https://codereview.chromium.org/1988583002/
In order to make it possible for WebRTC patches to apply in
src/third_party/webrtc of a Chromium checkout, one directory
level needs to be trimmed.
BUG=438952, 611808
Review-Url: https://codereview.chromium.org/1982243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300618 0039d316-1c4b-4281-b951-d872f2087c98
'git apply' works on Git indexes, so it's not possible
to apply a patch to src/third_party/webrtc with cwd=src/third_party.
Instead, set the cwd to the correct dir and add an extra patch
level using the new flag in https://codereview.chromium.org/1988583002/
This essentially reverts https://codereview.chromium.org/1977373002/
+ sets the project path correctly to src/third_party/webrtc.
BUG=438952
Review-Url: https://codereview.chromium.org/1984993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300616 0039d316-1c4b-4281-b951-d872f2087c98
This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.
Expectation update in: https://codereview.chromium.org/1984673002
BUG=438952
Review-Url: https://codereview.chromium.org/1977373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300603 0039d316-1c4b-4281-b951-d872f2087c98
After the deletion of page_cycler.morejs benchmark, these are the only two
gclient configs we need across chromium.perf, chromium.perf.fyi, and
tryserver.chromium.perf. Rename from "perf" to "chromium_perf" to match chromium
config. This CL will be followed up with one to delete "perf".
BUG=611484
Review-Url: https://codereview.chromium.org/1976843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300600 0039d316-1c4b-4281-b951-d872f2087c98
Test case being added in https://codereview.chromium.org/1984623002/
NOTICE:
* Only patches from the webrtc/ subdirectory in a standalone
WebRTC checkout will work, since the root is set to src/third_party.
This can be changed once http://crbug.com/611808 is fixed.
* The Chromium checkout will be synced to the DEPS-pinned revision
of WebRTC. Changing this to HEAD will be addressed in a future CL.
BUG=438952
Review-Url: https://codereview.chromium.org/1976243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300588 0039d316-1c4b-4281-b951-d872f2087c98
This is a preparation for removal of infra-specific
paths from the recipe engine.
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1930373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98
This is different from previous attempt https://codereview.chromium.org/1915463002 .
The change is completely backwards-compatible, and doesn't introduce recipe
expectation changes.
Modules can be switched to depend on infra_paths independently,
without any expectation changes either.
By moving path module's config.py to paths_config.py here, we also guarantee
that the returned results are going to be exactly the same.
Depends on https://codereview.chromium.org/1923363003 .
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1926033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org)
R=phajdan.jr@chromium.org
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1926633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
I believe this is mostly likely to have broken Angle, but this is speculative.
http://crbug.com/606150
Original issue's description:
> bot_update: call gclient sync after checking out a gerrit ref
>
> BUG=chromium:602906
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300109
TBR=hinoka@chromium.org,yyanagisawa@chromium.org,hinoka@google.com,phajdan.jr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:602906
Review URL: https://codereview.chromium.org/1918903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300159 0039d316-1c4b-4281-b951-d872f2087c98
Removes deprecated patch_project_roots in bot_update,
and the TODOs used for migration.
Depends: https://codereview.chromium.org/1913863002
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1920933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300153 0039d316-1c4b-4281-b951-d872f2087c98
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.
This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1917433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
Avoid to call git reset --soft to preserve current revision to
FETCH_HEAD. 'got_revision' property would also be that from
FETCH_HEAD.
BUG=596787
Review URL: https://codereview.chromium.org/1837453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299721 0039d316-1c4b-4281-b951-d872f2087c98
Also makes bot_update use this.
This allows for clank to manually set the gclient config.
BUG=590788
Review URL: https://codereview.chromium.org/1815863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98
iannucci
agable
bpastene
andybons
tandrii
hinoka
rmistry
phajdan.jr
borenet
machenbach
martiniss
nodir
mikecase
smut
dpranke@chromium.org
kjellander@chromium.org
dtu@chromium.org
hans@chromium.org
phajdan@google.com
recipe-roller@chromium.org
yyanagisawa@chromium.org