aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,201 Commits
6 Branches
0 Tags
189 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'aa2db565b3'
${ noResults }
Commit Graph

6201 Commits (aa2db565b32b0993a834348932c69424993e3f06)
 

Author SHA1 Message Date
Elly Fong-Jones 7b2943927c depot_tools: bail out if $PATH contains tildes 
Bash and its descendants allow having $PATH entries containing literal tildes,
like:
  ...:~/depot_tools:...
If the user has their shell configured this way, their shell will be able to
invoke `fetch` and other depot_tools commands, but depot_tools will not in turn
be able to invoke subcommands via popen because popen does not have this
bash-specific behavior when not in shell mode.

This change has gclient detect this configuration problem and error out with a
descriptive error message. Not doing so leads to a puzzling condition where
gclient complains about being unable to find a program that (from the user's
perspective) is in their $PATH and invokable interactively.

It also has 'fetch' suppress its own failure stack trace if it runs gclient and
gclient fails; the 'fetch' stack trace pushes the messages from gclient (which
are actually diagnostic) off the screen.

Bug: chromium:952865
Change-Id: Ibba4d2fccee405aa68392ce141493f1de21ec018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1573204
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
 6 years ago
Aaron Gable ac9b0f3786 Restore py2/py3 compatibility with basestring 
A previous CL replaced "basestring" with "str", because basestring
does not exist in Python 3. However, this broke Python 2's ability
to interoperate with unicode strings. This CL introduces a workaround
(defining basestring to be equivalent to string, if it doesn't exist
already), and restores the references to basestring. This workaround
can be fixed when we're 100% on Python 3.

It also undoes some unnecessary and harder-to-read formatting changes.

Bug: 942522
Change-Id: I4a31ee46dc048134c2e4832b6c44ea00ce341899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1572441
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 6 years ago
Marc-Antoine Ruel 1e2cb1573b [roll-dep] Ignore chromium-autoroll rolls 
- It uses a different commit subject than recipe roller.
- Switch from looking up for magic strings to use a regexp instead. Document the
  source of each string, to help keep up when the source diverge.

Tested manually.

Change-Id: I76fc6b6692508c615a0e76c4b6b403f8c513dd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1564938
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Henrique Ferreiro e72279d25f Keep warning about unversioned trees until removed 
Restore previous behavior and keep emitting a warning when an existing
gclient entry is not longer part of the client. Additionally, suggest
the usage of `gclient sync -D` to automatically remove them.

Change-Id: I62d4662ae4d0886d340230019419b68debffc5ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1483031
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
 6 years ago
Vadim Shtayura 7e7523be4e [lucicfg] Bump lucicfg version v1.6.0 -> v1.7.0. 
Changes:
2019-04-16 vadimsh@chromium.org [lucicfg] Allow to use relative paths in load(...) and exec(...).
2019-04-16 vadimsh@chromium.org [lucicfg] Remove config_set meta option, finish declare_config_set.
2019-04-13 vadimsh@chromium.org [lucicfg] Parallel validation of multiple config sets.
2019-04-12 vadimsh@chromium.org [lucicfg] Add ctx.declare_config_set(...) API.
2019-04-12 vadimsh@chromium.org [lucicfg] Convert Output from a map alias to a struct.
2019-04-12 vadimsh@chromium.org [lucicfg] Use ctx.output instead of ctx.config_set in generators.
2019-04-11 vadimsh@chromium.org [lucicfg] Start refactoring to support multiple output config sets.
2019-04-11 vadimsh@chromium.org [starlark] Fix tests after recent go.starlark.net roll.
2019-04-10 vadimsh@chromium.org [lucicfg] Finish the doc.
2019-04-09 vadimsh@chromium.org [lucicfg] Add a doc for "migrating from existing configs".
2019-04-09 vadimsh@chromium.org [lucicfg] Add examples of realistic lucicfg configs.
2019-04-05 vadimsh@chromium.org [lucicfg] Write an introduction doc.
2019-04-05 vadimsh@chromium.org [lucicfg] Write "Defining cron schedules" doc.
2019-04-05 seanabraham@chromium.org Improve emit_defaults documentation.
2019-04-04 nodir@google.com [buildbucket] Move config protos

R=tandrii@chromium.org
BUG=945048

Change-Id: I250c13fee50fbc963d44fccef1cba3510e834905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1570412
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Andrii Shyshkalov 4b79c3870c git_cache: add OVERRIDE_BOOTSTRAP_BUCKET option. 
Will use used by led-triggered tests of git_cache_updater builder.
Companion recipe CL: https://chromium-review.googlesource.com/c/infra/infra/+/1568156

R=hinoka

Change-Id: Ib25824d4d04cfb8aa0831fc5ae666a94808b289e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1567999
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Dirk Pranke db58954c8c Use the same git-cache bucket for authenticated and unauthenticated repos. 
We should only be maintaining one cache bundle per repo, but it turns
out that we've had two in the past due to GoB supporting two different
paths to the repo, and users were getting stale bundles as a result.

This CL fixes things so that we should only get a single bundle per
repo.

Bug: 935084
Change-Id: I0d6713280a2abbc20e35ff87e7be115870dd5140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1566431
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
 6 years ago
Nodir Turakulov bd29f6f752 Roll bb to 080c945efd74d45e9edac5d5b6cc598bbe106593 
R=tandrii@chromium.org

Change-Id: Ie63f41667982ae8e8546ad913de48dcddb7e25ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1566081
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
 6 years ago
recipe-roller 1de3cd440c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/602257a66a4e492e7029ccaf542b55f9ef641346 [buildbucket] Add url_title_fn (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2ed8ccce3bef869d27425989fdce11e1230fdd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1565145
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
John Budorick a67950d670 Update vpython pins to git_revision:0bff6ebf817352838b0e6f65fd6460b38c505c9c. 
Bug: 949372
Change-Id: Iba11a24e538587dd84c35eb0fba7362e63e29049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1560352
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
 6 years ago
recipe-roller 8e0cce0c31 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ab483dae0cc2942e93506bedce9b814c77d42327 Add support for specifying swarming server. (yshaul@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie15f8b64f8beb476f0feb8906ddfc88dcb9d1c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1564713
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Nodir Turakulov 6379cd39a3 Roll bb 
This release will be announced

R=tandrii@chromium.org

Change-Id: If48ffb6f0fd66668d45c2a20928b855b70c29bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562674
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 1701094c07 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a8a96dca3e5e81e2bfff4b93a2384c8b40a58068 Add commit_position module (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I933abdab4f760664cf5571c7af880300efa5dfcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562633
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 4f74c21e2e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/10a2ec175037ae0a360b7e317ecc9b8ac76e9d95 [buildbucket] Print builder ids (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6b85d10ab199dcb6c157dff37d74a1f795dc8c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562632
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 0743a1400d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/cc7c58088b474b95483beaf4b41a3028121e4f7b [scheduler] Read current triggers (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0d508b0422f5b78a6f89653c63823cfa3ceb76c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562631
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 77b3499b88 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/166a0650c2d951e45118581b5fa442940a675a13 Add recipe_proto OWNERS (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idfd63f4a90e8a81adf7bfd3c5cf7798944a5212d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562112
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 280474c2a9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6c8922f408b3a4f103be5659fa941b2bbe1befb2 Implement copy operations for sentinel. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I15761d9bb442ccccb22b2ec5fcba49ac46743220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562351
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 224e075bba Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9cbb703d2234f3627a95f2fef0d75ae8e5850f75 [buildbucket] Use bb tool (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifd143d68ce862c188338caa38443350cf2e6e35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1559273
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Raul Tambre 1fb046306b Fix UTF-8 output in gclient_utils.CheckCallAndFilter 
Hooks for Electron output UTF-8 characters.
Example error for when "✔" is output:
  File "/home/markus/depot_tools/metrics.py", line 266, in print_notice_and_exit
    yield
  File "/home/markus/depot_tools/gclient.py", line 3112, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/markus/depot_tools/gclient.py", line 3098, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/markus/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/markus/depot_tools/gclient.py", line 2677, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/markus/depot_tools/gclient.py", line 1746, in RunOnDeps
    self.RunHooksRecursively(self._options, pm)
  File "/home/markus/depot_tools/gclient.py", line 1052, in RunHooksRecursively
    hook.run()
  File "/home/markus/depot_tools/gclient.py", line 245, in run
    cmd, cwd=self.effective_cwd, always=self._verbose)
  File "/home/markus/depot_tools/gclient_utils.py", line 344, in CheckCallAndFilterAndHeader
    return CheckCallAndFilter(args, **kwargs)
  File "/home/markus/depot_tools/gclient_utils.py", line 576, in CheckCallAndFilter
    stdout.write(in_byte.decode())
  File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xe2 in position 0: unexpected end of data

This issue was introduced in CL:1524583.

Bug: 942522
Change-Id: I3c4355b925b34398c800d142f942531a829e0297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541334
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
 6 years ago
John Budorick 0b62ed79ed Revert "[bot_update] Default to refs/heads/master" 
This reverts commit 9198ef8ede.

Reason for revert: Spec revert: appears to be causing large number of chromium CQ failures on patch application.

Original change's description:
> [bot_update] Default to refs/heads/master
> 
> When revision is not specified, currently HEAD is checked out.
> Change the default to refs/heads/master
> 
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 940214
> Change-Id: I8be59095d90447ea898d5247a6433f0734f5e63b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554862
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: Icafd817d8f044a4347342bd85dc97d193329a704
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 940214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1555514
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
 6 years ago
Nodir Turakulov 9198ef8ede [bot_update] Default to refs/heads/master 
When revision is not specified, currently HEAD is checked out.
Change the default to refs/heads/master

Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 940214
Change-Id: I8be59095d90447ea898d5247a6433f0734f5e63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554862
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 837c8e5222 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/51acda8019760f9d510d3b3343a934c0fddcd7d0 [buildbucket] Add is_critical help function (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I44b88829652dce778801a1fb9fa6abd46dd27b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554981
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 549bde19ae Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4885460fce04564eccdc6d03503934ec32fcc0c9 Exit early if required binaries aren't found on PATH (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9f8be975844a6a1edecf7f2a4dccf01c8e1f83a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554019
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Derek Schuff dbc721d65f Add gclient recipe_modules config for emscripten_releases LUCI project 
Bug: https://bugs.chromium.org/p/v8/issues/detail?id=8936
Change-Id: Ia21ccbbffc6ad3614b9b73a6aefbb2a041f96a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554013
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
John Budorick 9f74913e51 Roll vpython to git_revision:2973c0809cdc7122b7123e42b163a54d4983503f. 
Bug: 947242
Change-Id: I459f6fc814918f9f0e7eedfc534132a64a3aa7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549221
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
 6 years ago
Andrii Shyshkalov b8268cad11 Reland "git cl status: differentiate "dry-run" from generic "commit"." 
This is a reland of 3c830222ae with a fix.
Previous CL relied on summary data of CQ votes provided by Gerrit,
which apparently isn't always present in the way I expected.
This resulted in "git cl status" returning "lgtm" instead of "commit"
on Skia recipe roll CLs, which resulted in recipe roller abandoning CLs,
and creating new ones (there might be a bug in recipe roller, too).

The fix is to iterate over all votes on CQ label and finding the highest
score, and then deciding on the state.

Original change's description:
> git cl status: differentiate "dry-run" from generic "commit".
>
> CQ vote       now       before
>   +2       "commit"    "commit"
>   +1       "dry-run"   "commit"
>
> R=ehmaldonado
>
> Tested: manual "git cl status" run locally.
> Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: If9af5a2bf8f21d203b7a62740a27916eca0838ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549640
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Jamie Madill 25eb154c14 Add angle_root custom var to ANGLE gclient config. 
This should allow for any recipe that uses the ANGLE repo to run
gclient sync with the right folder structure. Currently gclient sync
will check out third_party directories to the wrong folder.

Bug: angleproject:3288
Change-Id: Ia97592fdc0c9f3ec70c2d4a05d9934a6bc996507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1551019
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 6 years ago
Nodir Turakulov 865445eb8a [bb] Deploy bb 
Add bb to depot_tools

Bug: 946422
Change-Id: I7f1e5463b7bb1170124c94066b660a1b972884bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1550200
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Vadim Shtayura 52f1494ca3 [lucicfg] Bump lucicfg version v1.5.12 -> v1.6.0. 
Changes:
2019-04-02 vadimsh@chromium.org [lucicfg] Rename 'recipe = ...' field into 'executable = ...'.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of CQ configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Accept non-standard text protos as input of semantic-diff.
2019-04-02 vadimsh@chromium.org [lucicfg] Remove header IDs from normalized Milo configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of Milo configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of Scheduler configs.

TBR=tandrii@chromium.org

Change-Id: I1ace2edb3a2b686d069dbfb3d753ecc2540f01fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549945
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
Edward Lemur 9a5e3bd817 gclient_scm: Simplify fetching refs. 
Bug: 874501, 942229
Change-Id: Ie9896e8a289e32a1b468ed5fa51c95a81970bdf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544802
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Jamie Madill 422c432dd2 Add ANGLE revision to gclient config. 
Bug: angleproject:3339
Change-Id: I1508937b5a367ed732231996c1b24588be5df9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549645
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Nodir Turakulov fdd2581115 [bot_update] Set output commit of the build 
Add set_output_commit param to bot_update.ensure_checkout, false by default.
If true, call api.buildbucket.set_output_gitiles_commit to set the output commit
of the build. This generally supersedes got_revision and got_revision_cp.

Bug: 940214
Change-Id: I5ffc790a6b12c8bf4a56469b3ecc567141c0d735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548256
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
 6 years ago
Andrii Shyshkalov c1e4405da9 Revert "git cl status: differentiate "dry-run" from generic "commit"." 
This reverts commit 3c830222ae.

Reason for revert: broke recipe roller.

Original change's description:
> git cl status: differentiate "dry-run" from generic "commit".
> 
> CQ vote       now       before
>   +2       "commit"    "commit"
>   +1       "dry-run"   "commit"
> 
> R=​ehmaldonado
> 
> Tested: manual "git cl status" run locally.
> Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I1c7597e52f860c9b03c9f9505bda274bed32fc2a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549639
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Andrii Shyshkalov e30d051370 roll_dep: update blacklist with new recipe roller. 
R=maruel

Change-Id: Iebe989314c9dffa5b433641c4f099806291350f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548718
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
 6 years ago
Andrii Shyshkalov 3c830222ae git cl status: differentiate "dry-run" from generic "commit". 
CQ vote       now       before
  +2       "commit"    "commit"
  +1       "dry-run"   "commit"

R=ehmaldonado

Tested: manual "git cl status" run locally.
Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller 8d3ba46327 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8f658073e9df9d182ce6bb39cf2406e1a5ade7dd [buildbucket] Require commit ref (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d4623423a7332ba8d2c3afb053f9358b627645d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544867
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller f6e3609760 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6af8640f4269b14122fa7eb4339a248c871855a1 [buildbucket] Add "critical" parameter (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie60c5f7ad484b52a191b187a70f35754a1996cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546385
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Vadim Shtayura 047b02314c [lucicfg] Bump lucicfg version v1.5.6 -> v1.5.12. 
Changes:
2019-03-29 vadimsh@chromium.org [lucicfg] Add native support for luci-notify email templates.
2019-03-29 vadimsh@chromium.org [lucicfg] Move normalization code into a separate package, clean it up.
2019-03-28 vadimsh@chromium.org [lucicfg] Use full file path when matching against tracked_files patterns.
2019-03-28 vadimsh@chromium.org [lucicfg] Add lucicfg.emit(...) function.
2019-03-28 vadimsh@chromium.org [lucicfg] Fix a confusing error when using None as dimension value.
2019-03-28 vadimsh@chromium.org [lucicfg] Catch up to recent-ish config proto changes.
2019-03-25 vadimsh@chromium.org [lucicfg] Fix bug in luci.notifier(...).
2019-03-22 vadimsh@chromium.org [lucicfg] Add lucicfg.check_version(...).
2019-03-22 vadimsh@chromium.org [lucicfg] Add luci-notify.cfg support.

TBR=tandrii@chromium.org

Change-Id: Ia3a8261adccc531949ee59004098052b7f084d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546379
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
recipe-roller ff79e7ea06 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/db94883c139d0588a78098babdd45750a9145fb4 Add better validataion for engine_step.TriggerSpec. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I512fe7fa01b13a70e91def42c4138a8d6cadbfc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546209
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Raul Tambre d19589ff81 Throw error for unicode URLs in .gclient 
This is no longer supported to make the move to Python 3 easier.
Only some very old/weird user configurations may have this, so this provides a clear actionable error message.

Bug: 942522
Change-Id: I88106089c53d84b19c4f77b7e60fe251082122d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1539957
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
 6 years ago
recipe-roller e2d41fe99d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/94845e3a38c887497c7e843cd715e55bcdfc494f Add better validataion for engine_step.EnvAffix (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida0620389056c22933931209a39a5906e237592d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1545279
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 803c869254 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e1bd7abedaddbd8513adbce310eb11777f2a3084 [fetch] Mark commits which touch .gitattributes as "interesting". (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icd89dd9d171ba83f75e2ed7399f83d07d09ece51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1545273
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur bdbe07f29d gclient: Support syncing deps to refs/{branch-heads,tags}:revision. 
Arbitrary refs (i.e. syncing to refs/arbitrary/stuff:revision) is not
guaranteed to work.

Bug: 874501, 942229
Change-Id: If08f0d9ae257e3d9f486d3ea6b310c8d94d3b918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1542588
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Karen Qian <karenqian@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller f36fc4350b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/48f7d09ba6cca243c582f8e6eb80bd10a0ff161c Add the ability to use lambdas as post-processing hooks. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id96d5d8155a869815634f1a90aab79674ca39a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544743
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller d3d7e2083b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c53035c7c222ad781a4e941cda966d43cea464bb [recipes.py] Do a git-clean after asserting the current revision. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6259150061c95e6506a611ab5c2568665eda45c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544335
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 53fd4dc175 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/16c546d0ec115133051c875e5121eab17c54bb45 Update the ignores for checkers to include the steps dictionary. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I695a2082ca1d2caf6b6e4d5c69ed3c1910b63df6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544333
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 4960c0dabd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c8d755745eb947ba80699604b6e747a6a3047916 Fix incorrect comment. (garymm@google.com)
  https://crrev.com/4b03702efa1413999e5ecd2e3f80a032936667ba Fix docstring for post_process.PropertiesDoNotContain (erikchen@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I28cae4767d8d880abf05098b90f0acab35338793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544329
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Leszek Swirski e989bb2b45 Make git-nav-upstream use the upstream branch name 
The previous git-nav-upstream fix used the current branch name, and
stored the upstream move relative to that branch (in the reflog), e.g
nav-upstream from branch foo to origin/master would should foo@{u}.
This unfortunately breaks if the branch is then deleted, so now we
calculate the upstream branch before checking it out, by passing
"@{u}" rather than HEAD to rev-parse.

Change-Id: I14a2eb8493d63e8386e988fd68b8a3125f19ce2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1536070
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 51c0f388a1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5c579aefde72744956934c8805273cd43f53cd1d Move StepConfig and friends to their own module, engine_step. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3568d6356b823e3fab0cfa55f587126ce1ccf361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541971
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller ffac5b5035 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/80e1d4b24dded35128a888c2de959ccd0dd8d140 Remove step exit code from test expectations. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I80cb55f6c4f2e3352accff09a15d8eceaa2c525c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541737
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago