maruel@chromium.org
8b40a9b81b
Fix ListRelevantPresubmitFiles().
...
It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
143993e97b
Fix gcl unit tests.
...
Review URL: http://codereview.chromium.org/118159
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17488 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
ca14c12a62
Rewrite the presubmit test to be much more hermetic.
...
Review URL: http://codereview.chromium.org/115964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17314 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
388f1d2656
Save 50 lines by converting the unit test to mox.MoxTestBase.
...
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/118019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17215 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
b76227689c
Convert gclient_test.py to mox.MoxTestBase and saves 40+ lines
...
Review URL: http://codereview.chromium.org/118014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17213 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
77c4f0f135
Remove SVN-specific function InputApi.FilterTextFiles().
...
Review URL: http://codereview.chromium.org/115923
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
15bdffa063
Make AffectedFile member variables private.
...
Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
786886257e
warnings.catch_warnings() is only available on python 2.5
...
Review URL: http://codereview.chromium.org/115881
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17114 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1e08c00d60
Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().
...
Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
6ebe68a73d
Make the member variable 'protected' in the python sense.
...
Review URL: http://codereview.chromium.org/113899
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e1a524ff00
Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.
...
Review URL: http://codereview.chromium.org/113883
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f3eee5692c
Add a unit test for input_api.change.tags.
...
Review URL: http://codereview.chromium.org/113859
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
9711bbafde
Add InputApi.version so the presubmit script can mark a minimum supported version for instance.
...
BUG=None
R=joi
Review URL: http://codereview.chromium.org/115719
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
dbbeedc691
Factor out SVN-specific methods out of AffectedFile.
...
TEST=New unit tests.
BUG=None
Review URL: http://codereview.chromium.org/113783
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0ff1fab804
Add repository root presubmit support.
...
Review URL: http://codereview.chromium.org/115616
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
98fc2b9bf6
Add support to cache arbitrary file.
...
Rename repository_root to REPOSITORY_ROOT.
Review URL: http://codereview.chromium.org/115615
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16598 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
374d65e518
Move the changelist files into a subdirectory for cached files implementation.
...
Review URL: http://codereview.chromium.org/115612
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16597 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8c3ccf39eb
Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests.
...
Review URL: http://codereview.chromium.org/113650
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16499 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
003c269b98
When -s or --server is used, don't try the patch.
...
Review URL: http://codereview.chromium.org/115534
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16477 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
7b305e8c18
Add new presubmit check RunPythonUnitTests.
...
Review URL: http://codereview.chromium.org/115516
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
5771f2622c
Clean up revert.py and fixes an issue when only one file is reverted in a subdirectory.
...
Add a basic unit test.
Review URL: http://codereview.chromium.org/115514
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16388 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3d23524cb0
Add more presubmit support. Add PRESUBMIT.py to depot_tools.
...
Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
2806acc58c
Remove two seams options.gclient and options.scm_wrapper in gclient.
...
Review URL: http://codereview.chromium.org/115322
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16155 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0329e67bae
Remove the options.path_exists which only existed as a seam. It's not really needed in python.
...
Also fix 2 other mocks.
Review URL: http://codereview.chromium.org/115286
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15976 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1033accb23
Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.
...
Review URL: http://codereview.chromium.org/113337
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
39593706a7
Fix unit test due to change r15911.
...
TBR=estade
Review URL: http://codereview.chromium.org/115283
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15928 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
kuchhal@chromium.org
00c41e457b
Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2).
...
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/113294
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
4810a96600
Deprecate gcl.GetSVNStatus() for gclient.CaptureSVNStatus() and fix some status information that was lost.
...
This was breaking gclient revert on unversioned files.
TEST=ran "for %a in (tests\*test.py) do python %a" and all tests succeeded.
Review URL: http://codereview.chromium.org/115264
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15894 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
46a9410947
Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().
...
Review URL: http://codereview.chromium.org/113290
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15891 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
5c3a2ff6a2
Add a flag not print errors in CaptureSVN()
...
Review URL: http://codereview.chromium.org/113288
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15887 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
be0d1ca0e4
Add more tests and cleanup ChangeInfo class.
...
Review URL: http://codereview.chromium.org/113269
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15885 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
df7a3134bd
Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly.
...
Fix breakage caused by r15861 and add a regression test.
Review URL: http://codereview.chromium.org/113278
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15872 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
96b9171280
Revert 15861 because of
...
File "D:\b\depot_tools\bootstrap\\..\gclient.py", line 446, in SubprocessCallAndCapture
out.write(in_byte)
TBR=nsylvain
Review URL: http://codereview.chromium.org/115244
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15862 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e77173e573
Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly.
...
Review URL: http://codereview.chromium.org/113272
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15861 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
11e0fd6997
Revert changes 15823 and 15824 because they broke gclient revert.
...
TBR=sgk
Review URL: http://codereview.chromium.org/115217
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15827 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
46b9ae6961
Starts reusing functions in gclient.py from gcl.py.
...
Review URL: http://codereview.chromium.org/113218
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15824 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
09b3ba2160
Cleanup gclient.py use of options where unnecessary.
...
Review URL: http://codereview.chromium.org/113216
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15823 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
2dc8a4d3d4
Change CaptureSVNInfo() to return a dictionary instead of a object.
...
Review URL: http://codereview.chromium.org/113086
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15750 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
edd27d1770
- Add '!' and 'L' status support.
...
- Fix gclient revert/status when one of the dependency directory is deleted.
- Remove an unneeded svn update after svn checkout.
- Updated tests.
Review URL: http://codereview.chromium.org/100256
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15068 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e105d8d039
Pull gclient revision 72 and add the gclient unit test.
...
Review URL: http://codereview.chromium.org/99226
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14957 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
207fdf3647
Convert gcl.GetSVNFileInfo() to xml format.
...
Add gcl's first unit test.
Add version string.
Review URL: http://codereview.chromium.org/100095
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14771 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
c1675e27e6
Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRESUBMIT.py scripts.
...
Also add a version number to gcl.py.
Review URL: http://codereview.chromium.org/99072
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14644 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
02e9e068f9
When I copied presubmit_unittest.py, I picked the old one. Fix with the latest version from the "old" depot_tools.
...
TBR=nsylvain
Review URL: http://codereview.chromium.org/100055
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14635 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@google.com
fb2b8eb2e2
Create the Next Generation of depot_tools. Eh.
...
Review URL: http://codereview.chromium.org/92087
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago