recipe-roller
879d5e3796
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/04620158d8f45c68cc8bc39e30ce4a85c368046a [archive] Add extended-length path support for windows. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic26a7c96c2eda21b232e11c407a198fe928568e7
Reviewed-on: https://chromium-review.googlesource.com/c/1297194
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Robert Iannucci
98f1e59b41
[git] Stop using git-retry wrapper on LUCI.
...
The LUCI environment alreadly does `git retry` style retries by virtue
of it's Go git-wrapper program. No need to put an extra python
interpreter in the middle.
R=hinoka@chromium.org, nodir@chromium.org
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Change-Id: I2918d7f413dde667fccd45c83ad6f4b96c2afe2e
Reviewed-on: https://chromium-review.googlesource.com/c/1292236
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
7 years ago
Scott Graham
e660e3fb9a
Support target_arch for WindowsSDK
...
Bug: chromium:892712
Change-Id: I68e1822a9a7205aaab3836be3f57a2f1feb1c9a6
Reviewed-on: https://chromium-review.googlesource.com/c/1289231
Commit-Queue: Scott Graham <scottmg@chromium.org>
Auto-Submit: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
7 years ago
John Budorick
1333933200
bot_update: stop failing with a KeyError in the recipe on failure.
...
This has been low-key driving me bananas for a while, and I've seen
it confuse sheriffs etc many times.
Change-Id: If46ab55821447a3a70a3f0ea774c017f29fc7400
Reviewed-on: https://chromium-review.googlesource.com/c/1286819
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
7 years ago
recipe-roller
74b7024660
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f46a599f105746e2f0ce7068c630e312f2113893 [cipd] Do not assume that all packages have refs or tags. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic63aa46f0dd00a0c6bc3315bcbddb0ae871e57eb
Reviewed-on: https://chromium-review.googlesource.com/c/1283809
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
066e11079d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/dffa0b83f071c910d625955d6bb61335696e3a08 Add UUID recipe module (smut@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If0a3cdcf3cf05894b71f73aa15121bdf353193af
Reviewed-on: https://chromium-review.googlesource.com/c/1278325
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Ryan Tseng
2fddb95698
[git recipe_module] Add tags flag for fetch
...
Some projects that use the git module (eg flutter) require tags.
Bug: 870558
Change-Id: Idae50ef5c8a092e5f0109b6c14c562268a2ad236
Reviewed-on: https://chromium-review.googlesource.com/c/1274245
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
7 years ago
recipe-roller
71e3be7a50
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/acbe9e3142610d958181460254565ef27ad47dc0 [StepPresentation] Remove all logs from memory during finalization. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id65a77df9f8508f57a28aa77433b141b1a691c9f
Reviewed-on: https://chromium-review.googlesource.com/c/1264996
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Robert Iannucci
85af45334e
[windows_sdk] Default to cache/windows_sdk.
...
This should allow better integration with buildbucket named cache
support. Since this was already parameterized it shouldn't actually
break anything; previously the directory would be deleted on every run,
now it will still be deleted on every run (but we can add a buildbucket
named cache entry for it to preserve it).
R=tandrii@chromium.org, vadimsh@chromium.org
Bug: 877775
Change-Id: I1184fb59a3ed18bfda5fcb288903201b01527096
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/1263861
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
7 years ago
Edward Lemur
0c3bd49069
bot_update: Don't use apply_patch_on_gclient.
...
It has been True by default for a while, and there is no need to override it.
Bug: 891917
Change-Id: I2598a2230b0ea38a647a533757331c541b871971
Reviewed-on: https://chromium-review.googlesource.com/c/1260057
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
7 years ago
recipe-roller
d1d4dc8eb8
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116 [cipd] Fix typo in pkg-deploy method. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5525b0182f7d6395cf66186fba4058dfc0d61496
Reviewed-on: https://chromium-review.googlesource.com/c/1263596
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
8e9443f5b7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/9f1afcb08b95a9c2cbae653dd320cd84d62287ff raw_io: pipe placeholder name through for input placeholders. (jbudorick@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5038f06949f8865afb59e614736923ba29547085
Reviewed-on: https://chromium-review.googlesource.com/c/1263595
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
cf257cec18
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/7d52a83204be2083edfc82042b13769846db9dff Update the recipes user guide to use post_process. (gbeaty@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61abce116cb3d914f057cdf33eb55579a82b49d2
Reviewed-on: https://chromium-review.googlesource.com/1249641
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
f221bac530
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/dc1bf00db5252bb54dd09745865c3160778a882d Fix cmd error in StepCommandContains check (aluo@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic85a74dbbbf78b069d29b26154e9321c96b36cea
Reviewed-on: https://chromium-review.googlesource.com/1247821
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
c8b28b92f6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/65fffecb2f6a041d71107292b1453a92ab1127fc Add post_process functions for asserting on a step's command. (gbeaty@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie68b5d385f6455604d95d89d0b1686e91969c0b2
Reviewed-on: https://chromium-review.googlesource.com/1247041
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
baf0927151
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/da81755358cf32a496ed8a9eddf6ec6d4f0efd18 post_process: Add StepCommandContains check. (jbudorick@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e3f14556e0ae66b3c5f6698be601e5b8930cad4
Reviewed-on: https://chromium-review.googlesource.com/1239096
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
0dc1fa0463
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ad0e2563a79f19f916cf2939811a2019dec16386 Improve local execution of recipes (martiniss@google.com )
https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e [buildbucket] Split try_build/ci_build (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I47055f996a36b2b9b39de7142d062b9c59be429d
Reviewed-on: https://chromium-review.googlesource.com/1239095
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Nodir Turakulov
92df4e63ab
Revert "[gclient] Use canonical URLs in solutions"
...
This reverts commit 7e301cfffe
.
Reason for revert: internal builds failed, e.g. bugdroid
Original change's description:
> [gclient] Use canonical URLs in solutions
>
> Strip ".git" suffix from all solution URLs.
>
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: release_scripts
> Bug: 877161
> Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d
> Reviewed-on: https://chromium-review.googlesource.com/1237332
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
TBR=nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
Change-Id: Ie24e10844ceb89071c9e665f2aa7dde9f9bf6e6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161
Reviewed-on: https://chromium-review.googlesource.com/1237423
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
Nodir Turakulov
7e301cfffe
[gclient] Use canonical URLs in solutions
...
Strip ".git" suffix from all solution URLs.
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Bug: 877161
Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d
Reviewed-on: https://chromium-review.googlesource.com/1237332
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
recipe-roller
a7faea85cf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01 [buildbucket] Add gitiles_commit shortcut (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icc8a9462ec44431c60f71a22f6ecc4d82aaa1e26
Reviewed-on: https://chromium-review.googlesource.com/1236897
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
0c22dec277
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3 [buildbucket] Fix typo. (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I566c81d35832b76a43e9bd54838bb6f95a0d8bad
Reviewed-on: https://chromium-review.googlesource.com/1236896
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
59b4089e70
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb [buildbucket] add builder_name (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8aa6eb66e991d5ec5ec556a3fa3b6ea43648fc40
Reviewed-on: https://chromium-review.googlesource.com/1236895
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
a5ac303c53
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/4232dd9f1c5aa35874d70634ae86f1cc4720bc6a Add documentation for placeholders. (erikchen@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2747491eef99bf0227d484be71a54203b02c794
Reviewed-on: https://chromium-review.googlesource.com/1236894
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
c169e83960
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ec1f045f324fd25c985a60cdcddb913f82da0490 Add AnnotationContains post processing step (erikchen@chromium.org )
https://crrev.com/702c6847b3cc129007d58f1ba864b009e820c11e [buildbucket] Populate created_by from legacy property (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb26c38e87c3789fce58fba5c8a5d0553be6bba3
Reviewed-on: https://chromium-review.googlesource.com/1234978
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
6eb711686a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640 [buildbucket] Add bucket_v1 property (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ed25d6f14e9526c4157a23c9a656c2be612a063
Reviewed-on: https://chromium-review.googlesource.com/1234977
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Nodir Turakulov
f837545214
[gclient] Remove patch_projects
...
It was superseded by repo_path_map.
Bug: 694348
Change-Id: If6b4790290bf2573f2a9367334decf064d382f52
Reviewed-on: https://chromium-review.googlesource.com/1232875
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
recipe-roller
2fbd3c8eb5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/7a22cddcd7f3255e357a63c73df4396a43def8cd [context] Stringify name_prefix if unicode in api.context (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib38a903cbb92fae8dd5c554f1054b44ef93110d0
Reviewed-on: https://chromium-review.googlesource.com/1232589
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Robert Iannucci
77900be4e7
[windows_sdk] Allow taskkill mspdbsrv to fail.
...
It looks like PNaCl actually depends on MSVC's presance, but doesn't
actually run any compile steps with it (instead using clang). That means
that mspdbsrv never actually runs during their build, and then the
taskkill fails.
R=hinoka@chromium.org, tandrii@chromium.org
Bug: 861512
Change-Id: I004d28f198224adaf16b1d3f14401b0d2a7d700b
Reviewed-on: https://chromium-review.googlesource.com/1232885
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
7 years ago
Nodir Turakulov
79c651330b
[gclient] Remove is_blink_mode
...
Not used
R=tandrii@chromium.org
Bug: 694348
Change-Id: I3188881b1f92df1cbfdbf3aafe309abb9488d9b2
Reviewed-on: https://chromium-review.googlesource.com/1232874
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
7 years ago
Nodir Turakulov
15b586a493
Remove PATCH_PROJECT
...
Remove PATCH_PROJECT from gclient config. It is not used.
R=tandrii@chromium.org
Bug: 694348
Change-Id: I56e4aefbe5e9b23296553bb61f878d6426197fa7
Reviewed-on: https://chromium-review.googlesource.com/1232873
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
7 years ago
Nodir Turakulov
53e28ecb9f
[gclient] Remove calculate_patch_root
...
It is not used. get_gerrit_patch_root is used instead.
Bug: 694348
Change-Id: Icc717e38cbcaa8050c8ce8a364202b81d7f9cf2c
Reviewed-on: https://chromium-review.googlesource.com/1231282
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
Nodir Turakulov
78eed01c0b
[bot_update] Use get_gerrit_patch_root
...
Use get_gerrit_patch_root in bot_update.ensure_checkout.
This fixes some tests expectations that expected CI builds to pass --patch_root
flag.
Also unify "root" and "patch_root" variables in ensure_checkout. Simpler.
This CL requires nontrivial rolls in all downstream packages because all
packages have incorrect expectations and/or tests.
In particular, this removes --patch_root flag from non-tryjob test
cases. Some tests are supposed to test tryjob scenario, but they use
properties.generic instead of properties.tryserver (or buildbucket.try_build)
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: skiabuildbot
Bug: 694348
Change-Id: Ibc594fa42e3b4d2823672b41dda2d97154b10d38
Reviewed-on: https://chromium-review.googlesource.com/1231280
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
Nodir Turakulov
dd2ce986ce
[gclient] Update set_patch_project_revision
...
Update set_patch_project_revision to use repo_path_map instead of
patch_projects.
Also rename to set_patch_repo_revision.
Bug: 694348
Change-Id: Iba31f4910f8282160000b8fcef197052597530a4
Reviewed-on: https://chromium-review.googlesource.com/1226107
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
7 years ago
Nodir Turakulov
33f71ae4d0
[bot_update] Update examples to use buildbucket module
...
Update bot_update full.py example to use buildbucket module.
Also remove buidlbucket example.
Bug: 694348
Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc
Reviewed-on: https://chromium-review.googlesource.com/1231281
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
Nodir Turakulov
7b54572eb0
[gclient] Fix typo in get_gerrit_patch_root
...
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1217670/17
used solution instead of solution name.
TBR=tandrii@chromium.org
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: I829cba9223d73383791b018f9a23598443e8fa2c
Reviewed-on: https://chromium-review.googlesource.com/1231278
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
Nodir Turakulov
0f322bfcf5
[bot_update] Add gclient.get_gerrit_patch_root
...
Add a shortcut for getting local path to the patch repo.
In bot_update.api._destination_branch, start using it instead of reading
gclient config directly. This removes one more patch_project usage.
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: If05371d0f6d11be6803ffa8392e029f5860dda25
Reviewed-on: https://chromium-review.googlesource.com/1217670
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
recipe-roller
804797362e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f7a834467c55fc302e5da1bdc0ef78c7bdecf2d9 Add comment to failing_step to indicate that it raises an exception. (erikchen@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b3ab8e2145e52711a7a725d6af77afb93f8ad0b
Reviewed-on: https://chromium-review.googlesource.com/1230793
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
53f9d8726a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b8db432be1add133ef005e17d5729c537349f2c9 analyze.py: Actually include default fields (martiniss@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ed2a785a4e25d4c93c1b1c32ea1489ee717d112
Reviewed-on: https://chromium-review.googlesource.com/1226231
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
b5e8781554
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/241d879a3dee0f9f1a0dc8933dc67f24e0d33391 analyze: Output field default values (martiniss@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefc3478b7e8857a23830a2d0788d3b3e45b1816b
Reviewed-on: https://chromium-review.googlesource.com/1226230
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
d42dfd429b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/04e26b62818d4848aed3631d9c58c2d41ecc2ed8 [buildbucket] Pass v2 build as a dict, not base64 bytes (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I756d39fb0004d220d4113ef56fffa3065674b32e
Reviewed-on: https://chromium-review.googlesource.com/1225671
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
982c799319
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/1f3949c4d11c89d35d1e4c688c3a1c14985bdad7 [file] Fix naming conflict bug in flatten_single_directories. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2ff5f1c89486ff05e4e5fba1d29e63d0fed7761
Reviewed-on: https://chromium-review.googlesource.com/1225670
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
77ed83d5a5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/5831fa01c47fb7248495566e80d4d049c47d3f78 Fix config.Dict.schema_proto. (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I708632280df12d762cc6e3fbcfdef327e2bf5ef1
Reviewed-on: https://chromium-review.googlesource.com/1225390
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
0425ebd2b3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ed19633e4183c8304db2a9bfd8646819c68ba5ba [tricium] Write tricium output as a string (juliehockett@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b14edc9a1a6c1a8eea61ab5573a8fa4a0cf1bf0
Reviewed-on: https://chromium-review.googlesource.com/1220109
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Nodir Turakulov
ddda0b5b8a
Fetch current Gerrit CL info in tryserver
...
Add tryserver.api.gerrit_change_info that returns detailed info about the
current Gerrit CL. It makes a Gerrit RPC in the background on the first read.
This step will be present in all tryjobs.
This mechanism can be used for extra details about the current CL.
This CL starts to use this in bot_update for gerrit_ref, and stops using
patch_ref property, and also update bot_update to use when the destination
branch is needed.
Also this CL removes no longer used properties in bot_update,
namely most of patch_* properties.
build.git manual roll: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1217626
Recipe-Manual-Change: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: skiabuildbot
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
R=tandrii@chromium.org
Bug: 694348
Change-Id: I945d061b74278c3d1d227578abe16a64cdaca647
Reviewed-on: https://chromium-review.googlesource.com/1213557
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
7 years ago
recipe-roller
56e273293a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/fc3791701f0801ab86e840225a7a566fee806ba0 [buildbucket] add revision param to try_build (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01d776eaf2db235ddb8875ae68a84f17dfdd3b75
Reviewed-on: https://chromium-review.googlesource.com/1217693
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
0f5fff6a3b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/35df4133e3d4282971f11b531c2e247c8644be81 [buildbucket] Remove gerrit_host param (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2cbe0fe2f514719f6d419f55110302cd8105ca53
Reviewed-on: https://chromium-review.googlesource.com/1217687
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
recipe-roller
727453b256
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e7c361bd4185326e511520b11950cab5d4291281 time module: Make sleep shell out sometimes (martiniss@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie6caee3f0811a3fded54338f3baf0a2685d42f7a
Reviewed-on: https://chromium-review.googlesource.com/1217684
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
Nodir Turakulov
11bc399153
[bot_update] add ignore_input_commit parameter
...
CrOS chromium-pfq builder uses bot_update, but checks out Chromium on its own,
effectively ignoring input commit in bot_update.
To resolve a P0, add ignore_input_commit parameter.
Long term, bot_update API must be redesigned.
TBR=tandrii@chromium.org
Bug: 882094
Change-Id: I4f43348e3d5f81bf603dd2c110829bce58acad16
Reviewed-on: https://chromium-review.googlesource.com/1216787
Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
Nodir Turakulov
d91f0adca2
Reland "[bot_update] Stop using repository properties"
...
This is a reland of 4d2b901804
verbatim. The problem was in the buildbucket recipe module, see
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1215002#message-2351f1089af71655dbaff576aa4d11f1dedc800b
Original change's description:
> [bot_update] Stop using repository properties
>
> Stop using repository and patch_repository_url properties.
> Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project}
> instead.
>
> R=ehmaldonado@chromium.org, tandrii@chromium.org
>
> Recipe-Nontrivial-Roll: build
> Bug: 877161, 694348
> Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056
> Reviewed-on: https://chromium-review.googlesource.com/1208368
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: skia
Bug: 877161, 694348
Change-Id: I0a10ca7814a8f5bdfd30a491e36fb7261cdaf225
Reviewed-on: https://chromium-review.googlesource.com/1214705
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
recipe-roller
bdd855ae63
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/596d92ee90439a73ae92c66bd25d9ec27e43b1a7 [buildbucket] Prefer patch_* properties (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaba289c2e1ddfb3de29364b82e44a184978940bb
Reviewed-on: https://chromium-review.googlesource.com/1217203
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago