This reverts commit 314e301879.
Reason for revert: On second thought, I don't think we want this.
Original change's description:
> cipd: remove windows-386
>
> Running depot_tools on Windows 32 bits is not supported anymore.
>
> Add a comment to cipd_manifest.txt to help people to figure out by themselves
> where to look to do a roll.
>
> Change-Id: I8a8c2d1437ec77c99588261e3eba0abdcb13c105
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630448
> Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
TBR=maruel@chromium.org,iannucci@chromium.org
Change-Id: I206becbf5bde4bb12e9d71ccab13027171fb017f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633030
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Running depot_tools on Windows 32 bits is not supported anymore.
Add a comment to cipd_manifest.txt to help people to figure out by themselves
where to look to do a roll.
Change-Id: I8a8c2d1437ec77c99588261e3eba0abdcb13c105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630448
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
luci-go @ b8f8bf3582b0bed4cde222f538b4ff04c0b0cfc0.
Backwards compatible.
Includes experimental CQ cancelation feature
and a bugfix for CQ groups w/o any builders.
R=vadimsh
note: roll will be trivial, footer below just for autoroller to let this CL in.
Recipe-Nontrivial-Roll: skia
Change-Id: Ief596c260276fc461d3dc473a7b89e20e863b965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620806
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
This picks up f6cef42987
which should help developers who have multiple python installations on PTAH.
R=tandrii@chromium.org, vadimsh@chromium.org
Bug: 957291
Change-Id: I8b6c3c4efc16dc7c40d649fa177aa6c4014e8226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592101
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Knows about GCE Provider protos and some new fields in CQ protos. No API
changes.
R=tandrii@chromium.org
Change-Id: I23e131423884d6ac785810a24526c0a89e32c328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1586375
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
The newest version isn't quite ready for prime-time (it drops support for the
`-repository` kitchen flag, which is still passed by buildbucket).
I should be able to reland this later today.
TBR=nodir@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
Bug: 936254
Change-Id: I18d25886cb008dc6f1a32a7ff85ec95b4a055b02
Reviewed-on: https://chromium-review.googlesource.com/c/1495205
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
cc015d890 Roll infra/go/src/go.chromium.org/luci/ 0d6874412..340fb1e12 (7 commits)
2378074b7 [led] Give auth-login advice everywhere we get an authClient.
b48969046 Roll infra/go/src/go.chromium.org/luci/ e48c958d0..44257920e (6 commits)
072630eb2 [led] Edit the right properties instead of the old properties :)
1673f6db0 [led] Remove interface abstraction
44ab51ec6 [led] Remove support for rietveld URLs.
R=nodir@chromium.org
Change-Id: Ic4d4842722a63bbd2369feff8c7df722eab86865
Reviewed-on: https://chromium-review.googlesource.com/c/1474426
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
It knows how to interpret configuration files written in Starlark-based
DSL and produce a bunch of protobuf messages as a result.
Will be used to generate various infra configs. In particular, will be
used by infra developers (to update configs), by PRESUBMIT.py on dev
machines (to verify configs before uploading CLs) and by bots (to verify
configs before submitting CLs).
R=tandrii@chromium.org
BUG=833946
Change-Id: Iceec7d808ce180f7d4a341fab8b5ce11933c2a6b
Reviewed-on: https://chromium-review.googlesource.com/c/1444499
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Fixes issue with bogus secret bytes being included when running
`led get-build`. The server would return "<REDACTED>".encode("base64"),
and led would pass this along to the task, which would fail to decode
it as a proto.
R=nodir@chromium.org, vadimsh@chromium.org
Change-Id: Ie8b33a2dc1f05ddb163465d72ea461f9e6833363
Reviewed-on: https://chromium-review.googlesource.com/c/1340504
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
The most notable change is in how the integrity of the tag cache file is
checked. Once deployed, existing tag cache files will be considered invalid and
wiped.
The only observable side effect is the following line in the log:
"can't deserialize tag cache - no sha256 is recorded in the file"
R=tandrii@chromium.org, iannucci@chromium.org
Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62
Reviewed-on: https://chromium-review.googlesource.com/c/1327823
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Together with already committed cipd_client_version.digests file, this
cryptographically binds contents of CIPD packages used by depot_tools
with depot_tool's git revision (assuming the CIPD client pinned by
cipd_client_version.digests is trusted too, which can presumably be
verified when it is being pinned).
This holds true even if the CIPD backend is compromised. The worst that
can happen is a denial of service (e.g. if the backend refuses to serve
packages at all).
If a bad backend tries to serve a malicious (unexpected) CIPD client,
'cipd' bootstrap script (and its powershell counterpart) will detect
a mismatch between SHA256 of the fetched binary and what's specified in
cipd_client_version.digests, and will refuse to run the untrusted binary.
Similarly, if the bad backend tries to serve some other unexpected
package (in place of a package specified in cipd_manifest.txt), the CIPD
client (already verified and trusted as this point) will detect a mismatch
between what was fetched and what's pinned in cipd_manifest.versions, and
will refuse to install untrusted files.
cipd_manifest.versions was generated from cipd_manifest.txt by:
$ cipd ensure-file-resolve -ensure-file cipd_manifest.txt
This will have to be rerun each time cipd_manifest.txt is updated. There's
a presubmit check that verifies *.versions file is up-to-date (it's part
of 'cipd ensure-file-verify').
BUG=870166
R=nodir@chromium.org, iannucci@chromium.org, tandrii@chromium.org
Change-Id: I25314adf0a9b05c69cd16e75aff01dbc79c87aa5
Reviewed-on: https://chromium-review.googlesource.com/1227435
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Robert Iannucci
Vadim Shtayura
Marc-Antoine Ruel
Andrii Shyshkalov
John Budorick
Nodir Turakulov
Ryan Tseng