These tools are still being evaluated and may change. get_build vs
get_build_from_id and get_build_from_build_number in particular are two
distinct ways of implementing the same tool that need to be compared.
get_build gives flexibility but is extremely verbose which means it
might be too flaky or consume unnecessary tokens. The return of these
might also need filtering for unnecessary output. Particularly steps
which can be very verbose without much information.
Bug: 430952168
Change-Id: Ia9b092a6b6c546198939deb36ea1b89ff33d7fc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6758660
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
This reverts commit dcbf502f02.
Reason for revert: Fixes have landed
Bug: 326277821
Original change's description:
> Telemetry: disable for non-linux
>
> Something about collecting traces before explicit opt-in is causing
> the output on win to get consumed. Disable for non-linux until I can
> more thoroughly test and figure out what's going on
>
> Bug: 326277821
> Change-Id: I8536cb61078ef98e37c5ab3e1c8abe2141a50eef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648247
> Auto-Submit: Struan Shrimpton <sshrimp@google.com>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
Bug: 326277821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I0d122895a832130fef5eebaf4cd4b5896dba4806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648626
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Using the logging library before UTR can set it up puts it in a weird
state that consumes all output. Instead of using logging, just print
anything from initializing telemetry.
Also make some small updated to avoid features not supported by
non-linux os's right now (these have been generating unnecessary
warnings)
Bug: 425298118
Change-Id: I1ccc749fb3c3410b105116ff25160fc23f0336df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648785
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
This adds a new option to bypass the googler check for bots which
might have unexpected hostnames
Bug: 326277821
Change-Id: I56aa2e60d9a7a91ba0b8c8202e659d5b35076c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6622310
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Something about collecting traces before explicit opt-in is causing
the output on win to get consumed. Disable for non-linux until I can
more thoroughly test and figure out what's going on
Bug: 326277821
Change-Id: I8536cb61078ef98e37c5ab3e1c8abe2141a50eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648247
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
The .vpython3 change is only necessary for running the opt in/out on
windows. Otherwise the only oddity was temporary files being weird
in windows.
Bug: 326277821
Change-Id: I88326410526d6fe7f6feb14a0bc27ab22eb12b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6615021
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Logging was missing from __init__.py which broke under mac. This adds
that back in and remove unused imports from other files. The os check
is also moved up to be the first thing we look for since is_google_host
does not work with mac at the moment.
Bug:326277821
Change-Id: I3f28838d367eb9583332fd33ad35d71c0851fe4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6604498
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
This includes initializing the module which will handle printing the
notice and enabling/disabling telemetry based on config. The __main__
file also allows for the banner to have a consistent entry point for
disabling telemetry so instrumenting programs don't need to worry
about it if they are using the same default config file.
Bug: 326277821
Change-Id: I861d6b9311ed48c2e1effcac22b314b73e2641e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5901465
Reviewed-by: Terrence Reilly <treilly@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
The detector can be a pretty direct port from chromite. A lot of these
metrics aren't likely neccesary but will be good to have complete
trace protos rather than missings parts. This also creates the
presubmit and .vpython3 file necessary to run the unit tests
Bug: 326277821
Change-Id: I4dbeabbbced4715527201eca888948b07b6004ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5840599
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Terrence Reilly <treilly@google.com>
Struan Shrimpton