aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,432 Commits
6 Branches
0 Tags
185 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '71b606ecff'
${ noResults }
Commit Graph

9432 Commits (71b606ecff3465d299e0862c006c3670e0e8defe)
 

Author SHA1 Message Date
Joanna Wang 6215dd0365 stacked-changes: Skip empty branches. 
Changes:
- _UploadAllPrecheck() returns a list of cls to upload that skips any empty commits in the stack.
- If the current branch is empty, we throw an error.
- UploadAllSquashed() now computes the parent to use for the squashed and cherry-pick flow.
  - for cherry-pick it uses the gerrit_squash_hash of the next cl in `cls`. This means it could be the gerrit_squash_hash of the direct ancestor OR the closest non-empty ancestor branch.
  - for multiple squashed commits, the first parent passed in is either:
     - the closest ancestor with a gerrit_squash_hash OR the common ancestor shared with the root of the tree.
- PrepareSquashedCommit() and PrepareCherryPick() now both require a parent passed in.

Bug:1411878, b/265929888
Change-Id: I7dba289defb40ed0464eabdb7e90810353ef155f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4220412
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 2c90793139 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789867372352400609

recipe_engine:
5960b43515
  5960b43 (juahurta@google.com)
      recipe_engine: add option to skip step presention when using fi...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie5ffa1cfc2958e0870db02fc4dc5f82354a23b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226466
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 8e50f83d28 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789884988438340625

recipe_engine:
6473859b07
  6473859 (zbikowski@google.com)
      Skip placeholder for get_file in url recipe module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09ab9e0e65e2e23c0ef70f951a7179725a1d8c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4225674
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Aravind Vasudevan ef2d011ad3 Do not add line break to the end of stdout/stderr 
gsutil.py adds a line break at the end of stdout/stderr when luci-auth is used. This change fixes it.

R=sokcevic, jojwang

Bug: 1412249, 1359383
Change-Id: Ieb200db94d9ed9149e17df93c33802a7433a8d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4221262
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
Aravind Vasudevan 91ea91249f Remove OOB deprecation log from gsutil 
This change removes OOB deprecation log from gsutil. This is no longer necessary and it hinders with tools that use gsutil.py.

R=sokcevic, jojwang

Bug: 1412249, 1359383
Change-Id: If47239520a15d24658314bd44570babf99831e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4221926
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Aravind Vasudevan a02b4bf030 Fix gerrit new-password URL 
This change fixes gerrit new-password URL from <host>-review.googlesource.com/new-password to <host>.googlesource.com/new-password.

Fixed: 1412557
Change-Id: I0c73e890fa9db5e2172d9a88cbc50703675e9f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219808
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
Junji Watanabe 963e01c76c Remove ninja entries from cipd_manifest.txt 
CIPD Ninja is installed by DEPS instead.

Bug: 1340825
Change-Id: I69106fe9b06154bac7db9278e905efb99e90974c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4220972
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Philipp Wollermann <philwo@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2 years ago
Joanna Wang 79499cf439 Update env_vars metrics name. 
Bug: b/265929888
Change-Id: Iaf2fd1d509f4390d26c8f4f74f863bbe3551600c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219773
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Loic Sharma e3fe027009 [Windows] Ignore extra spaces in ninja args 
The `ninja.py` script fails for this invocation:

```
ninja -C C:\Code\f\engine\src\out\host_debug_unopt\
 flutter_windows_unittests.exe
```

However, this works as expected:

```
ninja.exe -C C:\Code\f\engine\src\out\host_debug_unopt\
 flutter_windows_unittests.exe
```

Notice how there are extra spaces between the DIR and target. This bug breaks the Flutter engine's build integration with Visual Studio after `ninja.exe` was removed from depot_tools.

Here is an example MSBuild target that runs into this issue:

```xml
  <Target Name="Build">
    <Exec Command="call ninja -C $(OutDir)  flutter_windows_unittests.exe" />
  </Target>
```

Change-Id: Ib0022bc48151de438ac209fd07e0183872538ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215121
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Loïc Sharma <loicsharma@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
Joanna Wang 5ed21de943 Change env_variables to repeated metric. 
Bug: b/265929888
Change-Id: I7787e053ca0785801817e4916d9b25fa2ff0e8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219772
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 3d293077f4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790251781580695681

recipe_engine:
030e1286cc
  030e128 (yiwzhang@google.com)
      write summary markdown to expectation on build success and intr...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I26599e3816e488ddfb45b7d3f6bb9e372dfbcffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4218660
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Richard Wang 15d51f9304 Update Goma client 
Bug: b/266522285
Change-Id: I231af930254959f33da90540c8107d4c1b8a7b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4216156
Commit-Queue: Richard Wang <richardwa@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2 years ago
recipe-roller e33d80c935 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790314695148063617

recipe_engine:
d57dd757d9
  d57dd75 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f2c7e8383362 to 46eca1e3a280

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib812511316536d02ec1e34255dc7b1090d4ac9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215083
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Camilo Jacomet 8361a9b75d [auth][oob-deprecation]: Update CIPD entries for LUCI Auth. 
Bug:1406354,1411203
Change-Id: I0fac4d16a28945005bfa00af0bcf0a2144a2809f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215079
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
 2 years ago
Riley Wong c40715e2d2 Revert "Updating Lucicfg to Version 1.38.0" 
This reverts commit 6e096da546.

Reason for revert: Failure in lucicfg validate causing presubmit to fail

Original change's description:
> Updating Lucicfg to Version 1.38.0
>
> Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.
>
> Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>

Change-Id: I80031587b78f61a58f984d8695316328958bc147
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215612
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Riley Wong <rgw@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Leina Sun d41df98b29 [Pinpoint] Surface CLI priority flag to depot_tools 
Bug: chromium:1411458
Change-Id: Ife781433e2f1bf8d37990e6bc2e0108c980f9ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215115
Auto-Submit: Leina Sun <sunxiaodi@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2 years ago
Riley Wong 6e096da546 Updating Lucicfg to Version 1.38.0 
Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.

Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 2 years ago
Joanna Wang 92d7df88aa Add way to track env variables. 
Bug:b/265929888
Change-Id: Ibf24e9aae7bff1d9af36c15fc7f9bdad9dbba526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4209320
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Shelley Vohr 106754b269 Account for managed solution in src when finding ninja 
At present when looking for ninja, main only searches in two locations, gclient root and src. The Electron project lists Chromium’s src as a dependency in its DEPS file, so Ninja won’t be in the primary solution’s path (as it’s a transitive dependency, not a direct dependency of Chromium). This change adapts existing logic to account for that case.

Change-Id: I35aea29135d5968722a308bfb6dbb8a727550b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4203207
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
recipe-roller 3d072ab6fb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790412842174380129

recipe_engine:
8d334f01d4
  8d334f0 (dhanyaganesh@chromium.org)
      luci_analysis: Instead of hardcoded 'chromium' project, make it...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icdbebf1c455f8b1ff67e97b87d7c0b2b2de38e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4209167
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Joanna Wang c4ac30261d Revert auto-cc behavior back to original and fix comments. 
Bug: 1411521, b/265929888
Change-Id: I2d5908f4fb54ad11914d061539c4677e8320c163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4205471
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
recipe-roller 94b0eb1bb5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790492114932751121

recipe_engine:
895ffd7769
  895ffd7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e9c576da44c4 to c41d94e38272

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d659d5d446b57341bbdb918d40b43ef103b9432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204922
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 77f3ca4b16 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790504697511252929

recipe_engine:
410efdc8d6
  410efdc (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 66bc2247690a to dbdde7146475

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia49f4e0deaa69476207053c5525b51279829c085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204918
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Chan Li ed5ad736b6 [depot_tools] Roll lucicfg 
To release https://crrev.com/c/4163498

Bug: 1114804
Change-Id: Id93232e0197b9aa4682a649e7d64442db9af37f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204928
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 2 years ago
Josip Sokcevic fe5a0b1289 Use default number of cores for gclient jobs 
Instead of always setting jobs to 1 for ARM (which includes Mac), use
number of cores. Some old boards have not worked well with parallel
sync, but I don't have historical context was going on. My assumption is
that those boards were single-core.

See: https://codereview.chromium.org/10116033

R=aravindvasudev@google.com

Bug: 1410757
Change-Id: I0b7e3363375ba719c73d4d7141e6cab34bf7d32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4198732
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Aravind Vasudevan effdecd9ab Reland "Enable luci-auth by default" 
This reland includes fix for crbug.com/1410703. It fallbacks to normal gsutil call when luci-auth is not logged in.

This is a reland of commit a7b20b34f8

Original change's description:
> Enable luci-auth by default
>
> This change enables luci-auth by default for gsutil.py, replacing OOB authentication flow.
>
> Bug: 1359383
> Change-Id: I1a93edc0d04e03c13921359205f252b9e1ed7594
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193195
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1359383
Change-Id: I9acfa8a578de8e106346b83aae509f9ffe1146e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4199427
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Junji Watanabe 9d77ca716f [recipe] Remove depot_tools.{ninja_path, autoninja_path} recipe APIs 
I have replaced all the references, and there should be no references to these APIs anymore.

A PSA has been sent already.
http://g/chromium-dev-internal/n2IL0Mbh0E8

Bug: 1340825
Change-Id: Ife882f4427f8841cacb9a70a99dbd6a90c741da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4194896
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Junji Watanabe 8f41177abf Remove legacy ninja binaries 
PSA has already been sent to internal/external devs.
Internal: http://g/chromium-dev-internal/n2IL0Mbh0E8
External: https://groups.google.com/a/chromium.org/g/chromium-dev/c/027jM6DLkIk

Bug: 1340825
Change-Id: I9f3b4b2cb20147fd48ba379b257c7280ba9c53f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4194897
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Aravind Vasudevan b7d8efd8be Revert "Enable luci-auth by default" 
This reverts commit a7b20b34f8.

Reason for revert: http://go/crb/1410670

Original change's description:
> Enable luci-auth by default
>
> This change enables luci-auth by default for gsutil.py, replacing OOB authentication flow.
>
> Bug: 1359383
> Change-Id: I1a93edc0d04e03c13921359205f252b9e1ed7594
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193195
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1359383
Change-Id: I490cdc8a20e3ef0e87bd75eafd507698856b9374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4199424
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Joanna Wang 562481d6a9 Add dogfood path. 
- don't use `wip` as default for all dogfood changes
- don't use description hashtags for all dogfood changes

Bug: b/265929888
Change-Id: Ie19dedc980268e8a8d7ccf72c63b2a02790fb5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4198118
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang dd12deb5f5 Check for stacked changes dogfood var. 
Bug:b/265929888
Change-Id: Ibf1203994dea6e9db72fe4a954a2f6f24e30105b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4197875
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Vadim Shtayura 939cac7adb [cipd] Suppress findstr stdout. 
We only care about %ERRORLEVEL%.

R=bryner@google.com

Change-Id: Icb8770f5948f5744b451ff475d363e52858aa135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4190130
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2 years ago
Aravind Vasudevan a7b20b34f8 Enable luci-auth by default 
This change enables luci-auth by default for gsutil.py, replacing OOB authentication flow.

Bug: 1359383
Change-Id: I1a93edc0d04e03c13921359205f252b9e1ed7594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193195
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Camilo Jacomet 1ada93a104 [oob-deprecation][auth]: Update LUCI Auth Client. 
Per go/oauth-oob-deprecation we are switching to go/luci-cli-oauth-login  updating the packages that use luci-auth.

Bug:1406354
Change-Id: I3fc0fd2cc88d395f28e080d90aaaaae672c33da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4195020
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Leina Sun <sunxiaodi@google.com>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2 years ago
Joanna Wang c023a6302f Always set issue for branch, not just when newbranch is passed. 
Bug: 1410392
Change-Id: Ib9842a4924a6df486dc8b0ee37e673286139f62a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4196054
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang 44e9bee34f Allow --force to be used in cl patch with --reapply 
Bug: b/265929888
Change-Id: I7ed00d70d18463b3394915ae4c74f853d05cb88d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4191996
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller 46f6005bb1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790966490717964289

recipe_engine:
b34c3ccc07
  b34c3cc (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2b7112ea92cf to 221383f749a2

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa0b1206c3f27da82f745b740799cea3a42701e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4195019
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Joanna Wang c710e2d56a Connect new stacked changes implementation. 
Bug: b/265929888
Change-Id: I89f669d9d0a11f09a89c378222e6780ac9fcec34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4189199
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
recipe-roller 00be3f079a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8791045759625918689

recipe_engine:
45640f13eb
  45640f1 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 699a9d188d1b to 39717d29467a

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d4ea262ad49479594afc46b6e67b15966e009b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193192
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Joanna Wang 4049791e10 Create PostUploadUpdates func. 
Bug: b/265929888
Change-Id: If74949bfb6aafefc789d4e5e025ec15e81197380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4189838
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Joanna Wang a8db0cbb86 Remove unused git cl upload args. 
Bug: b/266235601

Change-Id: Iedefc213640faa664b05396565a4c158bfaa4403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4166483
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
Junji Watanabe 26b6c9b4cf Update goma client 
Bug: b/260020400
Change-Id: I6318481dc400429ab34cbd03b0b52bcaa02c4ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4189284
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
Joanna Wang a1abbeda6b [stacked-changes] Add refspec func. 
Bug: b/265929888
Change-Id: Ie8bd21b4f1b43a40f303dc1c93fc58becc76f9e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4182845
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang b88a4343de [stacked-changes] Prepare squashed commit 
Bug: b/265929888
Change-Id: Ia492666a5707996d94a4b6f7668ceaeb0eda8c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4182841
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
mlcui 7a0b4cb1e7 git_cl: Fix crashes when using --no-squash with detached HEAD 
Bug: None
Change-Id: If69d4f558bd01c439a68dfdab76755487b58dca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4183546
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Michael Cui <mlcui@google.com>
 2 years ago
Mike Frysinger 67702834cc cipd/python: optimize cat usage 
Bash has a builtin for reading files, so use that instead of running
the cat program to save on time & overhead.

Change-Id: Ia90fc22a47f2ead4ef056020a79ebdebd7bd70ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4111082
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Joanna Wang e852391441 [stacked_changes] Create cherry-picked commit. 
Bug:b/265929888
Change-Id: I4277474c1f09e4ac6ea6ebb5d9d340f22365f542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178924
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
Joanna Wang b46232e729 [stacked_changes] Add Changelist._PrepareChange() common func called before creating commits. 
Bug: b/265929888
Change-Id: I18a0c5ba6757aef91e750b9703079c96b090dc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178920
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang ab9c6ba27f Make cwd optional for scm.IsAncestor() 
Bug:b/265929888
Change-Id: I9f25cd26eaf2d708ce3ac7d86503bb2c295c8406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178351
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Joanna Wang 18de1f68e6 [git cl]Add precheck function for stacked changes upload. 
High-level rough draft: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4166282

Bug: b/265929888

Change-Id: I7881ade0ea97d7537e1dd40ab484ee5ef828aa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4175861
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago